watchdog: imx2_wdt: Improve dev_crit() message
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 watchdog: imx2_wdt: Improve dev_crit() message
From: Fabio Estevam <[email protected]>
After issuing a "poweroff" command the board goes through the expected power-off sequence and turns it off completely:
systemd-shutdown[1]: Powering off.
imx2-wdt 30280000.watchdog: Device shutdown: Expect reboot!
reboot: Power down
The "Expect reboot!" message is misleading because in the power-off case, no reboot is expected to happen at all.
Avoid the confusion by removing the "Expect reboot!" message.
--- drivers/watchdog/imx2_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/imx2_wdt.c +1 -1
@@ -374,7 +374,7 @@ static void imx2_wdt_shutdown(struct platform_device *pdev)*/ imx2_wdt_set_timeout (wdog,IMX2_WDT_MAX_TIME );imx2_wdt_ping (wdog); -dev_crit (&pdev->dev,"Device shutdown: Expect reboot!\n" ); +dev_crit (&pdev->dev,"Device shutdown.\n" ); } }
Signature · 1 line
2.34.1
Quoted 9 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
After issuing a "poweroff" command the board goes through the expected power-off sequence and turns it off completely:
systemd-shutdown[1]: Powering off.
imx2-wdt 30280000.watchdog: Device shutdown: Expect reboot!
reboot: Power down
Quoted 6 lines
The "Expect reboot!" message is misleading because in the power-off case, no reboot is expected to happen at all.
Avoid the confusion by removing the "Expect reboot!" message.
Signed-off-by Fabio Estevam <[email protected]>
Not sure if the message should be there in the first place. Anyway,
Quoted 20 lines
--- drivers/watchdog/imx2_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/imx2_wdt.c +1
-1@@ -374,7 +374,7 @@ static void imx2_wdt_shutdown(struct platform_device *pdev)*/ imx2_wdt_set_timeout (wdog,IMX2_WDT_MAX_TIME );imx2_wdt_ping (wdog); -dev_crit (&pdev->dev,"Device shutdown: Expect reboot!\n" ); +dev_crit (&pdev->dev,"Device shutdown.\n" ); } }Signature · 1 line
2.34.1