watchdog: simatic: Use idiomatic selection of P2SB
PATCH 1/1 watchdog: simatic: Use idiomatic selection of P2SB
While it's pretty much theoretical to be otherwise, make sure that P2SB is selected only for X86. This is idiomatic dependency which is used by all others who select it. Use it for Simatic as well.
--- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/Kconfig +1 -1
@@ -1685,7 +1685,7 @@ config SIEMENS_SIMATIC_IPC_WDT depends on SIEMENS_SIMATIC_IPC && PCI default y select WATCHDOG_CORE - select P2SB + select P2SB if X86 help This driver adds support for several watchdogs found in Industrial PCs from Siemens.
Signature · 1 line
2.40.0.1.gaa8946217a0b
Hi,
Quoted 4 lines · Andy Shevchenko
While it's pretty much theoretical to be otherwise, make sure that P2SB is selected only for X86. This is idiomatic dependency which is used by all others who select it. Use it for Simatic as well.
Hmm, this already depends on SIEMENS_SIMATIC_IPC which itself depends on X86, so as you already say this is not really necessary...
Quoted 1 line
Signed-off-by Andy Shevchenko <[email protected]>
Note this depends on / applies on top of 2 other
"config SIEMENS_SIMATIC_IPC_WDT" patches which
are currently pending in pdx86/for-next:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next
so this should probably be merged after 6.6-rc1 once these other changes have been merged.
Regards,
Hans
Quoted 17 lines
--- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/Kconfig +1
-1@@ -1685,7 +1685,7 @@ config SIEMENS_SIMATIC_IPC_WDT depends on SIEMENS_SIMATIC_IPC && PCI default y select WATCHDOG_CORE - select P2SB + select P2SB if X86 help This driver adds support for several watchdogs found in Industrial PCs from Siemens.
Quoted 8 lines · Hans de Goede
Quoted 4 lines · Andy Shevchenko
While it's pretty much theoretical to be otherwise, make sure that P2SB is selected only for X86. This is idiomatic dependency which is used by all others who select it. Use it for Simatic as well.
Hmm, this already depends on
SIEMENS_SIMATIC_IPCwhich itself depends on X86, so as you already say this is not really necessary...
Yes, but I want to keep that idiom, that's it.
It's purely style change.
Quoted 10 lines
Quoted 1 line
Signed-off-by Andy Shevchenko <[email protected]>Note this depends on / applies on top of 2 other
"configSIEMENS_SIMATIC_IPC_WDT" patches which
are currently pending in pdx86/for-next:https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next
so this should probably be merged after 6.6-rc1 once these other changes have been merged.
Or with an Ack from watchdog maintainers... Whatever is the best for you, folks. I'm fine with either choice.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 6 lines · Andy Shevchenko
While it's pretty much theoretical to be otherwise, make sure that P2SB is selected only for X86. This is idiomatic dependency which is used by all others who select it. Use it for Simatic as well.
Signed-off-by Andy Shevchenko <[email protected]>
Hans, can you take this one as well ?
Thanks,
Guenter
Quoted 20 lines
--- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/Kconfig +1
-1@@ -1685,7 +1685,7 @@ config SIEMENS_SIMATIC_IPC_WDT depends on SIEMENS_SIMATIC_IPC && PCI default y select WATCHDOG_CORE - select P2SB + select P2SB if X86 help This driver adds support for several watchdogs found in Industrial PCs from Siemens.Signature · 1 line
2.40.0.1.gaa8946217a0b
Hi,
Quoted 11 lines · Guenter Roeck
Quoted 6 lines · Andy Shevchenko
While it's pretty much theoretical to be otherwise, make sure that P2SB is selected only for X86. This is idiomatic dependency which is used by all others who select it. Use it for Simatic as well.
Signed-off-by Andy Shevchenko <[email protected]>Acked-by Guenter Roeck <[email protected]>Hans, can you take this one as well ?
Yes, done:
Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.
Regards,
Hans
Quoted 21 lines
Quoted 20 lines
--- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/Kconfig +1
-1@@ -1685,7 +1685,7 @@ config SIEMENS_SIMATIC_IPC_WDT depends on SIEMENS_SIMATIC_IPC && PCI default y select WATCHDOG_CORE - select P2SB + select P2SB if X86 help This driver adds support for several watchdogs found in Industrial PCs from Siemens.Signature · 1 line
2.40.0.1.gaa8946217a0b