package/gmp: fix compile error for riscv
PATCH 1/1 package/gmp: fix compile error for riscv
In commit 87b2a30319394c2cc79efae1af7833cad8c62b32 gmp got updated to 6.2.1, since then the compile error exist.
Compile error looks like this:
tmp-mul_1.s: Assembler messages:
tmp-mul_1.s:55: Error: unrecognized opcode mul a5,a7,a3' tmp-mul_1.s:57: Error: unrecognized opcode mulhu a7,a7,a3'
Patch should be backported to stable branches.
Fixes:
- http://autobuild.buildroot.net/results/2f2/2f2112bea73adbf49eabb62fe6cda6a9cd5d0567
- http://autobuild.buildroot.net/results/566/566a4945555b781ed127997176f73b3c17ecab5d
--- package/gmp/gmp.mk | 5 +++++ 1 file changed, 5 insertions(+)
package/gmp/gmp.mk +5 -0
@@ -23,6 +23,11 @@ ifeq ($(BR2_m68k_cf)$(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6)$(BR2_ARM_CP GMP_CONF_OPTS += --disable-assembly endif +# GMP needs M extension for riscv assembly +ifeq ($(BR2_RISCV_ISA_CUSTOM_RVM),) +GMP_CONF_OPTS += --disable-assembly +endif + ifeq ($(BR2_INSTALL_LIBSTDCPP),y) GMP_CONF_OPTS += --enable-cxx else
Signature · 6 lines
2.39.2 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedQuoted 10 lines · On Tue, 22 Aug 2023 09:45:11 +0200 Waldemar Brodkorb <[email protected]> wrote:
In commit
87b2a30319394c2cc79efae1af7833cad8c62b32gmp got updated to 6.2.1, since then the compile error exist.Compile error looks like this:
tmp-mul_1.s: Assembler messages:
tmp-mul_1.s:55: Error: unrecognized opcodemul a5,a7,a3' tmp-mul_1.s:57: Error: unrecognized opcodemulhu a7,a7,a3'Patch should be backported to stable branches.
Quoted 8 lines
Fixes:
- http://autobuild.buildroot.net/results/2f2/2f2112bea73adbf49eabb62fe6cda6a9cd5d0567
- http://autobuild.buildroot.net/results/566/566a4945555b781ed127997176f73b3c17ecab5dSigned-off-by Waldemar Brodkorb <[email protected]>--- package/gmp/gmp.mk | 5 +++++ 1 file changed, 5 insertions(+)
Applied to master, thanks.
Yann, Peter: I have intentionally cherry-picked this patch into the next branch as well, but it is slightly different due to the renaming of the RISC-V option. I did it now because my thinking is that if I don't do it now while merging the patch, we will forget about it when we merge back next into master. At least here, there will be a very easy to resolve merge conflict, and we will notice that we need to keep the version coming from the next branch. Let me know if you find this sensible or stupid, so that I know how to do better next time if needed :-)
Best regards,
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Waldemar" == Waldemar Brodkorb <[email protected]> writes:
In commit
87b2a30319394c2cc79efae1af7833cad8c62b32gmp got updated to 6.2.1, since then the compile error exist.Compile error looks like this:
tmp-mul_1.s: Assembler messages:
tmp-mul_1.s:55: Error: unrecognized opcodemul a5,a7,a3' tmp-mul_1.s:57: Error: unrecognized opcodemulhu a7,a7,a3'
Quoted 7 lines
Patch should be backported to stable branches.
Fixes:
- http://autobuild.buildroot.net/results/2f2/2f2112bea73adbf49eabb62fe6cda6a9cd5d0567
- http://autobuild.buildroot.net/results/566/566a4945555b781ed127997176f73b3c17ecab5dSigned-off-by Waldemar Brodkorb <[email protected]>
Committed to 2023.02.x and 2023.05.x, thanks.
Signature · 5 lines
Bye, Peter Korsgaard _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot