Skip to contentSkip to conversation

dt-bindings: phy: st: convert phy-stih407-usb to DT schema

PATCH Superseded Raphael Gallais-Pou 2 participants 2 messages Aug 22, 2023 – Aug 23, 2023

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: phy: st: convert phy-stih407-usb to DT schema

Convert the st,stih407-usb2-phy binding to DT schema format.

---
Changes in v2:
* Removed quotes surrounding $ref
* Removed quotes surrounding const properties
* Changed 'st,syscfg' $ref value to phandle-array
* Changed authorship to my oss email address

---
 .../bindings/phy/phy-stih407-usb.txt          | 24 -------
 .../bindings/phy/st,stih407-usb2-phy.yaml     | 64 +++++++++++++++++++
 2 files changed, 64 insertions(+), 24 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/phy/phy-stih407-usb.txt
 create mode 100644 Documentation/devicetree/bindings/phy/st,stih407-usb2-phy.yaml
Documentation/devicetree/bindings/phy/phy-stih407-usb.txt deleted +0 -24
deleted file mode 100644
index 35f03df00130..000000000000
@@ -1,24 +0,0 @@
-ST STiH407 USB PHY controller
-
-This file documents the dt bindings for the usb picoPHY driver which is the PHY for both USB2 and USB3
-host controllers (when controlling usb2/1.1 devices) available on STiH407 SoC family from STMicroelectronics.
-
-Required properties:
-- compatible		: should be "st,stih407-usb2-phy"
-- st,syscfg		: phandle of sysconfig bank plus integer array containing phyparam and phyctrl register offsets
-- resets		: list of phandle and reset specifier pairs. There should be two entries, one
-			  for the whole phy and one for the port
-- reset-names		: list of reset signal names. Should be "global" and "port"
-See: Documentation/devicetree/bindings/reset/st,stih407-powerdown.yaml
-See: Documentation/devicetree/bindings/reset/reset.txt
-
-Example:
-
-usb2_picophy0: usbpicophy@f8 {
-	compatible	= "st,stih407-usb2-phy";
-	#phy-cells	= <0>;
-	st,syscfg	= <&syscfg_core 0x100 0xf4>;
-	resets		= <&softreset STIH407_PICOPHY_SOFTRESET>,
-			  <&picophyreset STIH407_PICOPHY0_RESET>;
-	reset-names	= "global", "port";
-};
Documentation/devicetree/bindings/phy/st,stih407-usb2-phy.yaml new file +64 -0

64 lines not on this page · raw message

Signature · 1 line
2.41.0
#1 lore raw
Quoted 4 lines · Raphael Gallais-Pou

Convert the st,stih407-usb2-phy binding to DT schema format.

---

Thank you for your patch. There is something to discuss/improve. Minor change needed at the end. While at it, few more nits (which I would skip if not that change).

Quoted 5 lines

Changes in v2:
* Removed quotes surrounding $ref
* Removed quotes surrounding const properties
* Changed 'st,syscfg' $ref value to phandle-array
* Changed authorship to my oss email addressThank you for your patch. There is something to discuss/improve.

Nit: Drop "driver" and any other driver references. Instead, focus on device.

Quoted 13 lines
Documentation/devicetree/bindings/phy/st,stih407-usb2-phy.yaml new file +13 -0
+  (when controlling usb2/1.1 devices) available on STiH407 SoC family from
+  STMicroelectronics.
+
+properties:
+  compatible:
+    const: st,stih407-usb2-phy
+
+  st,syscfg:
+    description: Phandle to the syscfg bank
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    items:
+      - items:
+          - description: phandle to syscfg

Documentation/devicetree/bindings/phy/st,stih407-usb2-phy.yaml line 36

Quoted 10 lines
Documentation/devicetree/bindings/phy/st,stih407-usb2-phy.yaml new file +10 -0
+          - description: phyparam register offset
+          - description: phyctrl register offset
+
+  resets:
+    items:
+      - description: Phandle and reset specifier pair for the whole phy.
+      - description: Phandle and reset specifier pair for the port.
+
+  reset-names:
+    description: List of reset signal names.

Nit: drop description, it is obvious.

Quoted 10 lines
Documentation/devicetree/bindings/phy/st,stih407-usb2-phy.yaml new file +10 -0
+    items:
+      - const: global
+      - const: port
+
+  "#phy-cells":
+    const: 0
+
+required:
+  - compatible
+  - st,syscfg

Documentation/devicetree/bindings/phy/st,stih407-usb2-phy.yaml line 56

Quoted 10 lines
Documentation/devicetree/bindings/phy/st,stih407-usb2-phy.yaml new file +10 -0
+  - resets
+  - reset-names
+  - "#phy-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/reset/stih407-resets.h>
+    usb2_picophy0: usbpicophy {

Drop unused label, and make node name as: usb-phy or phy

https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Best regards,
Krzysztof