platform/x86: mlx-platform: Fix 0-DAY CI warning
PATCH 1/1 platform/x86: mlx-platform: Fix 0-DAY CI warning
Fix 0-DAY CI warning: unused variable 'mlxplat_acpi_table'.
Add dependency on "ACPI" to Kconfig file.
Remove "ACPI_PTR", use plain assignment to 'mlxplat_acpi_table'.
--- drivers/platform/x86/Kconfig | 1 + drivers/platform/x86/mlx-platform.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/platform/x86/Kconfig +1 -0
@@ -965,6 +965,7 @@ config SERIAL_MULTI_INSTANTIATE config MLX_PLATFORM tristate "Mellanox Technologies platform support" + depends on ACPI depends on I2C select REGMAP help
drivers/platform/x86/mlx-platform.c +1 -1
@@ -6629,7 +6629,7 @@ MODULE_DEVICE_TABLE(acpi, mlxplat_acpi_table);static struct platform_driver mlxplat_driver = { .driver = { .name ="mlxplat" , - .acpi_match_table =ACPI_PTR (mlxplat_acpi_table), + .acpi_match_table = mlxplat_acpi_table, .probe_type =PROBE_FORCE_SYNCHRONOUS , }, .probe = mlxplat_probe,
Signature · 1 line
2.20.1
Hi,
Quoted 9 lines · Vadim Pasternak
Fix 0-DAY CI warning: unused variable '
mlxplat_acpi_table'.Add dependency on "ACPI" to
Kconfigfile.
Remove "ACPI_PTR", use plain assignment to 'mlxplat_acpi_table'.Fixes e2185e8f37ef ("platform: mellanox: mlx-platform: Introduce ACPI init flow")Reported-by kernel test robot <[email protected]>Signed-off-by Vadim Pasternak <[email protected]>
Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.
Regards,
Hans
Quoted 30 lines
--- drivers/platform/x86/Kconfig | 1 + drivers/platform/x86/mlx-platform.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)drivers/platform/x86/Kconfig +1
-0@@ -965,6 +965,7 @@ config SERIAL_MULTI_INSTANTIATE config MLX_PLATFORM tristate "Mellanox Technologies platform support" + depends on ACPI depends on I2C select REGMAP helpdrivers/platform/x86/mlx-platform.c +1
-1@@ -6629,7 +6629,7 @@ MODULE_DEVICE_TABLE(acpi, mlxplat_acpi_table);static struct platform_driver mlxplat_driver = { .driver = { .name ="mlxplat" , - .acpi_match_table =ACPI_PTR (mlxplat_acpi_table), + .acpi_match_table = mlxplat_acpi_table, .probe_type =PROBE_FORCE_SYNCHRONOUS , }, .probe = mlxplat_probe,
Hi,
Quoted 13 lines · Hans de Goede
Hi,
Quoted 9 lines · Vadim Pasternak
Fix 0-DAY CI warning: unused variable '
mlxplat_acpi_table'.Add dependency on "ACPI" to
Kconfigfile.
Remove "ACPI_PTR", use plain assignment to 'mlxplat_acpi_table'.Fixes e2185e8f37ef ("platform: mellanox: mlx-platform: Introduce ACPI init flow")Reported-by kernel test robot <[email protected]>Signed-off-by Vadim Pasternak <[email protected]>
Quoted 8 lines
Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hansOnce I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.
Note I have to do a forced push to my review-hans branch due to an author vs s-o-b mismatch which I missed earlier.
As part of that I'm going to squash this fix into the original e2185e8f37ef ("platform: mellanox: mlx-platform: Introduce ACPI init flow") commit.
Regards,
Hans
Quoted 31 lines
Quoted 30 lines
--- drivers/platform/x86/Kconfig | 1 + drivers/platform/x86/mlx-platform.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)drivers/platform/x86/Kconfig +1
-0@@ -965,6 +965,7 @@ config SERIAL_MULTI_INSTANTIATE config MLX_PLATFORM tristate "Mellanox Technologies platform support" + depends on ACPI depends on I2C select REGMAP helpdrivers/platform/x86/mlx-platform.c +1
-1@@ -6629,7 +6629,7 @@ MODULE_DEVICE_TABLE(acpi, mlxplat_acpi_table);static struct platform_driver mlxplat_driver = { .driver = { .name ="mlxplat" , - .acpi_match_table =ACPI_PTR (mlxplat_acpi_table), + .acpi_match_table = mlxplat_acpi_table, .probe_type =PROBE_FORCE_SYNCHRONOUS , }, .probe = mlxplat_probe,