Skip to contentSkip to conversation

ceph: Remove duplicate include

PATCH In review Jiapeng Chong 3 participants 3 messages Aug 24, 2023 Ceph client

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ceph: Remove duplicate include

./fs/ceph/mds_client.c: crypto.h is included more than once.

---
 fs/ceph/mds_client.c | 1 -
 1 file changed, 1 deletion(-)
fs/ceph/mds_client.c +0 -1
index 7cfa0e3aedb4..9a3b617270c3 100644
@@ -16,7 +16,6 @@
 #include "super.h"
 #include "crypto.h"
 #include "mds_client.h"
-#include "crypto.h"
 
 #include <linux/ceph/ceph_features.h>
 #include <linux/ceph/messenger.h>
Signature · 1 line
2.20.1.7.g153144c
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Jiapeng Chong

./fs/ceph/mds_client.c: crypto.h is included more than once.

---
  fs/ceph/mds_client.c | 1 -
  1 file changed, 1 deletion(-)
fs/ceph/mds_client.c +0 -0
index 7cfa0e3aedb4..9a3b617270c3 100644

fs/ceph/mds_client.c line 21

Quoted 7 lines
fs/ceph/mds_client.c +0 -1
@@ -16,7 +16,6 @@
  #include "super.h"
  #include "crypto.h"
  #include "mds_client.h"
-#include "crypto.h"
 
  #include <linux/ceph/ceph_features.h>
  #include <linux/ceph/messenger.h>
maintainer
#2 lore raw
Quoted 22 lines · Xiubo Li
Quoted 19 lines · Jiapeng Chong

./fs/ceph/mds_client.c: crypto.h is included more than once.

---
  fs/ceph/mds_client.c | 1 -
  1 file changed, 1 deletion(-)
fs/ceph/mds_client.c +0 -1
index 7cfa0e3aedb4..9a3b617270c3 100644
@@ -16,7 +16,6 @@
  #include "super.h"
  #include "crypto.h"
  #include "mds_client.h"
-#include "crypto.h"
 
Quoted 4 lines

fs/ceph/mds_client.c line 21

Quoted 2 lines
fs/ceph/mds_client.c +0 -0
  #include <linux/ceph/ceph_features.h>
  #include <linux/ceph/messenger.h>

I folded the fix into "ceph: encode encrypted name in ceph_mdsc_build_path and dentry release" commit. Thanks for the report!

Ilya