Skip to contentSkip to conversation

docs: netdev: recommend against --in-reply-to

PATCH Applied Jakub Kicinski 5 participants 6 messages Aug 23, 2023 – Oct 30, 2023

Subsystems (4)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 docs: netdev: recommend against --in-reply-to

It's somewhat unfortunate but with (my?) the current tooling if people post new versions of a set in reply to an old version managing the review queue gets difficult. So recommend against it.

---
 Documentation/process/maintainer-netdev.rst | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/process/maintainer-netdev.rst +6 -0
index 2ab843cde830..c1c732e9748b 100644
@@ -167,6 +167,8 @@ Asking the maintainer for status updates on your
 patch is a good way to ensure your patch is ignored or pushed to the
 bottom of the priority list.
 
+.. _Changes requested:
+
 Changes requested
 ~~~~~~~~~~~~~~~~~
 
@@ -359,6 +361,10 @@ Make sure you address all the feedback in your new posting. Do not post a new
 version of the code if the discussion about the previous version is still
 ongoing, unless directly instructed by a reviewer.
 
+The new version of patches should be posted as a separate thread,
+not as a reply to the previous posting. Change log should include a link
+to the previous posting (see :ref:`Changes requested`).
+
 Testing
 -------
 
Signature · 1 line
2.41.0
#1 lore raw
Quoted 3 lines · Jakub Kicinski

It's somewhat unfortunate but with (my?) the current tooling if people post new versions of a set in reply to an old version managing the review queue gets difficult. So recommend against it.

For my setup it is also annoying.

(CC IWL + BCC to our pre-IWL list.)

Quoted 30 lines
---
  Documentation/process/maintainer-netdev.rst | 6 ++++++
  1 file changed, 6 insertions(+)
Documentation/process/maintainer-netdev.rst +6 -0
index 2ab843cde830..c1c732e9748b 100644
@@ -167,6 +167,8 @@ Asking the maintainer for status updates on your
  patch is a good way to ensure your patch is ignored or pushed to the
  bottom of the priority list.
 
+.. _Changes requested:
+
  Changes requested
  ~~~~~~~~~~~~~~~~~
 
@@ -359,6 +361,10 @@ Make sure you address all the feedback in your new posting. Do not post a new
  version of the code if the discussion about the previous version is still
  ongoing, unless directly instructed by a reviewer.
 
+The new version of patches should be posted as a separate thread,
+not as a reply to the previous posting. Change log should include a link
+to the previous posting (see :ref:`Changes requested`).
+
  Testing
  -------
 
Reviewed-by on v1 1/1
#2 lore raw
In reply to Jakub Kicinski
Quoted 3 lines · Jakub Kicinski

It's somewhat unfortunate but with (my?) the current tooling if people post new versions of a set in reply to an old version managing the review queue gets difficult. So recommend against it.

Is this something NIPA could catch?

Quoted 2 lines
Quoted 31 lines
---
 Documentation/process/maintainer-netdev.rst | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/process/maintainer-netdev.rst +6 -0
index 2ab843cde830..c1c732e9748b 100644
@@ -167,6 +167,8 @@ Asking the maintainer for status updates on your
 patch is a good way to ensure your patch is ignored or pushed to the
 bottom of the priority list.
 
+.. _Changes requested:
+
 Changes requested
 ~~~~~~~~~~~~~~~~~
 
@@ -359,6 +361,10 @@ Make sure you address all the feedback in your new posting. Do not post a new
 version of the code if the discussion about the previous version is still
 ongoing, unless directly instructed by a reviewer.
 
+The new version of patches should be posted as a separate thread,
+not as a reply to the previous posting. Change log should include a link
+to the previous posting (see :ref:`Changes requested`).
+
 Testing
 -------
 
Signature · 1 line
2.41.0
author maintainer
#3 lore raw
Quoted 6 lines · On Thu, 24 Aug 2023 10:08:54 +0100 Martin Habets wrote:
Quoted 3 lines · Jakub Kicinski

It's somewhat unfortunate but with (my?) the current tooling if people post new versions of a set in reply to an old version managing the review queue gets difficult. So recommend against it.

Is this something NIPA could catch?

I think so, but the whole thing makes me feel bad. I mean, if I was to sit down to write some code I should probably try to hack up my email client to allow force-breaking threads?

#4 lore raw
Quoted 6 lines · Jakub Kicinski
Quoted 5 lines · On Thu, 24 Aug 2023 10:08:54 +0100 Martin Habets wrote:
Quoted 3 lines · Jakub Kicinski

It's somewhat unfortunate but with (my?) the current tooling if people post new versions of a set in reply to an old version managing the review queue gets difficult. So recommend against it.

Quoted 6 lines
Quoted 1 line

Is this something NIPA could catch?

I think so, but the whole thing makes me feel bad. I mean, if I was to sit down to write some code I should probably try to hack up my email client to allow force-breaking threads?

Yea if I were to do anything else here it would be figure out how to make the tooling handle this better somehow rather than trying to enforce not doing it.

However, I agree recommending avoiding this is good.

Thanks,
Jake

#5 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Wed, 23 Aug 2023 08:49:22 -0700 you wrote:

It's somewhat unfortunate but with (my?) the current tooling if people post new versions of a set in reply to an old version managing the review queue gets difficult. So recommend against it.

---
 Documentation/process/maintainer-netdev.rst | 6 ++++++
 1 file changed, 6 insertions(+)

Here is the summary with links:
- [net-next] docs: netdev: recommend against --in-reply-to

    https://git.kernel.org/netdev/net-next/c/35b4b6d0c53a

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html