Skip to contentSkip to conversation

sfc: Check firmware supports Ethernet PTP filter

PATCH Applied [email protected] 2 participants 2 messages Aug 24, 2023 – Aug 26, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sfc: Check firmware supports Ethernet PTP filter

From: Alex Austin <[email protected]>

Not all firmware variants support RSS filters. Do not fail all PTP functionality when raw ethernet PTP filters fail to insert.

Fixes e4616f64726b ("sfc: support PTP over Ethernet")
---
 drivers/net/ethernet/sfc/ptp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ethernet/sfc/ptp.c +3 -1
index 0c40571133cb..00cf6de3bb2b 100644
@@ -1485,7 +1485,9 @@ static int efx_ptp_insert_multicast_filters(struct efx_nic *efx)
 			goto fail;
 
 		rc = efx_ptp_insert_eth_multicast_filter(efx);
-		if (rc < 0)
+
+		/* Not all firmware variants support this filter */
+		if (rc < 0 && rc != -EPROTONOSUPPORT)
 			goto fail;
 	}
 
Signature · 1 line
2.17.1
#1 lore raw
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 11 lines · On Thu, 24 Aug 2023 17:46:57 +0100 you wrote:

From: Alex Austin <[email protected]>

Not all firmware variants support RSS filters. Do not fail all PTP functionality when raw ethernet PTP filters fail to insert.

Fixes e4616f64726b ("sfc: support PTP over Ethernet")

[...]

Here is the summary with links:
- [net] sfc: Check firmware supports Ethernet PTP filter

    https://git.kernel.org/netdev/net/c/c4413a20fa6d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html