Skip to contentSkip to conversation

package/gmp: guard riscv definition

PATCH In review Waldemar Brodkorb 3 participants 3 messages Aug 24, 2023 – Sep 13, 2023

lore
Share & tools
lore

Waldemar Brodkorb

author
#0 lore raw

PATCH 1/1 package/gmp: guard riscv definition

In commit 30997eaa65438a2ce726ad8a204ac5a36363f5c8 a mistake was made. Guard the definition correctly.

Signed-off-by Waldemar Brodkorb <[email protected]>
---
 package/gmp/gmp.mk | 2 ++
 1 file changed, 2 insertions(+)
package/gmp/gmp.mk +2 -0
index 3b732dfa71..1ef4dd43a2 100644
@@ -24,9 +24,11 @@ GMP_CONF_OPTS += --disable-assembly
 endif
 
 # GMP needs M extension for riscv assembly
+ifeq ($(BR2_riscv),y)
 ifeq ($(BR2_RISCV_ISA_CUSTOM_RVM),)
 GMP_CONF_OPTS += --disable-assembly
 endif
+endif
 
 ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
 GMP_CONF_OPTS += --enable-cxx
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 3 lines · On Thu, 24 Aug 2023 07:02:26 +0200 Waldemar Brodkorb <[email protected]> wrote:

# GMP needs M extension for riscv assembly
+ifeq ($(BR2_riscv),y)
ifeq ($(BR2_RISCV_ISA_CUSTOM_RVM),)

Changed to:

+ifeq ($(BR2_riscv):$(BR2_RISCV_ISA_CUSTOM_RVM),y:)

and applied to master. Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Waldemar Brodkorb
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Waldemar" == Waldemar Brodkorb <[email protected]> writes:

In commit 30997eaa65438a2ce726ad8a204ac5a36363f5c8 a mistake was made. Guard the definition correctly.

Signed-off-by Waldemar Brodkorb <[email protected]>

Committed to 2023.02.x and 2023.05.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot