ice: add drop rule matching on not active lport
Subsystems (3)
PATCH v2 1/1 ice: add drop rule matching on not active lport
Inactive LAG port should not receive any packets, as it can cause adding invalid FDBs (bridge offload). Add a drop rule matching on inactive lport in LAG.
---
v1 --> v2 (based on Olek comments):
* remove zeroes from tabels
* style changes
--- .../net/ethernet/intel/ice/ice_eswitch_br.c | 6 +- drivers/net/ethernet/intel/ice/ice_lag.c | 87 +++++++++++++++---- drivers/net/ethernet/intel/ice/ice_lag.h | 2 + 3 files changed, 75 insertions(+), 20 deletions(-)
drivers/net/ethernet/intel/ice/ice_eswitch_br.c +3 -3
@@ -73,7 +73,7 @@ ice_eswitch_br_ingress_rule_setup(struct ice_adv_rule_info *rule_info, rule_info->sw_act.vsi_handle = vf_vsi_idx; rule_info->sw_act.flag |=ICE_FLTR_RX ; rule_info->sw_act.src = pf_id; - rule_info->priority =5 ; + rule_info->priority =2 ; } static void
@@ -84,7 +84,7 @@ ice_eswitch_br_egress_rule_setup(struct ice_adv_rule_info *rule_info, rule_info->sw_act.flag |=ICE_FLTR_TX ; rule_info->flags_info.act =ICE_SINGLE_ACT_LAN_ENABLE ; rule_info->flags_info.act_valid = true; - rule_info->priority =5 ; + rule_info->priority =2 ; } static int
@@ -207,7 +207,7 @@ ice_eswitch_br_guard_rule_create(struct ice_hw *hw, u16 vsi_idx, rule_info.allow_pass_l2 = true; rule_info.sw_act.vsi_handle = vsi_idx; rule_info.sw_act.fltr_act =ICE_NOP ; - rule_info.priority =5 ; + rule_info.priority =2 ; err =ice_add_adv_rule (hw, list, lkups_cnt, &rule_info, rule);if (err)
drivers/net/ethernet/intel/ice/ice_lag.c +70 -17
186 lines not on this page · raw message
drivers/net/ethernet/intel/ice/ice_lag.h +2 -0
@@ -39,8 +39,10 @@ struct ice_lag { u8 bonded:1; /* currently bonded */ u8 primary:1; /* this is primary */u16 pf_recipe; +u16 lport_recipe;u16 pf_rule_id;u16 cp_rule_idx; +u16 lport_rule_idx;u8 role; };
Signature · 6 lines
2.41.0 _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Quoted 22 lines
-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Michal Swiatkowski
Sent: Friday, August 25, 2023 12:43 PM
To: [email protected]
Cc: Szycik, Marcin <[email protected]>; [email protected]; Simon Horman <[email protected]>
Subject: [Intel-wired-lan] [PATCH iwl-next v2] ice: add drop rule matching on not active lportInactive LAG port should not receive any packets, as it can cause adding invalid FDBs (bridge offload). Add a drop rule matching on inactive lport in LAG.
Reviewed-by Simon Horman <[email protected]>Co-developed-by Marcin Szycik <[email protected]>Signed-off-by Marcin Szycik <[email protected]>Signed-off-by Michal Swiatkowski <[email protected]>---
v1 --> v2 (based on Olek comments):
* remove zeroes from tabels
* style changes
Quoted 6 lines
--- .../net/ethernet/intel/ice/ice_eswitch_br.c | 6 +- drivers/net/ethernet/intel/ice/ice_lag.c | 87 +++++++++++++++---- drivers/net/ethernet/intel/ice/ice_lag.h | 2 + 3 files changed, 75 insertions(+), 20 deletions(-)
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan