Skip to contentSkip to conversation

xfs: fix select in config XFS_ONLINE_SCRUB_STATS

PATCH In review Lukas Bulwahn 2 participants 2 messages Aug 25, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 xfs: fix select in config XFS_ONLINE_SCRUB_STATS

Commit d7a74cad8f45 ("xfs: track usage statistics of online fsck") introduces config XFS_ONLINE_SCRUB_STATS, which selects the non-existing config FS_DEBUG. It is probably intended to select the existing config XFS_DEBUG.

Fix the select in config XFS_ONLINE_SCRUB_STATS.

Fixes d7a74cad8f45 ("xfs: track usage statistics of online fsck")

---
Darrick, please pick this quick 'typo' fix.

v2: removed a stupid last-minute insert on my Signed-off-by line.

 fs/xfs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/Kconfig +1 -1
index c9d653168ad0..ed0bc8cbc703 100644
@@ -147,7 +147,7 @@ config XFS_ONLINE_SCRUB_STATS
 	bool "XFS online metadata check usage data collection"
 	default y
 	depends on XFS_ONLINE_SCRUB
-	select FS_DEBUG
+	select XFS_DEBUG
 	help
 	  If you say Y here, the kernel will gather usage data about
 	  the online metadata check subsystem.  This includes the number
Signature · 1 line
2.17.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · Lukas Bulwahn

Commit d7a74cad8f45 ("xfs: track usage statistics of online fsck") introduces config XFS_ONLINE_SCRUB_STATS, which selects the non-existing config FS_DEBUG. It is probably intended to select the existing config XFS_DEBUG.

Fix the select in config XFS_ONLINE_SCRUB_STATS.

Fixes d7a74cad8f45 ("xfs: track usage statistics of online fsck")

Oops.

Quoted 2 lines

---
Darrick, please pick this quick 'typo' fix.

^^^^ isn't the maintainer anymore. ;)

--D

Quoted 21 lines

v2: removed a stupid last-minute insert on my Signed-off-by line.

 fs/xfs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/Kconfig +1 -1
index c9d653168ad0..ed0bc8cbc703 100644
@@ -147,7 +147,7 @@ config XFS_ONLINE_SCRUB_STATS
 	bool "XFS online metadata check usage data collection"
 	default y
 	depends on XFS_ONLINE_SCRUB
-	select FS_DEBUG
+	select XFS_DEBUG
 	help
 	  If you say Y here, the kernel will gather usage data about
 	  the online metadata check subsystem.  This includes the number
Signature · 1 line
2.17.1