Skip to contentSkip to conversation

build: add pdcp to optional libs

PATCH Applied Bruce Richardson 3 participants 4 messages Aug 25, 2023 – Aug 29, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: add pdcp to optional libs

The pdcp library is disabled when its dependent library "reorder" is not being built.

../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"

As such, it is not a mandatory library, and can be marked as safe to disable.

---
 lib/meson.build | 1 +
 1 file changed, 1 insertion(+)
lib/meson.build +1 -0
index 53155be8e9..c1602e818a 100644
@@ -96,6 +96,7 @@ optional_libs = [
         'mldev',
         'node',
         'pcapng',
+        'pdcp',
         'pdump',
         'pipeline',
         'port',
Signature · 1 line
2.39.2
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Bruce Richardson

The pdcp library is disabled when its dependent library "reorder" is not being built.

../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"

As such, it is not a mandatory library, and can be marked as safe to disable.

---

Acked-by on v1 1/1
#2 lore raw
In reply to Bruce Richardson
Quoted 11 lines · Bruce Richardson

The pdcp library is disabled when its dependent library "reorder" is not being built.

../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"

As such, it is not a mandatory library, and can be marked as safe to disable.

Signature · 1 line
David Marchand
#3 lore raw
In reply to Bruce Richardson
Quoted 11 lines · Bruce Richardson

The pdcp library is disabled when its dependent library "reorder" is not being built.

../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"

As such, it is not a mandatory library, and can be marked as safe to disable.

Applied, thanks.

Signature · 1 line
David Marchand