mbuf: add ESP packet type
PATCH 1/1 mbuf: add ESP packet type
Support the IP Encapsulating Security Payload (ESP) in transport mode.
--- lib/mbuf/rte_mbuf_ptype.h | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)
lib/mbuf/rte_mbuf_ptype.h +23 -0
@@ -308,6 +308,17 @@ extern "C" {* | 'version'=4, 'protocol'=2, 'MF'=0, 'frag_offset'=0> */ #define RTE_PTYPE_L4_IGMP 0x00000700 +/** +* ESP (IP Encapsulating Security Payload) transport packet type. +* +* Packet format: +* <'ether type'=0x0800 +* | 'version'=4, 'protocol'=50> +* or, +* <'ether type'=0x86DD +* | 'version'=6, 'next header'=50> +*/ +#define RTE_PTYPE_L4_ESP 0x00000800/** * Mask of layer 4 packet types. * It is used for outer packet for tunneling cases.
@@ -658,6 +669,18 @@ extern "C" {* | 'version'=6, 'next header'!=[6|17|44|132|1]> */ #define RTE_PTYPE_INNER_L4_NONFRAG 0x06000000 +/** +* ESP (IP Encapsulating Security Payload) transport packet type. +* It is used for inner packet only. +* +* Packet format (inner only): +* <'ether type'=0x0800 +* | 'version'=4, 'protocol'=50> +* or, +* <'ether type'=0x86DD +* | 'version'=6, 'next header'=50> +*/ +#define RTE_PTYPE_INNER_L4_ESP 0x08000000/** * Mask of inner layer 4 packet types. */
Signature · 1 line
2.18.2
Quoted 15 lines
From: Alexander Kozyrev [mailto:[email protected]]
Sent: Thursday, 10 August 2023 17.54Support the IP Encapsulating Security Payload (ESP) in transport mode.
Signed-off-by Alexander Kozyrev <[email protected]>--- lib/mbuf/rte_mbuf_ptype.h | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)lib/mbuf/rte_mbuf_ptype.h +0
-0
lib/mbuf/rte_mbuf_ptype.h extern "C" { · line 316
Quoted 9 lines
lib/mbuf/rte_mbuf_ptype.h +6
-0@@ -308,6 +308,17 @@ extern "C" {* | 'version'=4, 'protocol'=2, 'MF'=0, 'frag_offset'=0> */ #define RTE_PTYPE_L4_IGMP 0x00000700 +/** +* ESP (IP Encapsulating Security Payload) transport packet type. +* +* Packet format: +* <'ether type'=0x0800 +* | 'version'=4, 'protocol'=50>
Non-fragment criteria seems to be missing:
* | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0>
Quoted 9 lines
lib/mbuf/rte_mbuf_ptype.h +5
-0+* or, +* <'ether type'=0x86DD +* | 'version'=6, 'next header'=50> +*/ +#define RTE_PTYPE_L4_ESP 0x00000800/** * Mask of layer 4 packet types. * It is used for outer packet for tunneling cases.
lib/mbuf/rte_mbuf_ptype.h extern "C" { · line 678
Quoted 10 lines
lib/mbuf/rte_mbuf_ptype.h +7
-0@@ -658,6 +669,18 @@ extern "C" {* | 'version'=6, 'next header'!=[6|17|44|132|1]> */ #define RTE_PTYPE_INNER_L4_NONFRAG 0x06000000 +/** +* ESP (IP Encapsulating Security Payload) transport packet type. +* It is used for inner packet only. +* +* Packet format (inner only): +* <'ether type'=0x0800 +* | 'version'=4, 'protocol'=50>
Also missing here:
* | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0>
Quoted 10 lines
lib/mbuf/rte_mbuf_ptype.h +5
-1+* or, +* <'ether type'=0x86DD +* | 'version'=6, 'next header'=50> +*/ +#define RTE_PTYPE_INNER_L4_ESP 0x08000000/** * Mask of inner layer 4 packet types. */ --2.18.2
Quoted 8 lines
From: Morten Brørup <[email protected]>
Non-fragment criteria seems to be missing:* | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0>
Also missing here:
* | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0>
You are right, thank you, sending v2 with updated description.
PATCH v2 1/1 mbuf: add ESP packet type
In reply to Alexander KozyrevSupport the IP Encapsulating Security Payload (ESP) in transport mode.
--- lib/mbuf/rte_mbuf_ptype.h | 31 +++++++++++++++++++++++++++---- 1 file changed, 27 insertions(+), 4 deletions(-)
lib/mbuf/rte_mbuf_ptype.h +27 -4
@@ -294,10 +294,10 @@ extern "C" {* * Packet format: * <'ether type'=0x0800 -* | 'version'=4, 'protocol'!=[6|17|132|1], 'MF'=0, 'frag_offset'=0> +* | 'version'=4, 'protocol'!=[6|17|132|1|50], 'MF'=0, 'frag_offset'=0> * or, * <'ether type'=0x86DD -* | 'version'=6, 'next header'!=[6|17|44|132|1]> +* | 'version'=6, 'next header'!=[6|17|44|132|1|50]> */ #define RTE_PTYPE_L4_NONFRAG 0x00000600/**
@@ -308,6 +308,17 @@ extern "C" {* | 'version'=4, 'protocol'=2, 'MF'=0, 'frag_offset'=0> */ #define RTE_PTYPE_L4_IGMP 0x00000700 +/** +* ESP (IP Encapsulating Security Payload) transport packet type. +* +* Packet format: +* <'ether type'=0x0800 +* | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0> +* or, +* <'ether type'=0x86DD +* | 'version'=6, 'next header'=50> +*/ +#define RTE_PTYPE_L4_ESP 0x00000800/** * Mask of layer 4 packet types. * It is used for outer packet for tunneling cases.
@@ -652,12 +663,24 @@ extern "C" {* * Packet format (inner only): * <'ether type'=0x0800 -* | 'version'=4, 'protocol'!=[6|17|132|1], 'MF'=0, 'frag_offset'=0> +* | 'version'=4, 'protocol'!=[6|17|132|1|50], 'MF'=0, 'frag_offset'=0> * or, * <'ether type'=0x86DD -* | 'version'=6, 'next header'!=[6|17|44|132|1]> +* | 'version'=6, 'next header'!=[6|17|44|132|1|50]> */ #define RTE_PTYPE_INNER_L4_NONFRAG 0x06000000 +/** +* ESP (IP Encapsulating Security Payload) transport packet type. +* It is used for inner packet only. +* +* Packet format (inner only): +* <'ether type'=0x0800 +* | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0> +* or, +* <'ether type'=0x86DD +* | 'version'=6, 'next header'=50> +*/ +#define RTE_PTYPE_INNER_L4_ESP 0x08000000/** * Mask of inner layer 4 packet types. */
Signature · 1 line
2.18.2
lib/mbuf/rte_mbuf_ptype.h extern "C" {
Quoted 15 lines
From: Alexander Kozyrev [mailto:[email protected]]
Sent: Saturday, 26 August 2023 01.34Support the IP Encapsulating Security Payload (ESP) in transport mode.
Signed-off-by Alexander Kozyrev <[email protected]>--- lib/mbuf/rte_mbuf_ptype.h | 31 +++++++++++++++++++++++++++---- 1 file changed, 27 insertions(+), 4 deletions(-)lib/mbuf/rte_mbuf_ptype.h +0
-0@@ -294,10 +294,10 @@ extern "C" {
Please also update the comment accordingly. E.g.:
* It refers to those packets of any IP types, while cannot be recognized as
* any of above L4 types (RTE_PTYPE_L4_ICMP, RTE_PTYPE_L4_TCP,
* RTE_PTYPE_L4_UDP, RTE_PTYPE_L4_FRAG (for IPv6), RTE_PTYPE_L4_ESP,
* RTE_PTYPE_L4_SCTP).
Please note that I took the liberty to reorder the protocols in numerical order, and add that RTE_PTYPE_L4_FRAG only applies to IPv6. At your preference, feel free to keep the original ordering and add RTE_PTYPE_L4_ESP at the end, or use my suggested changes.
lib/mbuf/rte_mbuf_ptype.h extern "C" { · line 297
Quoted 5 lines
lib/mbuf/rte_mbuf_ptype.h +1
-1* * Packet format: * <'ether type'=0x0800 -* | 'version'=4, 'protocol'!=[6|17|132|1], 'MF'=0, 'frag_offset'=0> +* | 'version'=4, 'protocol'!=[6|17|132|1|50], 'MF'=0, 'frag_offset'=0>
I notice that ICMP(1) is already last in the list, but this list is more readable with the protocols enumerated in numerical order:
* | 'version'=4, 'protocol'!=[1|6|17|50|132], 'MF'=0, 'frag_offset'=0>
lib/mbuf/rte_mbuf_ptype.h extern "C" { · line 300
Quoted 4 lines
lib/mbuf/rte_mbuf_ptype.h +1
-1* or, * <'ether type'=0x86DD -* | 'version'=6, 'next header'!=[6|17|44|132|1]> +* | 'version'=6, 'next header'!=[6|17|44|132|1|50]>
Same comment about numerical order here:
* | 'version'=6, 'next header'!=[1|6|17|44|50|132]>
Quoted 49 lines
lib/mbuf/rte_mbuf_ptype.h +25
-3*/ #define RTE_PTYPE_L4_NONFRAG 0x00000600/** @@ -308,6 +308,17 @@ extern "C" {* | 'version'=4, 'protocol'=2, 'MF'=0, 'frag_offset'=0> */ #define RTE_PTYPE_L4_IGMP 0x00000700 +/** +* ESP (IP Encapsulating Security Payload) transport packet type. +* +* Packet format: +* <'ether type'=0x0800 +* | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0> +* or, +* <'ether type'=0x86DD +* | 'version'=6, 'next header'=50> +*/ +#define RTE_PTYPE_L4_ESP 0x00000800/** * Mask of layer 4 packet types. * It is used for outer packet for tunneling cases. @@ -652,12 +663,24 @@ extern "C" {* * Packet format (inner only): * <'ether type'=0x0800 -* | 'version'=4, 'protocol'!=[6|17|132|1], 'MF'=0, 'frag_offset'=0> +* | 'version'=4, 'protocol'!=[6|17|132|1|50], 'MF'=0, 'frag_offset'=0> * or, * <'ether type'=0x86DD -* | 'version'=6, 'next header'!=[6|17|44|132|1]> +* | 'version'=6, 'next header'!=[6|17|44|132|1|50]> */ #define RTE_PTYPE_INNER_L4_NONFRAG 0x06000000 +/** +* ESP (IP Encapsulating Security Payload) transport packet type. +* It is used for inner packet only. +* +* Packet format (inner only): +* <'ether type'=0x0800 +* | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0> +* or, +* <'ether type'=0x86DD +* | 'version'=6, 'next header'=50> +*/ +#define RTE_PTYPE_INNER_L4_ESP 0x08000000/** * Mask of inner layer 4 packet types. */ --
Quoted 1 line
2.18.2
For v3, you can add:
PATCH v3 1/1 mbuf: add ESP packet type
In reply to Alexander KozyrevSupport the IP Encapsulating Security Payload (ESP) in transport mode.
--- lib/mbuf/rte_mbuf_ptype.h | 36 ++++++++++++++++++++++++++++++------ 1 file changed, 30 insertions(+), 6 deletions(-)
lib/mbuf/rte_mbuf_ptype.h +30 -6
@@ -247,7 +247,7 @@ extern "C" {* It refers to those packets of any IP types, which can be recognized as * fragmented. A fragmented packet cannot be recognized as any other L4 types * (RTE_PTYPE_L4_TCP, RTE_PTYPE_L4_UDP, RTE_PTYPE_L4_SCTP, RTE_PTYPE_L4_ICMP, -* RTE_PTYPE_L4_NONFRAG). +* RTE_PTYPE_L4_NONFRAG, RTE_PTYPE_L4_IGMP, RTE_PTYPE_L4_ESP). * * Packet format: * <'ether type'=0x0800
@@ -290,14 +290,15 @@ extern "C" {* * It refers to those packets of any IP types, while cannot be recognized as * any of above L4 types (RTE_PTYPE_L4_TCP, RTE_PTYPE_L4_UDP, -* RTE_PTYPE_L4_FRAG, RTE_PTYPE_L4_SCTP, RTE_PTYPE_L4_ICMP). +* RTE_PTYPE_L4_FRAG (for IPv6), RTE_PTYPE_L4_SCTP, RTE_PTYPE_L4_ICMP, +* RTE_PTYPE_L4_IGMP (for IPv4), RTE_PTYPE_L4_ESP). * * Packet format: * <'ether type'=0x0800 -* | 'version'=4, 'protocol'!=[6|17|132|1], 'MF'=0, 'frag_offset'=0> +* | 'version'=4, 'protocol'!=[1|2|6|17|50|132], 'MF'=0, 'frag_offset'=0> * or, * <'ether type'=0x86DD -* | 'version'=6, 'next header'!=[6|17|44|132|1]> +* | 'version'=6, 'next header'!=[1|6|17|44|50|132]> */ #define RTE_PTYPE_L4_NONFRAG 0x00000600/**
@@ -308,6 +309,17 @@ extern "C" {* | 'version'=4, 'protocol'=2, 'MF'=0, 'frag_offset'=0> */ #define RTE_PTYPE_L4_IGMP 0x00000700 +/** +* ESP (IP Encapsulating Security Payload) transport packet type. +* +* Packet format: +* <'ether type'=0x0800 +* | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0> +* or, +* <'ether type'=0x86DD +* | 'version'=6, 'next header'=50> +*/ +#define RTE_PTYPE_L4_ESP 0x00000800/** * Mask of layer 4 packet types. * It is used for outer packet for tunneling cases.
@@ -652,12 +664,24 @@ extern "C" {* * Packet format (inner only): * <'ether type'=0x0800 -* | 'version'=4, 'protocol'!=[6|17|132|1], 'MF'=0, 'frag_offset'=0> +* | 'version'=4, 'protocol'!=[1|6|17|50|132], 'MF'=0, 'frag_offset'=0> * or, * <'ether type'=0x86DD -* | 'version'=6, 'next header'!=[6|17|44|132|1]> +* | 'version'=6, 'next header'!=[1|6|17|44|50|132]> */ #define RTE_PTYPE_INNER_L4_NONFRAG 0x06000000 +/** +* ESP (IP Encapsulating Security Payload) transport packet type. +* It is used for inner packet only. +* +* Packet format (inner only): +* <'ether type'=0x0800 +* | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0> +* or, +* <'ether type'=0x86DD +* | 'version'=6, 'next header'=50> +*/ +#define RTE_PTYPE_INNER_L4_ESP 0x08000000/** * Mask of inner layer 4 packet types. */
Signature · 1 line
2.18.2
Quoted 94 lines
-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Monday, August 28, 2023 9:23 PMSupport the IP Encapsulating Security Payload (ESP) in transport mode.
Signed-off-by Alexander Kozyrev <[email protected]>Acked-by Morten Brørup <[email protected]>--- lib/mbuf/rte_mbuf_ptype.h | 36 ++++++++++++++++++++++++++++++------ 1 file changed, 30 insertions(+), 6 deletions(-)lib/mbuf/rte_mbuf_ptype.h +0
-0@@ -247,7 +247,7 @@ extern "C" {* It refers to those packets of any IP types, which can be recognized as * fragmented. A fragmented packet cannot be recognized as any other L4 types
* (RTE_PTYPE_L4_TCP,RTE_PTYPE_L4_UDP,RTE_PTYPE_L4_SCTP,RTE_PTYPE_L4_ICMP,
- *RTE_PTYPE_L4_NONFRAG).
+ *RTE_PTYPE_L4_NONFRAG,RTE_PTYPE_L4_IGMP,RTE_PTYPE_L4_ESP). *
* Packet format:
* <'ether type'=0x0800lib/mbuf/rte_mbuf_ptype.h +29
-6@@ -290,14 +290,15 @@ extern "C" {* * It refers to those packets of any IP types, while cannot be recognized as * any of above L4 types (RTE_PTYPE_L4_TCP, RTE_PTYPE_L4_UDP, -* RTE_PTYPE_L4_FRAG, RTE_PTYPE_L4_SCTP, RTE_PTYPE_L4_ICMP). +* RTE_PTYPE_L4_FRAG (for IPv6), RTE_PTYPE_L4_SCTP, RTE_PTYPE_L4_ICMP, +* RTE_PTYPE_L4_IGMP (for IPv4), RTE_PTYPE_L4_ESP). * * Packet format: * <'ether type'=0x0800 -* | 'version'=4, 'protocol'!=[6|17|132|1], 'MF'=0, 'frag_offset'=0> +* | 'version'=4, 'protocol'!=[1|2|6|17|50|132], 'MF'=0, 'frag_offset'=0> * or, * <'ether type'=0x86DD -* | 'version'=6, 'next header'!=[6|17|44|132|1]> +* | 'version'=6, 'next header'!=[1|6|17|44|50|132]> */ #define RTE_PTYPE_L4_NONFRAG 0x00000600/** @@ -308,6 +309,17 @@ extern "C" {* | 'version'=4, 'protocol'=2, 'MF'=0, 'frag_offset'=0> */ #define RTE_PTYPE_L4_IGMP 0x00000700 +/** +* ESP (IP Encapsulating Security Payload) transport packet type. +* +* Packet format: +* <'ether type'=0x0800 +* | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0> +* or, +* <'ether type'=0x86DD +* | 'version'=6, 'next header'=50> +*/ +#define RTE_PTYPE_L4_ESP 0x00000800/** * Mask of layer 4 packet types. * It is used for outer packet for tunneling cases. @@ -652,12 +664,24 @@ extern "C" {* * Packet format (inner only): * <'ether type'=0x0800 -* | 'version'=4, 'protocol'!=[6|17|132|1], 'MF'=0, 'frag_offset'=0> +* | 'version'=4, 'protocol'!=[1|6|17|50|132], 'MF'=0, 'frag_offset'=0> * or, * <'ether type'=0x86DD -* | 'version'=6, 'next header'!=[6|17|44|132|1]> +* | 'version'=6, 'next header'!=[1|6|17|44|50|132]> */ #define RTE_PTYPE_INNER_L4_NONFRAG 0x06000000 +/** +* ESP (IP Encapsulating Security Payload) transport packet type. +* It is used for inner packet only. +* +* Packet format (inner only): +* <'ether type'=0x0800 +* | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0> +* or, +* <'ether type'=0x86DD +* | 'version'=6, 'next header'=50> +*/ +#define RTE_PTYPE_INNER_L4_ESP 0x08000000/** * Mask of inner layer 4 packet types. */ --
Quoted 1 line
2.18.2
Best,
Ori
Quoted 2 lines · Alexander Kozyrev
Support the IP Encapsulating Security Payload (ESP) in transport mode.
As per IPSEC ESP RFC 4303, for both tunnel mode or transport mode, next proto 50, so we cannot identify a packet is for tunnel mode or transport mode by just packet parsing.
Am I missing something ?
Quoted 44 lines
Signed-off-by Alexander Kozyrev <[email protected]>Acked-by Morten Brørup <[email protected]>--- lib/mbuf/rte_mbuf_ptype.h | 36 ++++++++++++++++++++++++++++++------ 1 file changed, 30 insertions(+), 6 deletions(-)lib/mbuf/rte_mbuf_ptype.h +6
-4@@ -247,7 +247,7 @@ extern "C" {* It refers to those packets of any IP types, which can be recognized as * fragmented. A fragmented packet cannot be recognized as any other L4 types * (RTE_PTYPE_L4_TCP, RTE_PTYPE_L4_UDP, RTE_PTYPE_L4_SCTP, RTE_PTYPE_L4_ICMP, -* RTE_PTYPE_L4_NONFRAG). +* RTE_PTYPE_L4_NONFRAG, RTE_PTYPE_L4_IGMP, RTE_PTYPE_L4_ESP). * * Packet format: * <'ether type'=0x0800 @@ -290,14 +290,15 @@ extern "C" {* * It refers to those packets of any IP types, while cannot be recognized as * any of above L4 types (RTE_PTYPE_L4_TCP, RTE_PTYPE_L4_UDP, -* RTE_PTYPE_L4_FRAG, RTE_PTYPE_L4_SCTP, RTE_PTYPE_L4_ICMP). +* RTE_PTYPE_L4_FRAG (for IPv6), RTE_PTYPE_L4_SCTP, RTE_PTYPE_L4_ICMP, +* RTE_PTYPE_L4_IGMP (for IPv4), RTE_PTYPE_L4_ESP). * * Packet format: * <'ether type'=0x0800 -* | 'version'=4, 'protocol'!=[6|17|132|1], 'MF'=0, 'frag_offset'=0> +* | 'version'=4, 'protocol'!=[1|2|6|17|50|132], 'MF'=0, 'frag_offset'=0> * or, * <'ether type'=0x86DD -* | 'version'=6, 'next header'!=[6|17|44|132|1]> +* | 'version'=6, 'next header'!=[1|6|17|44|50|132]> */ #define RTE_PTYPE_L4_NONFRAG 0x00000600/** @@ -308,6 +309,17 @@ extern "C" {* | 'version'=4, 'protocol'=2, 'MF'=0, 'frag_offset'=0> */ #define RTE_PTYPE_L4_IGMP 0x00000700 +/**
lib/mbuf/rte_mbuf_ptype.h extern "C" { · line 322
Quoted 10 lines
lib/mbuf/rte_mbuf_ptype.h +10
-0+* ESP (IP Encapsulating Security Payload) transport packet type. +* +* Packet format: +* <'ether type'=0x0800 +* | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0> +* or, +* <'ether type'=0x86DD +* | 'version'=6, 'next header'=50> +*/ +#define RTE_PTYPE_L4_ESP 0x00000800
Currently there is already a PTYPE RTE_PTYPE_TUNNEL_ESP being used by all drivers / ipsec-secgw to indicate ESP packet. So why is this needed ?
There is also a documentation issue with RTE_PTYPE_TUNNEL_ESP where it indicates next-proto of 51 but it should have been 50. next-proto of 51 is for IPSEC AH.
Quoted 33 lines
lib/mbuf/rte_mbuf_ptype.h +14
-3/** * Mask of layer 4 packet types. * It is used for outer packet for tunneling cases. @@ -652,12 +664,24 @@ extern "C" {* * Packet format (inner only): * <'ether type'=0x0800 -* | 'version'=4, 'protocol'!=[6|17|132|1], 'MF'=0, 'frag_offset'=0> +* | 'version'=4, 'protocol'!=[1|6|17|50|132], 'MF'=0, 'frag_offset'=0> * or, * <'ether type'=0x86DD -* | 'version'=6, 'next header'!=[6|17|44|132|1]> +* | 'version'=6, 'next header'!=[1|6|17|44|50|132]> */ #define RTE_PTYPE_INNER_L4_NONFRAG 0x06000000 +/** +* ESP (IP Encapsulating Security Payload) transport packet type. +* It is used for inner packet only. +* +* Packet format (inner only): +* <'ether type'=0x0800 +* | 'version'=4, 'protocol'=50, 'MF'=0, 'frag_offset'=0> +* or, +* <'ether type'=0x86DD +* | 'version'=6, 'next header'=50> +*/ +#define RTE_PTYPE_INNER_L4_ESP 0x08000000/** * Mask of inner layer 4 packet types. */ --2.18.2
Quoted 4 lines
As per IPSEC ESP RFC 4303, for both tunnel mode or transport mode, next proto 50, so we cannot identify a packet is for tunnel mode or transport mode by just packet parsing.
Am I missing something ?
You are absolutely correct, the only way to tell the difference is
to parse the next_proto field in the ESP header itself.
But this field is encrypted, according to RFC, and not really available for parsing.
Quoted 3 lines
Currently there is already a PTYPE
RTE_PTYPE_TUNNEL_ESPbeing used by all drivers / ipsec-secgw to indicate ESP packet. So why is this needed ?
The idea was to add the possibility to distinguish packets in these two modes. But you are right, it doesn't seem achievable without decrypting the packet first.
Quoted 3 lines
There is also a documentation issue with
RTE_PTYPE_TUNNEL_ESPwhere it indicates next-proto of 51 but it should have been 50. next-proto of 51 is for IPSEC AH.
Yes, documentation is incorrect there.
Thanks for bringing this up, Nithin, I think we can live with RTE_PTYPE_TUNNEL_ESP.
v3 cover ptype matching support in mlx5
In reply to Alexander KozyrevAdd support for RTE_FLOW_ITEM_TYPE_PTYPE in mlx5 PMD.
Alexander Kozyrev (5):
ethdev: fix ESP packet type description net/mlx5: add support for ptype match in hardware steering net/mlx5/hws: add support for fragmented ptype match
doc: add packet type matching item to release notes net/mlx5/hws: fix integrity bits level
Michael Baum (2):
doc: add PMD ptype item limitations net/mlx5/hws: remove csum check from L3 ok check
doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 26 +++- doc/guides/rel_notes/release_23_11.rst | 4 + drivers/net/mlx5/hws/mlx5dr_definer.c | 207 ++++++++++++++++++++++++- drivers/net/mlx5/hws/mlx5dr_definer.h | 9 ++ drivers/net/mlx5/mlx5_flow.h | 3 + drivers/net/mlx5/mlx5_flow_hw.c | 1 + lib/mbuf/rte_mbuf_ptype.h | 4 +- 8 files changed, 242 insertions(+), 13 deletions(-)
Signature · 1 line
2.18.2
PATCH v3 1/7 ethdev: fix ESP packet type description
The correct protocol number for ESP (IP Encapsulating Security Payload) packet type is 50. 51 is IPSec AH (Authentication Header).
--- lib/mbuf/rte_mbuf_ptype.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/mbuf/rte_mbuf_ptype.h +2 -2
@@ -419,10 +419,10 @@ extern "C" {* * Packet format: * <'ether type'=0x0800 -* | 'version'=4, 'protocol'=51> +* | 'version'=4, 'protocol'=50> * or, * <'ether type'=0x86DD -* | 'version'=6, 'next header'=51> +* | 'version'=6, 'next header'=50> */ #define RTE_PTYPE_TUNNEL_ESP 0x00009000/**
Signature · 1 line
2.18.2
PATCH v3 2/7 net/mlx5: add support for ptype match in hardware steering
In reply to Alexander KozyrevThe packet type matching provides quick way of finding out L2/L3/L4 protocols in a given packet. That helps with optimized flow rules matching, eliminating the need of stacking all the packet headers in the matching criteria.
--- drivers/net/mlx5/hws/mlx5dr_definer.c | 161 ++++++++++++++++++++++++++ drivers/net/mlx5/hws/mlx5dr_definer.h | 7 ++ drivers/net/mlx5/mlx5_flow.h | 3 + drivers/net/mlx5/mlx5_flow_hw.c | 1 + 4 files changed, 172 insertions(+)
drivers/net/mlx5/hws/mlx5dr_definer.c +161 -0
@@ -16,11 +16,15 @@#define STE_NO_VLAN 0x0#define STE_SVLAN 0x1#define STE_CVLAN 0x2 +#define STE_NO_L3 0x0#define STE_IPV4 0x1#define STE_IPV6 0x2 +#define STE_NO_L4 0x0#define STE_TCP 0x1#define STE_UDP 0x2#define STE_ICMP 0x3 +#define STE_NO_TUN 0x0 +#define STE_ESP 0x3#define MLX5DR_DEFINER_QUOTA_BLOCK 0#define MLX5DR_DEFINER_QUOTA_PASS 2
@@ -277,6 +281,82 @@ mlx5dr_definer_conntrack_tag(struct mlx5dr_definer_fc *fc,DR_SET (tag, reg_value, fc->byte_off, fc->bit_off, fc->bit_mask); } +static void +mlx5dr_definer_ptype_l2_set (struct mlx5dr_definer_fc *fc, +const void *item_spec, +uint8_t *tag) +{ +bool inner = (fc->fname ==MLX5DR_DEFINER_FNAME_PTYPE_L2_I ); +const struct rte_flow_item_ptype *v = item_spec; +uint32_t packet_type = v->packet_type & + (inner ?RTE_PTYPE_INNER_L2_MASK :RTE_PTYPE_L2_MASK ); +uint8_t l2_type =STE_NO_VLAN ; + +if (packet_type == (inner ?RTE_PTYPE_INNER_L2_ETHER :RTE_PTYPE_L2_ETHER )) + l2_type =STE_NO_VLAN ; +else if (packet_type == (inner ?RTE_PTYPE_INNER_L2_ETHER_VLAN :RTE_PTYPE_L2_ETHER_VLAN )) + l2_type =STE_CVLAN ; +else if (packet_type == (inner ?RTE_PTYPE_INNER_L2_ETHER_QINQ :RTE_PTYPE_L2_ETHER_QINQ )) + l2_type =STE_SVLAN ; + +DR_SET (tag, l2_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + +static void +mlx5dr_definer_ptype_l3_set (struct mlx5dr_definer_fc *fc, +const void *item_spec, +uint8_t *tag) +{ +bool inner = (fc->fname ==MLX5DR_DEFINER_FNAME_PTYPE_L3_I ); +const struct rte_flow_item_ptype *v = item_spec; +uint32_t packet_type = v->packet_type & + (inner ?RTE_PTYPE_INNER_L3_MASK :RTE_PTYPE_L3_MASK ); +uint8_t l3_type =STE_NO_L3 ; + +if (packet_type == (inner ?RTE_PTYPE_INNER_L3_IPV4 :RTE_PTYPE_L3_IPV4 )) + l3_type =STE_IPV4 ; +else if (packet_type == (inner ?RTE_PTYPE_INNER_L3_IPV6 :RTE_PTYPE_L3_IPV6 )) + l3_type =STE_IPV6 ; + +DR_SET (tag, l3_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + +static void +mlx5dr_definer_ptype_l4_set (struct mlx5dr_definer_fc *fc, +const void *item_spec, +uint8_t *tag) +{ +bool inner = (fc->fname ==MLX5DR_DEFINER_FNAME_PTYPE_L4_I ); +const struct rte_flow_item_ptype *v = item_spec; +uint32_t packet_type = v->packet_type & + (inner ?RTE_PTYPE_INNER_L4_MASK :RTE_PTYPE_L4_MASK ); +uint8_t l4_type =STE_NO_L4 ; + +if (packet_type == (inner ?RTE_PTYPE_INNER_L4_TCP :RTE_PTYPE_L4_TCP )) + l4_type =STE_TCP ; +else if (packet_type == (inner ?RTE_PTYPE_INNER_L4_UDP :RTE_PTYPE_L4_UDP )) + l4_type =STE_UDP ; +else if (packet_type == (inner ?RTE_PTYPE_INNER_L4_ICMP :RTE_PTYPE_L4_ICMP )) + l4_type =STE_ICMP ; + +DR_SET (tag, l4_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + +static void +mlx5dr_definer_ptype_tunnel_set (struct mlx5dr_definer_fc *fc, +const void *item_spec, +uint8_t *tag) +{ +const struct rte_flow_item_ptype *v = item_spec; +uint32_t packet_type = v->packet_type &RTE_PTYPE_TUNNEL_MASK ; +uint8_t tun_type =STE_NO_TUN ; + +if (packet_type ==RTE_PTYPE_TUNNEL_ESP ) + tun_type =STE_ESP ; + +DR_SET (tag, tun_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + static void mlx5dr_definer_integrity_set(struct mlx5dr_definer_fc *fc, const void *item_spec,
@@ -1709,6 +1789,83 @@ mlx5dr_definer_conv_item_gre_key(struct mlx5dr_definer_conv_data *cd,return 0 ; } +static int +mlx5dr_definer_conv_item_ptype (struct mlx5dr_definer_conv_data *cd, +struct rte_flow_item *item, +int item_idx) +{ +const struct rte_flow_item_ptype *m = item->mask; +struct mlx5dr_definer_fc *fc; + +if (!m) +return 0 ; + +if (!(m->packet_type & + (RTE_PTYPE_L2_MASK |RTE_PTYPE_L3_MASK |RTE_PTYPE_L4_MASK |RTE_PTYPE_TUNNEL_MASK | +RTE_PTYPE_INNER_L2_MASK |RTE_PTYPE_INNER_L3_MASK |RTE_PTYPE_INNER_L4_MASK ))) { + rte_errno =ENOTSUP ; +return rte_errno; + } + +if (m->packet_type &RTE_PTYPE_L2_MASK ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L2 , false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l2_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, first_vlan_qualifier, false); + } + +if (m->packet_type &RTE_PTYPE_INNER_L2_MASK ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L2 , true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l2_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, first_vlan_qualifier, true); + } + +if (m->packet_type &RTE_PTYPE_L3_MASK ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L3 , false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l3_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, l3_type, false); + } + +if (m->packet_type &RTE_PTYPE_INNER_L3_MASK ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L3 , true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l3_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, l3_type, true); + } + +if (m->packet_type &RTE_PTYPE_L4_MASK ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L4 , false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l4_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, l4_type, false); + } + +if (m->packet_type &RTE_PTYPE_INNER_L4_MASK ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L4 , true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l4_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, l4_type, true); + } + +if (m->packet_type &RTE_PTYPE_TUNNEL_MASK ) { + fc = &cd->fc[MLX5DR_DEFINER_FNAME_PTYPE_TUNNEL ]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_tunnel_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, l4_type_bwc, false); + } + +return 0 ; +} + static int mlx5dr_definer_conv_item_integrity(struct mlx5dr_definer_conv_data *cd, struct rte_flow_item *item,
@@ -2332,6 +2489,10 @@ mlx5dr_definer_conv_items_to_hl(struct mlx5dr_context *ctx, ret =mlx5dr_definer_conv_item_ib_l4 (&cd, items, i); item_flags |=MLX5_FLOW_ITEM_IB_BTH ;break ; +case RTE_FLOW_ITEM_TYPE_PTYPE : + ret =mlx5dr_definer_conv_item_ptype (&cd, items, i); + item_flags |=MLX5_FLOW_ITEM_PTYPE ; +break ;default :DR_LOG (ERR ,"Unsupported item type %d" , items->type); rte_errno =ENOTSUP ;
drivers/net/mlx5/hws/mlx5dr_definer.h +7 -0
@@ -141,6 +141,13 @@ enum mlx5dr_definer_fname {MLX5DR_DEFINER_FNAME_IB_L4_OPCODE ,MLX5DR_DEFINER_FNAME_IB_L4_QPN ,MLX5DR_DEFINER_FNAME_IB_L4_A , +MLX5DR_DEFINER_FNAME_PTYPE_L2_O , +MLX5DR_DEFINER_FNAME_PTYPE_L2_I , +MLX5DR_DEFINER_FNAME_PTYPE_L3_O , +MLX5DR_DEFINER_FNAME_PTYPE_L3_I , +MLX5DR_DEFINER_FNAME_PTYPE_L4_O , +MLX5DR_DEFINER_FNAME_PTYPE_L4_I , +MLX5DR_DEFINER_FNAME_PTYPE_TUNNEL , MLX5DR_DEFINER_FNAME_MAX, };
drivers/net/mlx5/mlx5_flow.h +3 -0
@@ -233,6 +233,9 @@ enum mlx5_feature_name {/* IB BTH ITEM. */ #define MLX5_FLOW_ITEM_IB_BTH (1ull << 51) +/* PTYPE ITEM */ +#define MLX5_FLOW_ITEM_PTYPE (1ull << 52) +/* NSH ITEM */ #define MLX5_FLOW_ITEM_NSH (1ull << 53)
drivers/net/mlx5/mlx5_flow_hw.c +1 -0
@@ -5382,6 +5382,7 @@ flow_hw_pattern_validate(struct rte_eth_dev *dev,case RTE_FLOW_ITEM_TYPE_ESP :case RTE_FLOW_ITEM_TYPE_FLEX :case RTE_FLOW_ITEM_TYPE_IB_BTH : +case RTE_FLOW_ITEM_TYPE_PTYPE :break ;case RTE_FLOW_ITEM_TYPE_INTEGRITY :/*
Signature · 1 line
2.18.2
PATCH v3 3/7 net/mlx5/hws: add support for fragmented ptype match
In reply to Alexander KozyrevExpand packet type matching with support of the
Fragmented IP (Internet Protocol) packet type.
--- drivers/net/mlx5/hws/mlx5dr_definer.c | 54 ++++++++++++++++++++++----- drivers/net/mlx5/hws/mlx5dr_definer.h | 2 + 2 files changed, 46 insertions(+), 10 deletions(-)
drivers/net/mlx5/hws/mlx5dr_definer.c +44 -10
@@ -357,6 +357,19 @@ mlx5dr_definer_ptype_tunnel_set(struct mlx5dr_definer_fc *fc,DR_SET (tag, tun_type, fc->byte_off, fc->bit_off, fc->bit_mask); } +static void +mlx5dr_definer_ptype_frag_set (struct mlx5dr_definer_fc *fc, +const void *item_spec, +uint8_t *tag) +{ +bool inner = (fc->fname ==MLX5DR_DEFINER_FNAME_PTYPE_FRAG_I ); +const struct rte_flow_item_ptype *v = item_spec; +uint32_t packet_type = v->packet_type & + (inner ?RTE_PTYPE_INNER_L4_FRAG :RTE_PTYPE_L4_FRAG ); + +DR_SET (tag, !!packet_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + static void mlx5dr_definer_integrity_set(struct mlx5dr_definer_fc *fc, const void *item_spec,
@@ -1840,19 +1853,40 @@ mlx5dr_definer_conv_item_ptype(struct mlx5dr_definer_conv_data *cd, }if (m->packet_type &RTE_PTYPE_L4_MASK ) { - fc = &cd->fc[DR_CALC_FNAME (PTYPE_L4 , false)]; - fc->item_idx = item_idx; - fc->tag_set = &mlx5dr_definer_ptype_l4_set; - fc->tag_mask_set = &mlx5dr_definer_ones_set; -DR_CALC_SET (fc, eth_l2, l4_type, false); +/* +* Fragmented IP (Internet Protocol) packet type. +* Cannot be combined with Layer 4 Types (TCP/UDP). +* The exact value must be specified in the mask. +*/ +if (m->packet_type ==RTE_PTYPE_L4_FRAG ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_FRAG , false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_frag_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, ip_fragmented, false); + }else { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L4 , false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l4_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, l4_type, false); + } }if (m->packet_type &RTE_PTYPE_INNER_L4_MASK ) { - fc = &cd->fc[DR_CALC_FNAME (PTYPE_L4 , true)]; - fc->item_idx = item_idx; - fc->tag_set = &mlx5dr_definer_ptype_l4_set; - fc->tag_mask_set = &mlx5dr_definer_ones_set; -DR_CALC_SET (fc, eth_l2, l4_type, true); +if (m->packet_type ==RTE_PTYPE_INNER_L4_FRAG ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_FRAG , true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_frag_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, ip_fragmented, true); + }else { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L4 , true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l4_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, l4_type, true); + } }if (m->packet_type &RTE_PTYPE_TUNNEL_MASK ) {
drivers/net/mlx5/hws/mlx5dr_definer.h +2 -0
@@ -148,6 +148,8 @@ enum mlx5dr_definer_fname {MLX5DR_DEFINER_FNAME_PTYPE_L4_O ,MLX5DR_DEFINER_FNAME_PTYPE_L4_I ,MLX5DR_DEFINER_FNAME_PTYPE_TUNNEL , +MLX5DR_DEFINER_FNAME_PTYPE_FRAG_O , +MLX5DR_DEFINER_FNAME_PTYPE_FRAG_I , MLX5DR_DEFINER_FNAME_MAX, };
Signature · 1 line
2.18.2
PATCH v3 4/7 doc: add PMD ptype item limitations
In reply to Alexander KozyrevFrom: Michael Baum <[email protected]>
Add limitations for ptype item support in "mlx5.rst" file.
--- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 15 +++++++++++++++ 2 files changed, 16 insertions(+)
doc/guides/nics/features/mlx5.ini +1 -0
@@ -86,6 +86,7 @@ nsh = Y nvgre = Y port_id = Y port_representor = Y +ptype = Y quota = Y tag = Y tcp = Y
doc/guides/nics/mlx5.rst +15 -0
@@ -646,6 +646,21 @@ Limitations - When using HWS flow engine (``dv_flow_en`` = 2), only meter mark action is supported. +- Ptype: + + - Only supports HW steering (``dv_flow_en=2``). + - The supported values are: + L2: ``RTE_PTYPE_L2_ETHER``, ``RTE_PTYPE_L2_ETHER_VLAN``, ``RTE_PTYPE_L2_ETHER_QINQ`` + L3: ``RTE_PTYPE_L3_IPV4``, ``RTE_PTYPE_L3_IPV6`` + L4: ``RTE_PTYPE_L4_TCP``, ``RTE_PTYPE_L4_UDP``, ``RTE_PTYPE_L4_ICMP`` + and their ``RTE_PTYPE_INNER_XXX`` counterparts as well as ``RTE_PTYPE_TUNNEL_ESP``. + Any other values are not supported. Using them as a value will cause unexpected behavior. + - Matching on both outer and inner IP fragmented is supported using ``RTE_PTYPE_L4_FRAG`` and + ``RTE_PTYPE_INNER_L4_FRAG`` values. They are not part of L4 types, so they should be provided + explicitly as a mask value during pattern template creation. Providing ``RTE_PTYPE_L4_MASK`` + during pattern template creation and ``RTE_PTYPE_L4_FRAG`` during flow rule creation + will cause unexpected behavior. + - Integrity: - Integrity offload is enabled starting from **ConnectX-6 Dx**.
Signature · 1 line
2.18.2
PATCH v3 5/7 doc: add packet type matching item to release notes
In reply to Alexander KozyrevDocument new RTE_FLOW_ITEM_TYPE_PTYPE in the release notes.
--- doc/guides/rel_notes/release_23_11.rst | 4 ++++ 1 file changed, 4 insertions(+)
doc/guides/rel_notes/release_23_11.rst +4 -0
@@ -122,6 +122,10 @@ New Features a group's miss actions, which are the actions to be performed on packets that didn't match any of the flow rules in the group. +* **Added ptype matching criteria.** + Added ``RTE_FLOW_ITEM_TYPE_PTYPE`` to allow matching on L2/L3/L4 + and tunnel information as defined in mbuf packet type. + * **Updated Intel cpfl driver.** * Added support for port representor.
Signature · 1 line
2.18.2
PATCH v3 6/7 net/mlx5/hws: remove csum check from L3 ok check
In reply to Alexander KozyrevFrom: Michael Baum <[email protected]>
This patch changes the integrity item behavior for HW steering.
Old behavior: the "ipv4_csum_ok" checks only IPv4 checksum and "l3_ok" checks everything is ok including IPv4 checksum.
New behavior: the "l3_ok" checks everything is ok excluding IPv4 checksum.
This change enables matching "l3_ok" in IPv6 packets since for IPv6 packets "ipv4_csum_ok" is always miss.
For SW steering the old behavior is kept as same as for L4 ok.
--- doc/guides/nics/mlx5.rst | 11 ++++++++--- drivers/net/mlx5/hws/mlx5dr_definer.c | 6 ++---- 2 files changed, 10 insertions(+), 7 deletions(-)
doc/guides/nics/mlx5.rst +8 -3
@@ -663,12 +663,13 @@ Limitations - Integrity: - - Integrity offload is enabled starting from **ConnectX-6 Dx**. - Verification bits provided by the hardware are ``l3_ok``, ``ipv4_csum_ok``, ``l4_ok``, ``l4_csum_ok``. - ``level`` value 0 references outer headers. - Negative integrity item verification is not supported. - - Multiple integrity items not supported in a single flow rule. - - Flow rule items supplied by application must explicitly specify network headers referred by integrity item. + - With SW steering (``dv_flow_en=1``) + - Integrity offload is enabled starting from **ConnectX-6 Dx**. + - Multiple integrity items not supported in a single flow rule. + - Flow rule items supplied by application must explicitly specify network headers referred by integrity item. For example, if integrity item mask sets ``l4_ok`` or ``l4_csum_ok`` bits, reference to L4 network header, TCP or UDP, must be in the rule pattern as well::
@@ -676,6 +677,10 @@ Limitations flow create 0 ingress pattern integrity level is 0 value mask l4_ok value spec l4_ok / eth / ipv4 proto is udp / end … + - With HW steering (``dv_flow_en=2``) + - The ``l3_ok`` field represents all L3 checks, but nothing about whether IPv4 checksum ok. + - The ``l4_ok`` field represents all L4 checks including L4 checksum ok. + - Connection tracking: - Cannot co-exist with ASO meter, ASO age action in a single flow rule.
drivers/net/mlx5/hws/mlx5dr_definer.c +2 -4
@@ -380,10 +380,8 @@ mlx5dr_definer_integrity_set(struct mlx5dr_definer_fc *fc,uint32_t ok1_bits =0 ;if (v->l3_ok) - ok1_bits |= inner ?BIT (MLX5DR_DEFINER_OKS1_SECOND_L3_OK ) | -BIT (MLX5DR_DEFINER_OKS1_SECOND_IPV4_CSUM_OK ) : -BIT (MLX5DR_DEFINER_OKS1_FIRST_L3_OK ) | -BIT (MLX5DR_DEFINER_OKS1_FIRST_IPV4_CSUM_OK ); + ok1_bits |= inner ?BIT (MLX5DR_DEFINER_OKS1_SECOND_L3_OK ) : +BIT (MLX5DR_DEFINER_OKS1_FIRST_L3_OK );if (v->ipv4_csum_ok) ok1_bits |= inner ? BIT(MLX5DR_DEFINER_OKS1_SECOND_IPV4_CSUM_OK) :
Signature · 1 line
2.18.2
PATCH v3 7/7 net/mlx5/hws: fix integrity bits level
In reply to Alexander KozyrevThe level field in the integrity item is not taken into account in the current implementation of hardware steering. Use this value instead of trying to find out the encapsulation level according to the protocol items involved.
--- drivers/net/mlx5/hws/mlx5dr_definer.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/net/mlx5/hws/mlx5dr_definer.c +2 -4
@@ -1905,7 +1905,6 @@ mlx5dr_definer_conv_item_integrity(struct mlx5dr_definer_conv_data *cd, {const struct rte_flow_item_integrity *m = item->mask;struct mlx5dr_definer_fc *fc; -bool inner = cd->tunnel;if (!m)return 0 ;
@@ -1916,7 +1915,7 @@ mlx5dr_definer_conv_item_integrity(struct mlx5dr_definer_conv_data *cd, }if (m->l3_ok || m->ipv4_csum_ok || m->l4_ok || m->l4_csum_ok) { - fc = &cd->fc[DR_CALC_FNAME (INTEGRITY , inner)]; + fc = &cd->fc[DR_CALC_FNAME (INTEGRITY , m->level)]; fc->item_idx = item_idx; fc->tag_set = &mlx5dr_definer_integrity_set;DR_CALC_SET_HDR (fc, oks1, oks1_bits);
@@ -2471,8 +2470,7 @@ mlx5dr_definer_conv_items_to_hl(struct mlx5dr_context *ctx,break ;case RTE_FLOW_ITEM_TYPE_INTEGRITY : ret =mlx5dr_definer_conv_item_integrity (&cd, items, i); - item_flags |= cd.tunnel ?MLX5_FLOW_ITEM_INNER_INTEGRITY : -MLX5_FLOW_ITEM_OUTER_INTEGRITY ; + item_flags |=MLX5_FLOW_ITEM_INTEGRITY ;break ;case RTE_FLOW_ITEM_TYPE_CONNTRACK : ret =mlx5dr_definer_conv_item_conntrack (&cd, items, i);
Signature · 1 line
2.18.2
v4 cover ptype matching support in mlx5
In reply to Alexander KozyrevAdd support for RTE_FLOW_ITEM_TYPE_PTYPE in mlx5 PMD.
Alexander Kozyrev (3):
net/mlx5: add support for ptype match in hardware steering net/mlx5/hws: add support for fragmented ptype match
doc: add packet type matching item to release notes
Michael Baum (1):
doc: add PMD ptype item limitations
doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 15 ++ doc/guides/rel_notes/release_23_11.rst | 5 + drivers/net/mlx5/hws/mlx5dr_definer.c | 195 +++++++++++++++++++++++++ drivers/net/mlx5/hws/mlx5dr_definer.h | 9 ++ drivers/net/mlx5/mlx5_flow.h | 3 + drivers/net/mlx5/mlx5_flow_hw.c | 1 + 7 files changed, 229 insertions(+)
Signature · 1 line
2.18.2
PATCH v4 1/4 net/mlx5: add support for ptype match in hardware steering
The packet type matching provides quick way of finding out L2/L3/L4 protocols in a given packet. That helps with optimized flow rules matching, eliminating the need of stacking all the packet headers in the matching criteria.
--- drivers/net/mlx5/hws/mlx5dr_definer.c | 161 ++++++++++++++++++++++++++ drivers/net/mlx5/hws/mlx5dr_definer.h | 7 ++ drivers/net/mlx5/mlx5_flow.h | 3 + drivers/net/mlx5/mlx5_flow_hw.c | 1 + 4 files changed, 172 insertions(+)
drivers/net/mlx5/hws/mlx5dr_definer.c +161 -0
@@ -16,11 +16,15 @@#define STE_NO_VLAN 0x0#define STE_SVLAN 0x1#define STE_CVLAN 0x2 +#define STE_NO_L3 0x0#define STE_IPV4 0x1#define STE_IPV6 0x2 +#define STE_NO_L4 0x0#define STE_TCP 0x1#define STE_UDP 0x2#define STE_ICMP 0x3 +#define STE_NO_TUN 0x0 +#define STE_ESP 0x3#define MLX5DR_DEFINER_QUOTA_BLOCK 0#define MLX5DR_DEFINER_QUOTA_PASS 2
@@ -277,6 +281,82 @@ mlx5dr_definer_conntrack_tag(struct mlx5dr_definer_fc *fc,DR_SET (tag, reg_value, fc->byte_off, fc->bit_off, fc->bit_mask); } +static void +mlx5dr_definer_ptype_l2_set (struct mlx5dr_definer_fc *fc, +const void *item_spec, +uint8_t *tag) +{ +bool inner = (fc->fname ==MLX5DR_DEFINER_FNAME_PTYPE_L2_I ); +const struct rte_flow_item_ptype *v = item_spec; +uint32_t packet_type = v->packet_type & + (inner ?RTE_PTYPE_INNER_L2_MASK :RTE_PTYPE_L2_MASK ); +uint8_t l2_type =STE_NO_VLAN ; + +if (packet_type == (inner ?RTE_PTYPE_INNER_L2_ETHER :RTE_PTYPE_L2_ETHER )) + l2_type =STE_NO_VLAN ; +else if (packet_type == (inner ?RTE_PTYPE_INNER_L2_ETHER_VLAN :RTE_PTYPE_L2_ETHER_VLAN )) + l2_type =STE_CVLAN ; +else if (packet_type == (inner ?RTE_PTYPE_INNER_L2_ETHER_QINQ :RTE_PTYPE_L2_ETHER_QINQ )) + l2_type =STE_SVLAN ; + +DR_SET (tag, l2_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + +static void +mlx5dr_definer_ptype_l3_set (struct mlx5dr_definer_fc *fc, +const void *item_spec, +uint8_t *tag) +{ +bool inner = (fc->fname ==MLX5DR_DEFINER_FNAME_PTYPE_L3_I ); +const struct rte_flow_item_ptype *v = item_spec; +uint32_t packet_type = v->packet_type & + (inner ?RTE_PTYPE_INNER_L3_MASK :RTE_PTYPE_L3_MASK ); +uint8_t l3_type =STE_NO_L3 ; + +if (packet_type == (inner ?RTE_PTYPE_INNER_L3_IPV4 :RTE_PTYPE_L3_IPV4 )) + l3_type =STE_IPV4 ; +else if (packet_type == (inner ?RTE_PTYPE_INNER_L3_IPV6 :RTE_PTYPE_L3_IPV6 )) + l3_type =STE_IPV6 ; + +DR_SET (tag, l3_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + +static void +mlx5dr_definer_ptype_l4_set (struct mlx5dr_definer_fc *fc, +const void *item_spec, +uint8_t *tag) +{ +bool inner = (fc->fname ==MLX5DR_DEFINER_FNAME_PTYPE_L4_I ); +const struct rte_flow_item_ptype *v = item_spec; +uint32_t packet_type = v->packet_type & + (inner ?RTE_PTYPE_INNER_L4_MASK :RTE_PTYPE_L4_MASK ); +uint8_t l4_type =STE_NO_L4 ; + +if (packet_type == (inner ?RTE_PTYPE_INNER_L4_TCP :RTE_PTYPE_L4_TCP )) + l4_type =STE_TCP ; +else if (packet_type == (inner ?RTE_PTYPE_INNER_L4_UDP :RTE_PTYPE_L4_UDP )) + l4_type =STE_UDP ; +else if (packet_type == (inner ?RTE_PTYPE_INNER_L4_ICMP :RTE_PTYPE_L4_ICMP )) + l4_type =STE_ICMP ; + +DR_SET (tag, l4_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + +static void +mlx5dr_definer_ptype_tunnel_set (struct mlx5dr_definer_fc *fc, +const void *item_spec, +uint8_t *tag) +{ +const struct rte_flow_item_ptype *v = item_spec; +uint32_t packet_type = v->packet_type &RTE_PTYPE_TUNNEL_MASK ; +uint8_t tun_type =STE_NO_TUN ; + +if (packet_type ==RTE_PTYPE_TUNNEL_ESP ) + tun_type =STE_ESP ; + +DR_SET (tag, tun_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + static void mlx5dr_definer_integrity_set(struct mlx5dr_definer_fc *fc, const void *item_spec,
@@ -1709,6 +1789,83 @@ mlx5dr_definer_conv_item_gre_key(struct mlx5dr_definer_conv_data *cd,return 0 ; } +static int +mlx5dr_definer_conv_item_ptype (struct mlx5dr_definer_conv_data *cd, +struct rte_flow_item *item, +int item_idx) +{ +const struct rte_flow_item_ptype *m = item->mask; +struct mlx5dr_definer_fc *fc; + +if (!m) +return 0 ; + +if (!(m->packet_type & + (RTE_PTYPE_L2_MASK |RTE_PTYPE_L3_MASK |RTE_PTYPE_L4_MASK |RTE_PTYPE_TUNNEL_MASK | +RTE_PTYPE_INNER_L2_MASK |RTE_PTYPE_INNER_L3_MASK |RTE_PTYPE_INNER_L4_MASK ))) { + rte_errno =ENOTSUP ; +return rte_errno; + } + +if (m->packet_type &RTE_PTYPE_L2_MASK ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L2 , false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l2_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, first_vlan_qualifier, false); + } + +if (m->packet_type &RTE_PTYPE_INNER_L2_MASK ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L2 , true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l2_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, first_vlan_qualifier, true); + } + +if (m->packet_type &RTE_PTYPE_L3_MASK ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L3 , false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l3_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, l3_type, false); + } + +if (m->packet_type &RTE_PTYPE_INNER_L3_MASK ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L3 , true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l3_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, l3_type, true); + } + +if (m->packet_type &RTE_PTYPE_L4_MASK ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L4 , false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l4_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, l4_type, false); + } + +if (m->packet_type &RTE_PTYPE_INNER_L4_MASK ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L4 , true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l4_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, l4_type, true); + } + +if (m->packet_type &RTE_PTYPE_TUNNEL_MASK ) { + fc = &cd->fc[MLX5DR_DEFINER_FNAME_PTYPE_TUNNEL ]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_tunnel_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, l4_type_bwc, false); + } + +return 0 ; +} + static int mlx5dr_definer_conv_item_integrity(struct mlx5dr_definer_conv_data *cd, struct rte_flow_item *item,
@@ -2332,6 +2489,10 @@ mlx5dr_definer_conv_items_to_hl(struct mlx5dr_context *ctx, ret =mlx5dr_definer_conv_item_ib_l4 (&cd, items, i); item_flags |=MLX5_FLOW_ITEM_IB_BTH ;break ; +case RTE_FLOW_ITEM_TYPE_PTYPE : + ret =mlx5dr_definer_conv_item_ptype (&cd, items, i); + item_flags |=MLX5_FLOW_ITEM_PTYPE ; +break ;default :DR_LOG (ERR ,"Unsupported item type %d" , items->type); rte_errno =ENOTSUP ;
drivers/net/mlx5/hws/mlx5dr_definer.h +7 -0
@@ -141,6 +141,13 @@ enum mlx5dr_definer_fname {MLX5DR_DEFINER_FNAME_IB_L4_OPCODE ,MLX5DR_DEFINER_FNAME_IB_L4_QPN ,MLX5DR_DEFINER_FNAME_IB_L4_A , +MLX5DR_DEFINER_FNAME_PTYPE_L2_O , +MLX5DR_DEFINER_FNAME_PTYPE_L2_I , +MLX5DR_DEFINER_FNAME_PTYPE_L3_O , +MLX5DR_DEFINER_FNAME_PTYPE_L3_I , +MLX5DR_DEFINER_FNAME_PTYPE_L4_O , +MLX5DR_DEFINER_FNAME_PTYPE_L4_I , +MLX5DR_DEFINER_FNAME_PTYPE_TUNNEL , MLX5DR_DEFINER_FNAME_MAX, };
drivers/net/mlx5/mlx5_flow.h +3 -0
@@ -233,6 +233,9 @@ enum mlx5_feature_name {/* IB BTH ITEM. */ #define MLX5_FLOW_ITEM_IB_BTH (1ull << 51) +/* PTYPE ITEM */ +#define MLX5_FLOW_ITEM_PTYPE (1ull << 52) +/* NSH ITEM */ #define MLX5_FLOW_ITEM_NSH (1ull << 53)
drivers/net/mlx5/mlx5_flow_hw.c +1 -0
@@ -5382,6 +5382,7 @@ flow_hw_pattern_validate(struct rte_eth_dev *dev,case RTE_FLOW_ITEM_TYPE_ESP :case RTE_FLOW_ITEM_TYPE_FLEX :case RTE_FLOW_ITEM_TYPE_IB_BTH : +case RTE_FLOW_ITEM_TYPE_PTYPE :break ;case RTE_FLOW_ITEM_TYPE_INTEGRITY :/*
Signature · 1 line
2.18.2
RE: [PATCH v4 1/4] net/mlx5: add support for ptype match in hardware steering
Hi
Quoted 6 lines
-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Wednesday, October 25, 2023 11:51 PM
Subject: [PATCH v4 1/4] net/mlx5: add support for ptype match in hardware steering
Quoted 7 lines
The packet type matching provides quick way of finding out L2/L3/L4 protocols in a given packet. That helps with optimized flow rules matching, eliminating the need of stacking all the packet headers in the matching criteria.
Signed-off-by Alexander Kozyrev <[email protected]>---
Best,
Ori
PATCH v4 2/4 net/mlx5/hws: add support for fragmented ptype match
In reply to Alexander KozyrevExpand packet type matching with support of the
Fragmented IP (Internet Protocol) packet type.
--- drivers/net/mlx5/hws/mlx5dr_definer.c | 54 ++++++++++++++++++++++----- drivers/net/mlx5/hws/mlx5dr_definer.h | 2 + 2 files changed, 46 insertions(+), 10 deletions(-)
drivers/net/mlx5/hws/mlx5dr_definer.c +44 -10
@@ -357,6 +357,19 @@ mlx5dr_definer_ptype_tunnel_set(struct mlx5dr_definer_fc *fc,DR_SET (tag, tun_type, fc->byte_off, fc->bit_off, fc->bit_mask); } +static void +mlx5dr_definer_ptype_frag_set (struct mlx5dr_definer_fc *fc, +const void *item_spec, +uint8_t *tag) +{ +bool inner = (fc->fname ==MLX5DR_DEFINER_FNAME_PTYPE_FRAG_I ); +const struct rte_flow_item_ptype *v = item_spec; +uint32_t packet_type = v->packet_type & + (inner ?RTE_PTYPE_INNER_L4_FRAG :RTE_PTYPE_L4_FRAG ); + +DR_SET (tag, !!packet_type, fc->byte_off, fc->bit_off, fc->bit_mask); +} + static void mlx5dr_definer_integrity_set(struct mlx5dr_definer_fc *fc, const void *item_spec,
@@ -1840,19 +1853,40 @@ mlx5dr_definer_conv_item_ptype(struct mlx5dr_definer_conv_data *cd, }if (m->packet_type &RTE_PTYPE_L4_MASK ) { - fc = &cd->fc[DR_CALC_FNAME (PTYPE_L4 , false)]; - fc->item_idx = item_idx; - fc->tag_set = &mlx5dr_definer_ptype_l4_set; - fc->tag_mask_set = &mlx5dr_definer_ones_set; -DR_CALC_SET (fc, eth_l2, l4_type, false); +/* +* Fragmented IP (Internet Protocol) packet type. +* Cannot be combined with Layer 4 Types (TCP/UDP). +* The exact value must be specified in the mask. +*/ +if (m->packet_type ==RTE_PTYPE_L4_FRAG ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_FRAG , false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_frag_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, ip_fragmented, false); + }else { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L4 , false)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l4_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, l4_type, false); + } }if (m->packet_type &RTE_PTYPE_INNER_L4_MASK ) { - fc = &cd->fc[DR_CALC_FNAME (PTYPE_L4 , true)]; - fc->item_idx = item_idx; - fc->tag_set = &mlx5dr_definer_ptype_l4_set; - fc->tag_mask_set = &mlx5dr_definer_ones_set; -DR_CALC_SET (fc, eth_l2, l4_type, true); +if (m->packet_type ==RTE_PTYPE_INNER_L4_FRAG ) { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_FRAG , true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_frag_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, ip_fragmented, true); + }else { + fc = &cd->fc[DR_CALC_FNAME (PTYPE_L4 , true)]; + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_ptype_l4_set; + fc->tag_mask_set = &mlx5dr_definer_ones_set; +DR_CALC_SET (fc, eth_l2, l4_type, true); + } }if (m->packet_type &RTE_PTYPE_TUNNEL_MASK ) {
drivers/net/mlx5/hws/mlx5dr_definer.h +2 -0
@@ -148,6 +148,8 @@ enum mlx5dr_definer_fname {MLX5DR_DEFINER_FNAME_PTYPE_L4_O ,MLX5DR_DEFINER_FNAME_PTYPE_L4_I ,MLX5DR_DEFINER_FNAME_PTYPE_TUNNEL , +MLX5DR_DEFINER_FNAME_PTYPE_FRAG_O , +MLX5DR_DEFINER_FNAME_PTYPE_FRAG_I , MLX5DR_DEFINER_FNAME_MAX, };
Signature · 1 line
2.18.2
RE: [PATCH v4 2/4] net/mlx5/hws: add support for fragmented ptype match
Hi
Quoted 9 lines
-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Wednesday, October 25, 2023 11:51 PMExpand packet type matching with support of the
Fragmented IP (Internet Protocol) packet type.Signed-off-by Alexander Kozyrev <[email protected]>---
Best,
Ori
PATCH v4 3/4 doc: add PMD ptype item limitations
In reply to Alexander KozyrevFrom: Michael Baum <[email protected]>
Add limitations for ptype item support in "mlx5.rst" file.
--- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 15 +++++++++++++++ 2 files changed, 16 insertions(+)
doc/guides/nics/features/mlx5.ini +1 -0
@@ -86,6 +86,7 @@ nsh = Y nvgre = Y port_id = Y port_representor = Y +ptype = Y quota = Y tag = Y tcp = Y
doc/guides/nics/mlx5.rst +15 -0
@@ -646,6 +646,21 @@ Limitations - When using HWS flow engine (``dv_flow_en`` = 2), only meter mark action is supported. +- Ptype: + + - Only supports HW steering (``dv_flow_en=2``). + - The supported values are: + L2: ``RTE_PTYPE_L2_ETHER``, ``RTE_PTYPE_L2_ETHER_VLAN``, ``RTE_PTYPE_L2_ETHER_QINQ`` + L3: ``RTE_PTYPE_L3_IPV4``, ``RTE_PTYPE_L3_IPV6`` + L4: ``RTE_PTYPE_L4_TCP``, ``RTE_PTYPE_L4_UDP``, ``RTE_PTYPE_L4_ICMP`` + and their ``RTE_PTYPE_INNER_XXX`` counterparts as well as ``RTE_PTYPE_TUNNEL_ESP``. + Any other values are not supported. Using them as a value will cause unexpected behavior. + - Matching on both outer and inner IP fragmented is supported using ``RTE_PTYPE_L4_FRAG`` and + ``RTE_PTYPE_INNER_L4_FRAG`` values. They are not part of L4 types, so they should be provided + explicitly as a mask value during pattern template creation. Providing ``RTE_PTYPE_L4_MASK`` + during pattern template creation and ``RTE_PTYPE_L4_FRAG`` during flow rule creation + will cause unexpected behavior. + - Integrity: - Integrity offload is enabled starting from **ConnectX-6 Dx**.
Signature · 1 line
2.18.2
RE: [PATCH v4 3/4] doc: add PMD ptype item limitations
Hi
Quoted 10 lines
-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Wednesday, October 25, 2023 11:51 PMFrom: Michael Baum <[email protected]>
Add limitations for ptype item support in "
mlx5.rst" file.Signed-off-by Michael Baum <[email protected]>---
Best,
Ori
PATCH v4 4/4 doc: add packet type matching item to release notes
In reply to Alexander KozyrevDocument new RTE_FLOW_ITEM_TYPE_PTYPE in the release notes.
--- doc/guides/rel_notes/release_23_11.rst | 5 +++++ 1 file changed, 5 insertions(+)
doc/guides/rel_notes/release_23_11.rst +5 -0
@@ -122,6 +122,10 @@ New Features a group's miss actions, which are the actions to be performed on packets that didn't match any of the flow rules in the group. +* **Added ptype matching criteria.** + Added ``RTE_FLOW_ITEM_TYPE_PTYPE`` to allow matching on L2/L3/L4 + and tunnel information as defined in mbuf packet type. + * **Updated Intel cpfl driver.** * Added support for port representor.
@@ -143,6 +147,7 @@ New Features * **Updated NVIDIA mlx5 net driver.** * Added support for Network Service Header (NSH) flow matching. + * Added support for ``RTE_FLOW_ITEM_TYPE_PTYPE`` flow item. * **Updated Solarflare net driver.**
Signature · 1 line
2.18.2
RE: [PATCH v4 4/4] doc: add packet type matching item to release notes
Quoted 9 lines
-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Wednesday, October 25, 2023 11:51 PM Document newRTE_FLOW_ITEM_TYPE_PTYPEin the release notes.Signed-off-by Alexander Kozyrev <[email protected]>---
Best,
Ori
RE: [PATCH v4 0/4] ptype matching support in mlx5
In reply to Alexander KozyrevHi,
Quoted 30 lines
-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Wednesday, October 25, 2023 11:51 PM
To: [email protected]
Cc: Ori Kam <[email protected]>; Matan Azrad <[email protected]>; Michael Baum <[email protected]>; Alex Vesker <[email protected]>; Suanming Mou <[email protected]>; Slava Ovsiienko <[email protected]>; Erez Shitrit <[email protected]>
Subject: [PATCH v4 0/4] ptype matching support in mlx5Add support for
RTE_FLOW_ITEM_TYPE_PTYPEin mlx5 PMD.Alexander Kozyrev (3):
net/mlx5: add support for ptype match in hardware steeringnet/mlx5/hws: add support for fragmented ptype match
doc: add packet type matching item to release notesMichael Baum (1):
doc: add PMD ptype item limitationsdoc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 15 ++ doc/guides/rel_notes/release_23_11.rst | 5 + drivers/net/mlx5/hws/mlx5dr_definer.c | 195 +++++++++++++++++++++++++ drivers/net/mlx5/hws/mlx5dr_definer.h | 9 ++ drivers/net/mlx5/mlx5_flow.h | 3 + drivers/net/mlx5/mlx5_flow_hw.c | 1 + 7 files changed, 229 insertions(+)
Quoted 2 lines
--
2.18.2
Series applied to next-net-mlx,
Squashed the last two patches into first as they need to be with the same patch that introduced the feature.
Kindest regards,
Raslan Darawsheh