ALSA: ump: Fix -Wformat-truncation warnings
PATCH v2 1/1 ALSA: ump: Fix -Wformat-truncation warnings
Filling the rawmidi name and substream name can be truncated, and this leads to spurious compiler warnings due to -Wformat-truncation. Although the truncation is the expected behavior, it'd be better to truncate the string within "(...)"
This patch puts the precision specifies to each %s for fitting the words within the size-limited strings.
Fixes 5f11dd938fe7 ("ALSA: usb-audio: Attach legacy rawmidi after probing all UMP EPs")
Reported-by kernel test robot <[email protected]>
Signed-off-by Takashi Iwai <[email protected]>
---v1->v2: change the precision to fit better
sound/core/ump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/core/ump.c +2 -2
@@ -1157,7 +1157,7 @@ static void fill_substream_names(struct snd_ump_endpoint *ump,struct snd_rawmidi_substream *s;list_for_each_entry (s, &rmidi->streams[dir].substreams, list) -snprintf (s->name,sizeof (s->name),"Group %d (%s)" , +snprintf (s->name,sizeof (s->name),"Group %d (%.16s)" , ump->legacy_mapping[s->number] +1 , ump->info.name); }
@@ -1191,7 +1191,7 @@ int snd_ump_attach_legacy_rawmidi(struct snd_ump_endpoint *ump,if (output)snd_rawmidi_set_ops (rmidi,SNDRV_RAWMIDI_STREAM_OUTPUT , &snd_ump_legacy_output_ops); -snprintf (rmidi->name,sizeof (rmidi->name),"%s (MIDI 1.0)" , +snprintf (rmidi->name,sizeof (rmidi->name),"%.68s (MIDI 1.0)" , ump->info.name); rmidi->info_flags = ump->core.info_flags & ~SNDRV_RAWMIDI_INFO_UMP ; rmidi->ops = &snd_ump_legacy_ops;
Signature · 1 line
2.35.3