Skip to contentSkip to conversation

riscv: dts: starfive: fix NOR flash reserved-data partition size

PATCH Applied Aurelien Jarno 3 participants 3 messages Aug 26, 2023 – Aug 28, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 riscv: dts: starfive: fix NOR flash reserved-data partition size

The Starfive VisionFive 2 has a 16MiB NOR flash, while the reserved-data partition is declared starting at address 0x600000 with a size of 0x1000000. This causes the kernel to output the following warning:

[   22.156589] mtd: partition "reserved-data" extends beyond the end of device "13010000.spi.0" -- size truncated to 0xa00000

It seems to be a confusion between the size of the partition and the end address. Fix that by specifying the right size.

Fixes 8384087a4223 ("riscv: dts: starfive: Add QSPI controller node for StarFive JH7110 SoC")
---
 arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi +1 -1
index 498eb179d90f..30c85ba6da02 100644
@@ -262,7 +262,7 @@ uboot@100000 {
 				reg = <0x100000 0x400000>;
 			};
 			reserved-data@600000 {
-				reg = <0x600000 0x1000000>;
+				reg = <0x600000 0xa00000>;
 			};
 		};
 	};
Signature · 7 lines
2.39.2


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Aurelien Jarno

The Starfive VisionFive 2 has a 16MiB NOR flash, while the reserved-data partition is declared starting at address 0x600000 with a size of 0x1000000. This causes the kernel to output the following warning:

[   22.156589] mtd: partition "reserved-data" extends beyond the end of device "13010000.spi.0" -- size truncated to 0xa00000

It seems to be a confusion between the size of the partition and the end address. Fix that by specifying the right size.

Fixes 8384087a4223 ("riscv: dts: starfive: Add QSPI controller node for StarFive JH7110 SoC")

Thanks!

Quoted 22 lines
---
 arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi +1 -2
index 498eb179d90f..30c85ba6da02 100644
@@ -262,7 +262,7 @@ uboot@100000 {
                                reg = <0x100000 0x400000>;
                        };
                        reserved-data@600000 {
-                               reg = <0x600000 0x1000000>;
+                               reg = <0x600000 0xa00000>;
                        };
                };
        };
--

2.39.2

Quoted 4 lines

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

maintainer Applied
#2 lore raw
In reply to Aurelien Jarno

From: Conor Dooley <[email protected]>

Quoted 10 lines · Aurelien Jarno

The Starfive VisionFive 2 has a 16MiB NOR flash, while the reserved-data partition is declared starting at address 0x600000 with a size of 0x1000000. This causes the kernel to output the following warning:

[   22.156589] mtd: partition "reserved-data" extends beyond the end of device "13010000.spi.0" -- size truncated to 0xa00000

It seems to be a confusion between the size of the partition and the end address. Fix that by specifying the right size.

[...]

Applied to riscv-dt-fixes, thanks!

[1/1] riscv: dts: starfive: fix NOR flash reserved-data partition size

      https://git.kernel.org/conor/c/602afaaa6ef9

(I may end up rebasing after -rc1, so this hash isn't stable)

Thanks,
Conor.

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv