Skip to contentSkip to conversation

rtc: sun6i: remove unnecessary message

PATCH In review [email protected] 3 participants 5 messages Aug 27, 2023 – Sep 5, 2023

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/3 rtc: sun6i: remove unnecessary message

From: Alexandre Belloni <[email protected]>

The core already print a message once the rtc is successfully registered, it is not necessary to print an other one.

---
 drivers/rtc/rtc-sun6i.c | 2 --
 1 file changed, 2 deletions(-)
drivers/rtc/rtc-sun6i.c +0 -2
index 753a2d9c8a17..8e0c66906103 100644
@@ -846,8 +846,6 @@ static int sun6i_rtc_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	dev_info(&pdev->dev, "RTC enabled\n");
-
 	return 0;
 }
 
Signature · 1 line
2.41.0
author maintainer
#1 lore raw

PATCH 2/3 rtc: twl: remove unnecessary messages

From: Alexandre Belloni <[email protected]>

The RTC core already prints a message when the RTC is registered and when registering fails, it is not necessary to have more in the driver.

---
 drivers/rtc/rtc-twl.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/rtc/rtc-twl.c +1 -5
index f8f0d774a06e..13f8ce08243c 100644
@@ -555,7 +555,6 @@ static int twl_rtc_probe(struct platform_device *pdev)
 			REG_INT_MSK_STS_A);
 	}
 
-	dev_info(&pdev->dev, "Enabling TWL-RTC\n");
 	ret = twl_rtc_write_u8(twl_rtc, BIT_RTC_CTRL_REG_STOP_RTC_M,
 			       REG_RTC_CTRL_REG);
 	if (ret < 0)
@@ -577,11 +576,8 @@ static int twl_rtc_probe(struct platform_device *pdev)
 
 	twl_rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
 					&twl_rtc_ops, THIS_MODULE);
-	if (IS_ERR(twl_rtc->rtc)) {
-		dev_err(&pdev->dev, "can't register RTC device, err %ld\n",
-			PTR_ERR(twl_rtc->rtc));
+	if (IS_ERR(twl_rtc->rtc))
 		return PTR_ERR(twl_rtc->rtc);
-	}
 
 	ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
 					twl_rtc_interrupt,
Signature · 1 line
2.41.0
author maintainer
#2 lore raw

PATCH 3/3 rtc: wm8350: remove unnecessary messages

In reply to [email protected]

From: Alexandre Belloni <[email protected]>

The RTC core already prints a message when the RTC is registered and when registering fails, it is not necessary to have more in the driver.

---
 drivers/rtc/rtc-wm8350.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/rtc/rtc-wm8350.c +2 -7
index 947f8071803f..3c773cff2b39 100644
@@ -386,8 +386,6 @@ static int wm8350_rtc_probe(struct platform_device *pdev)
 	/* enable the RTC if it's not already enabled */
 	power5 = wm8350_reg_read(wm8350, WM8350_POWER_MGMT_5);
 	if (!(power5 &  WM8350_RTC_TICK_ENA)) {
-		dev_info(wm8350->dev, "Starting RTC\n");
-
 		wm8350_reg_unlock(wm8350);
 
 		ret = wm8350_set_bits(wm8350, WM8350_POWER_MGMT_5,
@@ -426,11 +424,8 @@ static int wm8350_rtc_probe(struct platform_device *pdev)
 
 	wm_rtc->rtc = devm_rtc_device_register(&pdev->dev, "wm8350",
 					&wm8350_rtc_ops, THIS_MODULE);
-	if (IS_ERR(wm_rtc->rtc)) {
-		ret = PTR_ERR(wm_rtc->rtc);
-		dev_err(&pdev->dev, "failed to register RTC: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(wm_rtc->rtc))
+		return PTR_ERR(wm_rtc->rtc);
 
 	ret = wm8350_register_irq(wm8350, WM8350_IRQ_RTC_SEC,
 			    wm8350_rtc_update_handler, 0,
Signature · 1 line
2.41.0
Acked-by on v1 3/3
#3 lore raw

Re: [PATCH 3/3] rtc: wm8350: remove unnecessary messages

Quoted 7 lines · On Mon, Aug 28, 2023 at 12:16:42AM +0200, [email protected] wrote:

From: Alexandre Belloni <[email protected]>

The RTC core already prints a message when the RTC is registered and when registering fails, it is not necessary to have more in the driver.

---

Thanks,
Charles

maintainer Acked-by on v1 1/3
#4 lore raw
In reply to [email protected]
Quoted 6 lines · On Monday, August 28, 2023 12:16:40 AM CEST [email protected] wrote:

From: Alexandre Belloni <[email protected]>

The core already print a message once the rtc is successfully registered, it is not necessary to print an other one.

Best regards,
Jernej

Quoted 16 lines
---
 drivers/rtc/rtc-sun6i.c | 2 --
 1 file changed, 2 deletions(-)
drivers/rtc/rtc-sun6i.c +0 -2
index 753a2d9c8a17..8e0c66906103 100644
@@ -846,8 +846,6 @@ static int sun6i_rtc_probe(struct platform_device *pdev)
 if (ret)
 		return ret;
 
-	dev_info(&pdev->dev, "RTC enabled\n");
-
 	return 0;
 }