driver core: return an error when dev_set_name() hasn't happened
PATCH 1/1 driver core: return an error when dev_set_name() hasn't happened
The commit d21fdd07cea4 ("driver core: Return proper error code when dev_set_name() fails") rewrote the logic of handling the dev_set_name() error codes, but missed the point that initially set error value to -EINVAL might be rewritten and hence the error path can't be triggered at some circumstances. To fix this, make sure that error variable is set to -EINVAL when other conditionals are false.
Reported-by [email protected]
Fixes d21fdd07cea4 ("driver core: Return proper error code when dev_set_name() fails")
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/base/core.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/base/core.c +2 -0
@@ -3538,6 +3538,8 @@ int device_add(struct device *dev)/* subsystems can specify simple device enumeration */ else if (dev->bus && dev->bus->dev_name) error =dev_set_name (dev,"%s%u" , dev->bus->dev_name, dev->id); + else + error = -EINVAL ;if (error) goto name_error;
Signature · 1 line
2.40.0.1.gaa8946217a0b