shared/gatt-client: Fix not sending confirmations
Luiz Augusto von Dentz
maintainerPATCH 1/1 shared/gatt-client: Fix not sending confirmations
From: Luiz Augusto von Dentz <[email protected]>
Commit fde32ff9c9c0 ("shared/gatt-client: Allow registering with NULL callback") added an early return to the notify_cb function when the current client's notify_list is empty which prevents sending confirmations to indications.
--- src/shared/gatt-client.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
src/shared/gatt-client.c +4 -3
@@ -2232,11 +2232,11 @@ static void notify_cb(struct bt_att_chan *chan, uint8_t opcode,struct bt_gatt_client *client = user_data;struct value_data data; -if (queue_isempty (client->notify_list)) -return ; -bt_gatt_client_ref (client); +if (queue_isempty (client->notify_list)) + goto done; +memset (&data,0 ,sizeof (data));if (opcode ==BT_ATT_OP_HANDLE_NFY_MULT ) {
@@ -2271,6 +2271,7 @@ static void notify_cb(struct bt_att_chan *chan, uint8_t opcode,queue_foreach (client->notify_list, notify_handler, &data); } +done:if (opcode ==BT_ATT_OP_HANDLE_IND && !client->parent)bt_att_chan_send (chan,BT_ATT_OP_HANDLE_CONF ,NULL ,0 ,NULL ,NULL ,NULL );
Signature · 1 line
2.41.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=780014
---Test result---
Test Summary:
CheckPatch FAIL 0.79 seconds GitLint PASS 0.37 seconds BuildEll PASS 27.87 seconds BluezMake PASS 862.90 seconds MakeCheck PASS 12.61 seconds MakeDistcheck PASS 156.98 seconds CheckValgrind PASS 257.28 seconds CheckSmatch PASS 343.83 seconds bluezmakeextell PASS 105.81 seconds IncrementalBuild PASS 709.33 seconds ScanBuild WARNING 1073.71 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ] shared/gatt-client: Fix not sending confirmations WARNING:UNKNOWN_COMMIT_ID: Unknown commit id 'fde32ff9c9c0', maybe rebased or not pulled? #81:
Commit fde32ff9c9c0 ("shared/gatt-client: Allow registering with NULL
/github/workspace/src/src/13368176.patch total: 0 errors, 1 warnings, 21 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13368176.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: ScanBuild - WARNING
Desc: Run Scan Build
Output:src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed
gatt_db_unregister(op->client->db, op->db_id);
^~~~~~~~~~
src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed
discovery_op_complete(op, false, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:993:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1099:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1291:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1356:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1631:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1636:2: warning: Use of memory after it is freed
discover_all(op);
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2140:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2148:8: warning: Use of memory after it is freed
discovery_op_ref(op),
^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3237:2: warning: Use of memory after it is freed
complete_write_long_op(req, success, 0, false);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3259:2: warning: Use of memory after it is freed
request_unref(req);
^~~~~~~~~~~~~~~~~~12 warnings generated.
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 8 lines · On Mon, 28 Aug 2023 10:55:53 -0700 you wrote:
From: Luiz Augusto von Dentz <[email protected]>
Commit
fde32ff9c9c0("shared/gatt-client: Allow registering with NULL callback") added an early return to thenotify_cbfunction when the current client'snotify_listis empty which prevents sending confirmations to indications.[...]
Here is the summary with links:
- [BlueZ] shared/gatt-client: Fix not sending confirmations
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=670f0d0f618d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Quoted 6 lines · Luiz Augusto von Dentz
From: Luiz Augusto von Dentz <[email protected]>
Commit
fde32ff9c9c0("shared/gatt-client: Allow registering with NULL callback") added an early return to thenotify_cbfunction when the current client'snotify_listis empty which prevents sending confirmations to indications.
Thanks, confirming your patch also works for me.
Javier.