Skip to contentSkip to conversation

iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h

PATCH Applied Andy Shevchenko 3 participants 4 messages Aug 8, 2023 – Aug 28, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h

There is nothing from string_helpers.h used in the driver, correct the header inclusion block accordingly.

---
 drivers/iio/accel/kionix-kx022a.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/accel/kionix-kx022a.c +1 -1
index 4ea3c6718ed4..f164b09520c9 100644
@@ -15,7 +15,7 @@
 #include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
 #include <linux/slab.h>
-#include <linux/string_helpers.h>
+#include <linux/string_choices.h>
 #include <linux/units.h>
 
 #include <linux/iio/iio.h>
Signature · 1 line
2.40.0.1.gaa8946217a0b
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Andy Shevchenko

There is nothing from string_helpers.h used in the driver, correct the header inclusion block accordingly.

Out of the curiosity - is the goal to get rid of including choices from helpers? (I think) then the header split would be more beneficial.

Quoted 17 lines
---
  drivers/iio/accel/kionix-kx022a.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/accel/kionix-kx022a.c +1 -1
index 4ea3c6718ed4..f164b09520c9 100644
@@ -15,7 +15,7 @@
  #include <linux/regmap.h>
  #include <linux/regulator/consumer.h>
  #include <linux/slab.h>
-#include <linux/string_helpers.h>
+#include <linux/string_choices.h>
  #include <linux/units.h>
 
  #include <linux/iio/iio.h>
Signature · 5 lines
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~
#2 lore raw
Quoted 10 lines · Matti Vaittinen
Quoted 4 lines · Andy Shevchenko

There is nothing from string_helpers.h used in the driver, correct the header inclusion block accordingly.

Out of the curiosity - is the goal to get rid of including choices from helpers? (I think) then the header split would be more beneficial.

At the end, yes.

Thank you for acknowledging!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Applied
#3 lore raw
Quoted 7 lines · On Thu, 10 Aug 2023 16:29:25 +0300 Andy Shevchenko…
Quoted 6 lines · Matti Vaittinen
Quoted 4 lines · Andy Shevchenko

There is nothing from string_helpers.h used in the driver, correct the header inclusion block accordingly.

Quoted 9 lines
Quoted 4 lines

Out of the curiosity - is the goal to get rid of including choices from helpers? (I think) then the header split would be more beneficial.

At the end, yes.

Thank you for acknowledging!

Applied.