Skip to contentSkip to conversation

ti-img-rogue-umlibs: Add DEPENDS on BASE_DEFAULT_DEPS

PATCH In review Ryan Eatmon 2 participants 6 messages Aug 28, 2023 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ti-img-rogue-umlibs: Add DEPENDS on BASE_DEFAULT_DEPS

A recent change to oe-core [1], has caused a pile of QA errors during packaging for this binary package. The effect of the change in oe-core was to remove the dependency on the compiler and other compiler adjacent libraries. But the binary packages need some of the compiler tools as part of the packaging flow (ie. objdump).

Until the above gets reverted, this patch will fix the issue and can be reverted itself once oe-core is fixed.

[1] https://git.openembedded.org/openembedded-core/commit/?h=master&id=d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727

---
 .../powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb          | 2 ++
 1 file changed, 2 insertions(+)
meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb +2 -0
index f748bd0f..73de93e5 100644
@@ -37,6 +37,8 @@ PACKAGECONFIG[opengl] = ",,,,${GLES_PACKAGES}"
 PACKAGECONFIG[vulkan] = ",,,,${VULKAN_PACKAGES}"
 PACKAGECONFIG[opencl] = ",,,,${OPENCL_PACKAGES}"
 
+DEPENDS:prepend = "${BASE_DEFAULT_DEPS} "
+
 def get_file_list(package_list_var, d):
     file_list = []
     package_list = d.getVar(package_list_var)
Signature · 1 line
2.17.1
#1 lore raw
Quoted 10 lines · Ryan Eatmon via lists.yoctoproject.org

A recent change to oe-core [1], has caused a pile of QA errors during packaging for this binary package. The effect of the change in oe-core was to remove the dependency on the compiler and other compiler adjacent libraries. But the binary packages need some of the compiler tools as part of the packaging flow (ie. objdump).

Until the above gets reverted, this patch will fix the issue and can be reverted itself once oe-core is fixed.

[1] https://git.openembedded.org/openembedded-core/commit/?h=master&id=d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727

Why not simply reset INHIBIT_DEFAULT_DEPS in the recipe?

Quoted 20 lines
---
 .../powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb          | 2 ++
 1 file changed, 2 insertions(+)
meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb +2 -0
index f748bd0f..73de93e5 100644
@@ -37,6 +37,8 @@ PACKAGECONFIG[opengl] = ",,,,${GLES_PACKAGES}"
 PACKAGECONFIG[vulkan] = ",,,,${VULKAN_PACKAGES}"
 PACKAGECONFIG[opencl] = ",,,,${OPENCL_PACKAGES}"
 
+DEPENDS:prepend = "${BASE_DEFAULT_DEPS} "
+
 def get_file_list(package_list_var, d):
     file_list = []
     package_list = d.getVar(package_list_var)
Signature · 1 line
2.17.1
#2 lore raw
Quoted 7 lines · Denys Dmytriyenko
Quoted 6 lines · Ryan Eatmon via lists.yoctoproject.org

A recent change to oe-core [1], has caused a pile of QA errors during packaging for this binary package. The effect of the change in oe-core was to remove the dependency on the compiler and other compiler adjacent libraries. But the binary packages need some of the compiler tools as part of the packaging flow (ie. objdump).

Quoted 6 lines
Quoted 4 lines

Until the above gets reverted, this patch will fix the issue and can be reverted itself once oe-core is fixed.

[1] https://git.openembedded.org/openembedded-core/commit/?h=master&id=d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727

Why not simply reset INHIBIT_DEFAULT_DEPS in the recipe?

Good question. Let me try that. It should work, but I want to be sure.

Quoted 21 lines
Quoted 21 lines
---
  .../powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb          | 2 ++
  1 file changed, 2 insertions(+)
meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb +2 -0
index f748bd0f..73de93e5 100644
@@ -37,6 +37,8 @@ PACKAGECONFIG[opengl] = ",,,,${GLES_PACKAGES}"
  PACKAGECONFIG[vulkan] = ",,,,${VULKAN_PACKAGES}"
  PACKAGECONFIG[opencl] = ",,,,${OPENCL_PACKAGES}"
 
+DEPENDS:prepend = "${BASE_DEFAULT_DEPS} "
+
  def get_file_list(package_list_var, d):
      file_list = []
      package_list = d.getVar(package_list_var)
Signature · 1 line
2.17.1
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 10 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 7 lines · Denys Dmytriyenko
Quoted 6 lines · Ryan Eatmon via lists.yoctoproject.org

A recent change to oe-core [1], has caused a pile of QA errors during packaging for this binary package.  The effect of the change in oe-core was to remove the dependency on the compiler and other compiler adjacent libraries.  But the binary packages need some of the compiler tools as part of the packaging flow (ie. objdump).

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

Until the above gets reverted, this patch will fix the issue and can be reverted itself once oe-core is fixed.

[1] https://git.openembedded.org/openembedded-core/commit/?h=master&id=d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727

Why not simply reset INHIBIT_DEFAULT_DEPS in the recipe?

Good question.  Let me try that.  It should work, but I want to be sure.

huh... It didn't work...

inherit bin_package

INHIBIT_DEFAULT_DEPS = "0"

That gave the same build errors....

Here is code that is using the variable:

def get_base_dep(d):
if d.getVar('INHIBIT_DEFAULT_DEPS', False):
return ""
return "${BASE_DEFAULT_DEPS}"

Quoted 35 lines
Quoted 8 lines
Quoted 8 lines

---
  .../powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb          | 2 ++

  1 file changed, 2 insertions(+)
Quoted 16 lines
Quoted 11 lines
meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb +0 -1
index f748bd0f..73de93e5 100644
--- 

a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
+++
b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb

meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb +0 -0
@@ -37,6 +37,8 @@ PACKAGECONFIG[opengl] = ",,,,${GLES_PACKAGES}"

  PACKAGECONFIG[vulkan] = ",,,,${VULKAN_PACKAGES}" PACKAGECONFIG[opencl] = ",,,,${OPENCL_PACKAGES}"

meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb +2 -0
+DEPENDS:prepend = "${BASE_DEFAULT_DEPS} "
+
Quoted 5 lines

  def get_file_list(package_list_var, d):
      file_list = []
      package_list = d.getVar(package_list_var)

Signature · 1 line
2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#16897): https://lists.yoctoproject.org/g/meta-ti/message/16897
Mute This Topic: https://lists.yoctoproject.org/mt/101018238/6551054
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/leave/10828724/6551054/1815494134/xyzzy [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#5 lore raw
Quoted 34 lines · Ryan Eatmon
Quoted 11 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 8 lines · Denys Dmytriyenko
Quoted 6 lines · Ryan Eatmon via lists.yoctoproject.org

A recent change to oe-core [1], has caused a pile of QA errors during packaging for this binary package.  The effect of the change in oe-core was to remove the dependency on the compiler and other compiler adjacent libraries.  But the binary packages need some of the compiler tools as part of the packaging flow (ie. objdump).

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

Until the above gets reverted, this patch will fix the issue and can be reverted itself once oe-core is fixed.

[1] https://git.openembedded.org/openembedded-core/commit/?h=master&id=d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727

Why not simply reset INHIBIT_DEFAULT_DEPS in the recipe?

Good question.  Let me try that.  It should work, but I want to be sure.

huh... It didn't work...

inherit bin_package

INHIBIT_DEFAULT_DEPS = "0"

That gave the same build errors....

Quoted 6 lines

Here is code that is using the variable:

def get_base_dep(d):
if d.getVar('INHIBIT_DEFAULT_DEPS', False):
return ""
return "${BASE_DEFAULT_DEPS}"

Ah, right, it doesn't check for the value, just the fact that the variable is defined. Could try unset or d.delVar()... But, revert in OE-Core does make perfect sense. Today is a holiday in the UK, so Richard is out until tomorrow.

Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines

---
  .../powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb          | 2 ++

  1 file changed, 2 insertions(+)
meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb +0 -0
index f748bd0f..73de93e5 100644
@@ -37,6 +37,8 @@ PACKAGECONFIG[opengl] = ",,,,${GLES_PACKAGES}"

  PACKAGECONFIG[vulkan] = ",,,,${VULKAN_PACKAGES}" PACKAGECONFIG[opencl] = ",,,,${OPENCL_PACKAGES}"

meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb +2 -0
+DEPENDS:prepend = "${BASE_DEFAULT_DEPS} "
+

  def get_file_list(package_list_var, d):
      file_list = []
      package_list = d.getVar(package_list_var)

Signature · 1 line
2.17.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

#7 lore raw
Quoted 20 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 17 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 13 lines · Denys Dmytriyenko
Quoted 10 lines · Ryan Eatmon via lists.yoctoproject.org

A recent change to oe-core [1], has caused a pile of QA errors during packaging for this binary package.  The effect of the change in oe-core was to remove the dependency on the compiler and other compiler adjacent libraries.  But the binary packages need some of the compiler tools as part of the packaging flow (ie. objdump).

Until the above gets reverted, this patch will fix the issue and can be reverted itself once oe-core is fixed.

[1] https://git.openembedded.org/openembedded-core/commit/?h=master&id=d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727

Why not simply reset INHIBIT_DEFAULT_DEPS in the recipe?

Quoted 8 lines
Quoted 1 line

Good question.  Let me try that.  It should work, but I want to be sure.

huh...  It didn't work...

inherit bin_package

INHIBIT_DEFAULT_DEPS = "0"

If I set it to "" then it works. Let me test that further and post a v2 tomorrow.

Quoted 54 lines

That gave the same build errors....

Here is code that is using the variable:

def get_base_dep(d):
    if d.getVar('INHIBIT_DEFAULT_DEPS', False):
        return ""
    return "${BASE_DEFAULT_DEPS}"

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

---
  .../powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb          | 2 ++

  1 file changed, 2 insertions(+)
Quoted 21 lines
Quoted 8 lines
Quoted 8 lines
meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb +0 -1
index f748bd0f..73de93e5 100644
--- 

a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
+++
b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb

meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb +0 -0
@@ -37,6 +37,8 @@ PACKAGECONFIG[opengl] = ",,,,${GLES_PACKAGES}"

  PACKAGECONFIG[vulkan] = ",,,,${VULKAN_PACKAGES}"

Quoted 8 lines
Quoted 8 lines

  PACKAGECONFIG[opencl] = ",,,,${OPENCL_PACKAGES}"

meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb +2 -0
+DEPENDS:prepend = "${BASE_DEFAULT_DEPS} "
+

  def get_file_list(package_list_var, d):
      file_list = []
      package_list = d.getVar(package_list_var)

Signature · 1 line
2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#16898): https://lists.yoctoproject.org/g/meta-ti/message/16898
Mute This Topic: https://lists.yoctoproject.org/mt/101018238/6551054
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/leave/10828724/6551054/1815494134/xyzzy [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS