checkpatch: stop complaining about tags suggested/tested by syzkaller
PATCH 1/1 checkpatch: stop complaining about tags suggested/tested by syzkaller
If you submit a testing request to syzkaller it may reply with:
syzbot has tested the proposed patch and the reproducer did not \
trigger any issue:
Checkpatch is ok with Reported-by tags, but complains about Reported-and-tested-by tags:
WARNING: Possible unwrapped commit description (prefer a maximum 75 \
chars per line)
#48:
Adding the new tag to signature_tags removes this warning.
--- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/checkpatch.pl +2 -1
@@ -615,6 +615,7 @@ our $signature_tags = qr{(?xi: Tested-by:| Reviewed-by:| Reported-by:| + Reported-and-tested-by:| Suggested-by:| To:| Cc:
@@ -709,7 +710,7 @@ sub find_standard_signature { my ($sign_off) = @_; my @standard_signature_tags = ( 'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:', - 'Reviewed-by:', 'Reported-by:', 'Suggested-by:' + 'Reviewed-by:', 'Reported-by:', 'Reported-and-tested-by:', 'Suggested-by:' ); foreach my $signature (@standard_signature_tags) { return $signature if (get_edit_distance($sign_off, $signature) <= 2);
Signature · 6 lines
2.39.3 _______________________________________________ Linux-kernel-mentees mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Quoted 46 lines · Andrew Kanner
If you submit a testing request to syzkaller it may reply with:
syzbot has tested the proposed patch and the reproducer did not \
trigger any issue:Reported-and-tested-by [email protected]Checkpatch is ok with Reported-by tags, but complains about Reported-and-tested-by tags:
WARNING: Possible unwrapped commit description (prefer a maximum 75 \
chars per line)
#48:Reported-and-tested-by [email protected]Adding the new tag to
signature_tagsremoves this warning.Signed-off-by Andrew Kanner <[email protected]>--- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)scripts/checkpatch.pl +2
-1@@ -615,6 +615,7 @@ our $signature_tags = qr{(?xi: Tested-by:| Reviewed-by:| Reported-by:| + Reported-and-tested-by:| Suggested-by:| To:| Cc:@@ -709,7 +710,7 @@ sub find_standard_signature { my ($sign_off) = @_; my @standard_signature_tags = ( 'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:', - 'Reviewed-by:', 'Reported-by:', 'Suggested-by:' + 'Reviewed-by:', 'Reported-by:', 'Reported-and-tested-by:', 'Suggested-by:' ); foreach my $signature (@standard_signature_tags) { return $signature if (get_edit_distance($sign_off, $signature) <= 2);Signature · 1 line
2.39.3
Kindly reminder.
Please let me know if there're any objections.
Signature · 5 lines
Andrew Kanner _______________________________________________ Linux-kernel-mentees mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees