Skip to contentSkip to conversation

FEMTOPHY REFGEN regulator

PATCH In review Konrad Dybcio 3 participants 6 messages Aug 30, 2023 – Aug 31, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover FEMTOPHY REFGEN regulator

The FEMTOPHY gets a reference voltage from the REFGEN regulator. Make Linux aware of that.

---
Konrad Dybcio (2):
dt-bindings: phy: qcom,usb-snps-femto-v2: Add REFGEN regulator
phy: qcom-snps-femto-v2: Add REFGEN supply

 Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 3 +++
 drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c                     | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

---
base-commit: 56585460cc2ec44fc5d66924f0a116f57080f0dc
change-id: 20230830-topic-refgenphy-8c2a78bc44e7

Best regards,

Signature · 7 lines
Konrad Dybcio <[email protected]>


-- 
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy
#1 lore raw

PATCH 1/2 dt-bindings: phy: qcom,usb-snps-femto-v2: Add REFGEN regulator

The HSPHY is (or at least can be) one of the users of the reference voltage generating regulator. Ensure that dependency is described properly.

---
 Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml +3 -0
index 0f200e3f97a9..e895b6c4ee49 100644
@@ -53,6 +53,9 @@ properties:
     items:
       - description: PHY core reset
 
+  refgen-supply:
+    description: phandle to the REFGEN regulator node
+
   vdda-pll-supply:
     description: phandle to the regulator VDD supply node.
 
Signature · 7 lines
2.42.0


-- 
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy
Acked-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] dt-bindings: phy: qcom,usb-snps-femto-v2: Add REFGEN regulator

Quoted 14 lines · Konrad Dybcio

The HSPHY is (or at least can be) one of the users of the reference voltage generating regulator. Ensure that dependency is described properly.

---
 Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml +0 -0
index 0f200e3f97a9..e895b6c4ee49 100644

Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml properties: · line 60

Quoted 8 lines
Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml +3 -0
@@ -53,6 +53,9 @@ properties:
     items:
       - description: PHY core reset
 
+  refgen-supply:
+    description: phandle to the REFGEN regulator node
+
   vdda-pll-supply:
     description: phandle to the regulator VDD supply node.

My OCD isn't keen on the inconsistent full stop usage but that's a nitpick of the context, not of the patch itself.

Thanks,
Conor,

Quoted 5 lines
Signature · 2 lines
-- 
2.42.0
maintainer
#3 lore raw

Re: [PATCH 1/2] dt-bindings: phy: qcom,usb-snps-femto-v2: Add REFGEN regulator

In reply to Konrad Dybcio
Quoted 14 lines · Konrad Dybcio

The HSPHY is (or at least can be) one of the users of the reference voltage generating regulator. Ensure that dependency is described properly.

---
 Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml +0 -0
index 0f200e3f97a9..e895b6c4ee49 100644

Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml properties: · line 57

Quoted 5 lines
Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml +2 -0
@@ -53,6 +53,9 @@ properties:
     items:
       - description: PHY core reset
 
+  refgen-supply:
+    description: phandle to the REFGEN regulator node

Supply names are local to the device (sink name), but this seems to be named based on the supply source. Maybe hard to do if all internal stuff. What is this supplying and what's the source if not REFGEN?

Quoted 8 lines
Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml +1 -0
+
   vdda-pll-supply:
     description: phandle to the regulator VDD supply node.
 
Signature · 2 lines
-- 
2.42.0
#4 lore raw

Re: [PATCH 1/2] dt-bindings: phy: qcom,usb-snps-femto-v2: Add REFGEN regulator

Quoted 18 lines · Rob Herring
Quoted 17 lines · Konrad Dybcio

The HSPHY is (or at least can be) one of the users of the reference voltage generating regulator. Ensure that dependency is described properly.

---
 Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml +0 -0
index 0f200e3f97a9..e895b6c4ee49 100644
@@ -53,6 +53,9 @@ properties:
     items:
       - description: PHY core reset
 
Quoted 6 lines

Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml properties: · line 57

Quoted 2 lines
Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml +2 -0
+  refgen-supply:
+    description: phandle to the REFGEN regulator node

Supply names are local to the device (sink name), but this seems to be named based on the supply source. Maybe hard to do if all internal stuff. What is this supplying and what's the source if not REFGEN?

I don't think I have anything that would answer this question.. Though I would not at all be surprised if Qualcomm also called the input "refgen"..

Maybe Bjorn or Dmitry would know.

Konrad

#5 lore raw

PATCH 2/2 phy: qcom-snps-femto-v2: Add REFGEN supply

In reply to Konrad Dybcio

The HSPHY is (or at least can be) one of the users of the reference voltage generating regulator.

Add it to the regulator bulk data.

---
 drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c +1 -1
index eb0b0f61d98e..2bc9aeef26f9 100644
@@ -79,7 +79,7 @@
 #define LS_FS_OUTPUT_IMPEDANCE_MASK		GENMASK(3, 0)
 
 static const char * const qcom_snps_hsphy_vreg_names[] = {
-	"vdda-pll", "vdda33", "vdda18",
+	"vdda-pll", "vdda33", "vdda18", "refgen",
 };
 
 #define SNPS_HS_NUM_VREGS		ARRAY_SIZE(qcom_snps_hsphy_vreg_names)
Signature · 7 lines
2.42.0


-- 
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy