am33xx: ignore return value from usb_ether_init()
Subsystems (3)
PATCH 1/1 am33xx: ignore return value from usb_ether_init()
In 2cb43ef1c223 ("usb: ether: Fix error handling in usb_ether_init") the error handling of usb_ether_init() was changed. Not a single other call site of this function checks its return value, therefore follow suit in the am33xx code.
Do not cause the boot to halt if the usb gadget ethernet initialization fails:
initcall sequence 9ffdbd84 failed at call 808024b9 (err=-19) ### ERROR ### Please RESET the board ###
--- arch/arm/mach-omap2/am33xx/board.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
arch/arm/mach-omap2/am33xx/board.c +1 -5
@@ -270,11 +270,7 @@ int arch_misc_init(void)return ret;#if defined(CONFIG_DM_ETH ) && defined(CONFIG_USB_ETHER ) - ret =usb_ether_init (); -if (ret) { -pr_err ("USB ether init failed\n" ); -return ret; - } +usb_ether_init ();#endif return 0 ;
Signature · 1 line
2.41.0.327.gaa9166bcc0ba
Hello,
Quoted 3 lines · Trevor Woerner
In
2cb43ef1c223("usb: ether: Fix error handling inusb_ether_init") the error handling ofusb_ether_init()was changed. Not a single other call site of this function checks its return value, therefore follow suit in the am33xx code.
then there is the question what point is there in having a return value in this function at all.
Anyway, it's fine to not check the return value in the caller if there is no use for the error.
Quoted 31 lines
Do not cause the boot to halt if the usb gadget ethernet initialization fails:
initcall sequence 9ffdbd84 failed at call 808024b9 (err=-19) ### ERROR ### Please RESET the board ###Signed-off-by Trevor Woerner <[email protected]>--- arch/arm/mach-omap2/am33xx/board.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)arch/arm/mach-omap2/am33xx/board.c +1
-5@@ -270,11 +270,7 @@ int arch_misc_init(void)return ret;#if defined(CONFIG_DM_ETH ) && defined(CONFIG_USB_ETHER ) - ret =usb_ether_init (); -if (ret) { -pr_err ("USB ether init failed\n" ); -return ret; - } +usb_ether_init ();#endif return 0 ;Signature · 1 line
2.41.0.327.gaa9166bcc0ba
Can this get added to the next release? I don't see it in -next.
Quoted 52 lines · Michal Suchánek
Hello,
Quoted 1 line · Trevor Woerner
In
2cb43ef1c223("usb: ether: Fix error handling inusb_ether_init") theerror
Quoted 1 line
handling of
usb_ether_init()was changed. Not a single other call siteof this
Quoted 1 line
function checks its return value, therefore follow suit in the am33xx
code.
then there is the question what point is there in having a return value in this function at all.
Anyway, it's fine to not check the return value in the caller if there is no use for the error.
Reviewed-by Michal Suchánek <[email protected]>Quoted 2 lines
Do not cause the boot to halt if the usb gadget ethernet initialization
fails:
Review
Quoted 10 lines
initcall sequence
9ffdbd84failed at call808024b9(err=-19) ### ERROR ### Please RESET the board ###Signed-off-by Trevor Woerner <[email protected]>--- arch/arm/mach-omap2/am33xx/board.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)(quoted diff) +0
-0
b/arch/arm/mach-omap2/am33xx/board.cQuoted 19 lines
index
ecc0a592e993..8f772310a1a7100644arch/arm/mach-omap2/am33xx/board.c +1
-6@@ -270,11 +270,7 @@ int arch_misc_init(void)return ret;#if defined(CONFIG_DM_ETH ) && defined(CONFIG_USB_ETHER ) - ret =usb_ether_init (); -if (ret) { -pr_err ("USB ether init failed\n" ); -return ret; - } +usb_ether_init ();#endif return 0 ; --2.41.0.327.gaa9166bcc0ba
Quoted 1 line · Trevor Woerner
Can this get added to the next release? I don't see it in -next.
I was going to pick this up for v2024.01 (i.e. the next branch) soon'ish.
Quoted 55 lines · Michal Suchánek
Quoted 53 lines
Hello,
Quoted 1 line · Trevor Woerner
In
2cb43ef1c223("usb: ether: Fix error handling inusb_ether_init") theerror
Quoted 1 line
handling of
usb_ether_init()was changed. Not a single other call siteof this
Quoted 1 line
function checks its return value, therefore follow suit in the am33xx
code.
then there is the question what point is there in having a return value in this function at all.
Anyway, it's fine to not check the return value in the caller if there is no use for the error.
Reviewed-by Michal Suchánek <[email protected]>Quoted 2 lines
Do not cause the boot to halt if the usb gadget ethernet initialization
fails:
Review
Quoted 10 lines
initcall sequence
9ffdbd84failed at call808024b9(err=-19) ### ERROR ### Please RESET the board ###Signed-off-by Trevor Woerner <[email protected]>--- arch/arm/mach-omap2/am33xx/board.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)(quoted diff) +0
-0
b/arch/arm/mach-omap2/am33xx/board.cQuoted 19 lines
index
ecc0a592e993..8f772310a1a7100644arch/arm/mach-omap2/am33xx/board.c +1
-6@@ -270,11 +270,7 @@ int arch_misc_init(void)return ret;#if defined(CONFIG_DM_ETH ) && defined(CONFIG_USB_ETHER ) - ret =usb_ether_init (); -if (ret) { -pr_err ("USB ether init failed\n" ); -return ret; - } +usb_ether_init ();#endif return 0 ; --2.41.0.327.gaa9166bcc0ba
Signature · 1 line
Tom
Quoted 7 lines · Tom Rini
Quoted 1 line · Trevor Woerner
Can this get added to the next release? I don't see it in -next.
I was going to pick this up for v2024.01 (i.e. the next branch) soon'ish.
Awesome, thanks! :-)
Quoted 11 lines · Trevor Woerner
In
2cb43ef1c223("usb: ether: Fix error handling inusb_ether_init") the error handling ofusb_ether_init()was changed. Not a single other call site of this function checks its return value, therefore follow suit in the am33xx code.Do not cause the boot to halt if the usb gadget ethernet initialization fails:
initcall sequence 9ffdbd84 failed at call 808024b9 (err=-19) ### ERROR ### Please RESET the board ###Signed-off-by Trevor Woerner <[email protected]>Reviewed-by Michal Suchánek <[email protected]>
Applied to u-boot/next, thanks!
Signature · 1 line
Tom