RDMA/nldev: Add support for reporting ipoib netdev
PATCH 1/1 RDMA/nldev: Add support for reporting ipoib netdev
This patch adds support for reporting the ipoib net device for a given RDMA device by calling ib_get_net_dev_by_params() when filling the port's info.
$ rdma link show mlx5_0/1 link mlx5_0/1 subnet_prefix fe80:0000:0000:0000 lid 66 sm_lid 3 lmc 0 state ACTIVE physical_state LINK_UP netdev ibp196s0f0
--- drivers/infiniband/core/nldev.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
drivers/infiniband/core/nldev.c +19 -0
@@ -308,6 +308,7 @@ static int fill_port_info(struct sk_buff *msg, struct ib_device *device, u32 port, const struct net *net) { + struct net_device *ipoib_netdev = NULL;struct net_device *netdev =NULL ;struct ib_port_attr attr;int ret;
@@ -340,6 +341,21 @@ static int fill_port_info(struct sk_buff *msg,return -EMSGSIZE ;if (nla_put_u8 (msg,RDMA_NLDEV_ATTR_LMC , attr.lmc))return -EMSGSIZE ; + ipoib_netdev =ib_get_net_dev_by_params (device, port, +IB_DEFAULT_PKEY_FULL , +NULL ,NULL ); +if (ipoib_netdev) { + ret =nla_put_u32 (msg, +RDMA_NLDEV_ATTR_NDEV_INDEX , + ipoib_netdev->ifindex); +if (ret) + goto out; + ret =nla_put_string (msg, +RDMA_NLDEV_ATTR_NDEV_NAME , + ipoib_netdev->name); +if (ret) + goto out; + } }if (nla_put_u8 (msg,RDMA_NLDEV_ATTR_PORT_STATE , attr.state))return -EMSGSIZE ;
@@ -357,6 +373,9 @@ static int fill_port_info(struct sk_buff *msg, } out: +if (ipoib_netdev) +dev_put (ipoib_netdev); +if (netdev)dev_put (netdev);return ret;
Signature · 1 line
2.41.0
Quoted 4 lines · Kamal Heib
This patch adds support for reporting the ipoib net device for a given RDMA device by calling
ib_get_net_dev_by_params()when filling the port's info.
Quoted 8 lines
$ rdma link show mlx5_0/1 link mlx5_0/1 subnet_prefix fe80:0000:0000:0000 lid 66 sm_lid 3 lmc 0 state ACTIVE physical_state LINK_UP netdev ibp196s0f0Signed-off-by Kamal Heib <[email protected]>--- drivers/infiniband/core/nldev.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
Are we sure we want to do this? How does it work with namespaces?
drivers/infiniband/core/nldev.c static int fill_port_info(struct sk_buff *msg, · line 346
Quoted 7 lines
drivers/infiniband/core/nldev.c +3
-0@@ -340,6 +341,21 @@ static int fill_port_info(struct sk_buff *msg,return -EMSGSIZE ;if (nla_put_u8 (msg,RDMA_NLDEV_ATTR_LMC , attr.lmc))return -EMSGSIZE ; + ipoib_netdev =ib_get_net_dev_by_params (device, port, +IB_DEFAULT_PKEY_FULL , +NULL ,NULL );
And it doesn't work at all for non-default ipoib interfaces?
Jason
Quoted 9 lines · Jason Gunthorpe
Quoted 8 lines · Kamal Heib
This patch adds support for reporting the ipoib net device for a given RDMA device by calling
ib_get_net_dev_by_params()when filling the port's info.$ rdma link show mlx5_0/1 link mlx5_0/1 subnet_prefix fe80:0000:0000:0000 lid 66 sm_lid 3 lmc 0 state ACTIVE physical_state LINK_UP netdev ibp196s0f0
Quoted 6 lines
Quoted 4 lines
Signed-off-by Kamal Heib <[email protected]>--- drivers/infiniband/core/nldev.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)Are we sure we want to do this? How does it work with namespaces?
You are right, I'll fix it.
Quoted 11 lines
drivers/infiniband/core/nldev.c static int fill_port_info(struct sk_buff *msg, · line 346
Quoted 8 lines
drivers/infiniband/core/nldev.c +3
-0@@ -340,6 +341,21 @@ static int fill_port_info(struct sk_buff *msg,return -EMSGSIZE ;if (nla_put_u8 (msg,RDMA_NLDEV_ATTR_LMC , attr.lmc))return -EMSGSIZE ; + ipoib_netdev =ib_get_net_dev_by_params (device, port, +IB_DEFAULT_PKEY_FULL , +NULL ,NULL );And it doesn't work at all for non-default ipoib interfaces?
I'll fix it.
Thanks,
Kamal
Quoted 2 lines
Jason