Skip to contentSkip to conversation

arm64: dts: imx8mp: Describe VDD_ARM run and standby voltage for DH i.MX8M Plus DHCOM SoM

PATCH Applied Marek Vasut 3 participants 8 messages Aug 31, 2023 – Oct 12, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/4 arm64: dts: imx8mp: Describe VDD_ARM run and standby voltage for DH i.MX8M Plus DHCOM SoM

Describe VDD_ARM (BUCK2) run and standby voltage in DT.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi +2 -0
index cb1953d14aa90..1644b56c3953d 100644
@@ -293,6 +293,8 @@ buck1: BUCK1 {	/* VDD_SOC (dual-phase with BUCK3) */
 			};
 
 			buck2: BUCK2 {	/* VDD_ARM */
+				nxp,dvs-run-voltage = <950000>;
+				nxp,dvs-standby-voltage = <850000>;
 				regulator-min-microvolt = <850000>;
 				regulator-max-microvolt = <1000000>;
 				regulator-ramp-delay = <3125>;
Signature · 1 line
2.40.1
#1 lore raw

PATCH 2/4 arm64: dts: imx8mp: Fix property indent on DH i.MX8M Plus DHCOM PDK3

Fix indent to use tab indent. No functional change.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts +4 -4
index 31d85d5871c91..5d1eb3767bd34 100644
@@ -225,10 +225,10 @@ ptn5150_out_ep: endpoint {
 			};
 
 			power-sensor@40 {
-			    compatible = "ti,ina238";
-			    reg = <0x40>;
-			    shunt-resistor = <20000>;	/* 0.02 R */
-			    ti,shunt-gain = <1>;	/* Drop cca. 40mV */
+				compatible = "ti,ina238";
+				reg = <0x40>;
+				shunt-resistor = <20000>;	/* 0.02 R */
+				ti,shunt-gain = <1>;	/* Drop cca. 40mV */
 			};
 
 			eeprom_board: eeprom@54 {
Signature · 1 line
2.40.1
#2 lore raw

PATCH 3/4 arm64: dts: imx8mp: Switch WiFI enable signal to mmc-pwrseq-simple on i.MX8MP DHCOM SoM

In reply to Marek Vasut

The reset-gpio is connected to WL_REG_EN signal of the WiFi MAC, the mmc-pwrseq-simple driver is better suited to operate this signal as it is tied to the slot instead of the MAC, and it can enable the MAC before the brcmfmac driver binds to it. Make use of the MMC power sequencer.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi +6 -1
index 1644b56c3953d..df43741d04bb9 100644
@@ -57,6 +57,11 @@ reg_vdd_3p3v_awo: regulator-vdd-3p3v-awo {	/* VDD_3V3_AWO */
 		regulator-max-microvolt = <3300000>;
 		regulator-name = "VDD_3P3V_AWO";
 	};
+
+	wlan_pwrseq: wifi-pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
+	};
 };
 
 &A53_0 {
@@ -543,6 +548,7 @@ &usdhc1 {
 	pinctrl-0 = <&pinctrl_usdhc1>;
 	pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
 	pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+	mmc-pwrseq = <&wlan_pwrseq>;
 	vmmc-supply = <&buck4>;
 	bus-width = <4>;
 	non-removable;
@@ -561,7 +567,6 @@ brcmf: bcrmf@1 {	/* muRata 2AE */
 		 * connected to the SoC, but can be connected on to
 		 * SoC pin on the carrier board.
 		 */
-		reset-gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
 	};
 };
 
Signature · 1 line
2.40.1
#3 lore raw

PATCH 4/4 arm64: dts: imx8mp: Add UART1 and RTC wake up source on DH i.MX8M Plus DHCOM SoM

In reply to Marek Vasut

Turn Console UART1 and dedicated RTC into wake up sources, to make it possible to wake on UART and RTC alarm.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi +2 -0
index df43741d04bb9..4582a0bbe3726 100644
@@ -414,6 +414,7 @@ rv3032: rtc@51 {
 		interrupts-extended = <&gpio5 5 IRQ_TYPE_LEVEL_LOW>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_rtc>;
+		wakeup-source;
 	};
 
 	eeprom1: eeprom@53 {	/* EEPROM with FEC MAC address */
@@ -470,6 +471,7 @@ &uart1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart1>;
 	status = "okay";
+	wakeup-source;
 };
 
 &uart2 {
Signature · 1 line
2.40.1
#4 lore raw
In reply to Marek Vasut

Hi Marek,

Quoted 28 lines · Marek Vasut

Describe VDD_ARM (BUCK2) run and standby voltage in DT.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi +0 -0
index cb1953d14aa90..1644b56c3953d 100644

arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ · line 296

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi +1 -0
@@ -293,6 +293,8 @@ buck1: BUCK1 {	/* VDD_SOC (dual-phase with BUCK3) */
 			};
 
 			buck2: BUCK2 {	/* VDD_ARM */
+				nxp,dvs-run-voltage = <950000>;

Why do we need to set the "nxp,dvs-run-voltage"? If I read the driver correctly, then nxp,dvs-run-voltage and regulator-min/max-microvolt are touching the same register.

Regards,
Marco

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi +1 -0
+				nxp,dvs-standby-voltage = <850000>;
 				regulator-min-microvolt = <850000>;
 				regulator-max-microvolt = <1000000>;
 				regulator-ramp-delay = <3125>;
Signature · 1 line
2.40.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw
Quoted 1 line · Marco Felsch

Hi Marek,

Hi,

Quoted 31 lines · Marek Vasut
Quoted 30 lines

Describe VDD_ARM (BUCK2) run and standby voltage in DT.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
  arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi | 2 ++
  1 file changed, 2 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi +0 -0
index cb1953d14aa90..1644b56c3953d 100644
@@ -293,6 +293,8 @@ buck1: BUCK1 {	/* VDD_SOC (dual-phase with BUCK3) */
  			};
 
Quoted 6 lines

arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ · line 296

Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi +1 -0
  			buck2: BUCK2 {	/* VDD_ARM */
+				nxp,dvs-run-voltage = <950000>;

Why do we need to set the "nxp,dvs-run-voltage"? If I read the driver correctly, then nxp,dvs-run-voltage and regulator-min/max-microvolt are touching the same register.

My understanding is that the nxp,dvs-run-voltage selects the default regulator voltage which is configured early on once the regulator is detected in DT (see of_parse_cb callback in the PCA9450 regulator driver) and may be higher than regulator-min-microvolt, while later on DVFS can adjust the regulator in range of regulator-min-microvolt to regulator-max-microvolt .

Quoted 3 lines
Quoted 3 lines
arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi +1 -0
+				nxp,dvs-standby-voltage = <850000>;
  				regulator-min-microvolt = <850000>;
  				regulator-max-microvolt = <1000000>;

[...]

Reviewed-by
#6 lore raw
Quoted 42 lines · Marek Vasut
Quoted 1 line · Marco Felsch

Hi Marek,

Hi,

Quoted 24 lines · Marek Vasut
Quoted 23 lines

Describe VDD_ARM (BUCK2) run and standby voltage in DT.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
  arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi | 2 ++
  1 file changed, 2 insertions(+)
Quoted 12 lines

arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ · line 295

Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi +1 -0
index cb1953d14aa90..1644b56c3953d 100644
@@ -293,6 +293,8 @@ buck1: BUCK1 {	/* VDD_SOC (dual-phase with BUCK3) */
  			};
  			buck2: BUCK2 {	/* VDD_ARM */
+				nxp,dvs-run-voltage = <950000>;

Why do we need to set the "nxp,dvs-run-voltage"? If I read the driver correctly, then nxp,dvs-run-voltage and regulator-min/max-microvolt are touching the same register.

Quoted 6 lines

My understanding is that the nxp,dvs-run-voltage selects the default regulator voltage which is configured early on once the regulator is detected in DT (see of_parse_cb callback in the PCA9450 regulator driver) and may be higher than regulator-min-microvolt, while later on DVFS can adjust the regulator in range of regulator-min-microvolt to regulator-max-microvolt .

Right, albeit I think that the bootloader already did the initialization once. Anyway the change lgtm:

Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi +1 -0
+				nxp,dvs-standby-voltage = <850000>;
  				regulator-min-microvolt = <850000>;
  				regulator-max-microvolt = <1000000>;

[...]