Skip to contentSkip to conversation

arm64: dts: imx8mp: Simplify USB C on DH i.MX8M Plus DHCOM PDK3

PATCH Applied Marek Vasut 2 participants 2 messages Aug 31, 2023 – Sep 25, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: imx8mp: Simplify USB C on DH i.MX8M Plus DHCOM PDK3

Remove the connector as well as all the links and only connect the PTN5150 with xHCI controller. This is sufficient to implement the role switching.

Furthermore, this makes resume work without hanging. Without this patch, the platform would hang on resume of 'connector'.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 .../boot/dts/freescale/imx8mp-dhcom-pdk3.dts  | 58 ++-----------------
 1 file changed, 4 insertions(+), 54 deletions(-)
arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts +4 -54
index a5d74b06f732d..b749e28e5ede5 100644
@@ -35,33 +35,6 @@ clk_xtal25: clock-xtal25 {
 		clock-frequency = <25000000>;
 	};
 
-	connector {
-		compatible = "usb-c-connector";
-		label = "USB-C";
-		data-role = "dual";
-
-		ports {
-			#address-cells = <1>;
-			#size-cells = <0>;
-
-			port@0 {
-				reg = <0>;
-
-				usb_c_0_hs_ep: endpoint {
-					remote-endpoint = <&dwc3_0_hs_ep>;
-				};
-			};
-
-			port@1 {
-				reg = <1>;
-
-				usb_c_0_ss_ep: endpoint {
-					remote-endpoint = <&ptn5150_in_ep>;
-				};
-			};
-		};
-	};
-
 	gpio-keys {
 		compatible = "gpio-keys";
 
@@ -202,24 +175,10 @@ typec@3d {
 				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_ptn5150>;
 
-				ports {
-					#address-cells = <1>;
-					#size-cells = <0>;
-
-					port@0 {
-						reg = <0>;
-
-						ptn5150_in_ep: endpoint {
-							remote-endpoint = <&usb_c_0_ss_ep>;
-						};
-					};
-
-					port@1 {
-						reg = <1>;
+				port {
 
-						ptn5150_out_ep: endpoint {
-							remote-endpoint = <&dwc3_0_ss_ep>;
-						};
+					ptn5150_out_ep: endpoint {
+						remote-endpoint = <&dwc3_0_ep>;
 					};
 				};
 			};
@@ -306,16 +265,7 @@ &usb_dwc3_0 {
 	usb-role-switch;
 
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		dwc3_0_hs_ep: endpoint@0 {
-			reg = <0>;
-			remote-endpoint = <&usb_c_0_hs_ep>;
-		};
-
-		dwc3_0_ss_ep: endpoint@1 {
-			reg = <1>;
+		dwc3_0_ep: endpoint {
 			remote-endpoint = <&ptn5150_out_ep>;
 		};
 	};
Signature · 1 line
2.40.1
Applied
#1 lore raw
Quoted 8 lines · Marek Vasut

Remove the connector as well as all the links and only connect the PTN5150 with xHCI controller. This is sufficient to implement the role switching.

Furthermore, this makes resume work without hanging. Without this patch, the platform would hang on resume of 'connector'.

Applied, thanks!