Skip to contentSkip to conversation

parisc: shmparam.h: Document aliasing requirements of PA-RISC

PATCH In review [email protected] 2 participants 2 messages Sep 1, 2023 – Sep 4, 2023 PA-RISC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 parisc: shmparam.h: Document aliasing requirements of PA-RISC

From: Helge Deller <[email protected]>

Add some documentation why PA-RISC uses SHMLBA and SHM_COLOUR.

---
 arch/parisc/include/asm/shmparam.h | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
arch/parisc/include/asm/shmparam.h +15 -0
index 74f74e4d35b7..5a95b0f62b87 100644
@@ -2,6 +2,21 @@
 #ifndef _ASMPARISC_SHMPARAM_H
 #define _ASMPARISC_SHMPARAM_H
 
+/*
+ * PA-RISC uses virtually indexed & physically tagged (VIPT) caches
+ * which has strict requirements when two pages to the same physical
+ * address are accessed through different mappings. Read the section
+ * "Address Aliasing" in the arch docs for more detail:
+ * PA-RISC 1.1 (page 3-6):
+ * https://parisc.wiki.kernel.org/images-parisc/6/68/Pa11_acd.pdf
+ * PA-RISC 2.0 (page F-5):
+ * https://parisc.wiki.kernel.org/images-parisc/7/73/Parisc2.0.pdf
+ *
+ * For Linux we allow kernel and userspace to map pages on page size
+ * granularity (SHMLBA) but have to ensure that, if two pages are
+ * mapped to the same physical address, the virtual and physical
+ * addresses modulo SHM_COLOUR are identical.
+ */
 #define SHMLBA	   PAGE_SIZE	/* attach addr a multiple of this */
 #define SHM_COLOUR 0x00400000	/* shared mappings colouring */
 
Signature · 1 line
2.41.0
#1 lore raw
Quoted 24 lines · On 2023-09-01 2:04 a.m., [email protected] wrote:

From: Helge Deller <[email protected]>

Add some documentation why PA-RISC uses SHMLBA and SHM_COLOUR.

---
  arch/parisc/include/asm/shmparam.h | 15 +++++++++++++++
  1 file changed, 15 insertions(+)
arch/parisc/include/asm/shmparam.h +7 -0
index 74f74e4d35b7..5a95b0f62b87 100644
@@ -2,6 +2,21 @@
  #ifndef _ASMPARISC_SHMPARAM_H
  #define _ASMPARISC_SHMPARAM_H
 
+/*
+ * PA-RISC uses virtually indexed & physically tagged (VIPT) caches
+ * which has strict requirements when two pages to the same physical
+ * address are accessed through different mappings. Read the section
+ * "Address Aliasing" in the arch docs for more detail:
+ * PA-RISC 1.1 (page 3-6):
+ * https://parisc.wiki.kernel.org/images-parisc/6/68/Pa11_acd.pdf

arch/parisc/include/asm/shmparam.h line 21

Quoted 10 lines
arch/parisc/include/asm/shmparam.h +8 -0
+ * PA-RISC 2.0 (page F-5):
+ * https://parisc.wiki.kernel.org/images-parisc/7/73/Parisc2.0.pdf
+ *
+ * For Linux we allow kernel and userspace to map pages on page size
+ * granularity (SHMLBA) but have to ensure that, if two pages are
+ * mapped to the same physical address, the virtual and physical
+ * addresses modulo SHM_COLOUR are identical.
+ */
  #define SHMLBA	   PAGE_SIZE	/* attach addr a multiple of this */
  #define SHM_COLOUR 0x00400000	/* shared mappings colouring */

Does SHM_COLOUR need to be exposed to user space?  See the following issue with sysprof:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1021853

Dave

Signature · 1 line
John David Anglin  [email protected]