drivers/of/dynamic.c:935 of_changeset_action() warn: possible memory leak of 'ce'
kernel test robot
build botBCC: [email protected]
CC: [email protected]
CC: [email protected]
TO: Rob Herring <[email protected]>
CC: Geert Uytterhoeven <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 99d99825fc075fd24b60cc9cf0fb1e20b9c16b0f commit: 914d9d831e6126a6e7a92e27fcfaa250671be42c of: dynamic: Refactor action prints to not use "%pOF" inside devtree_lock date: 11 days ago
:::::: branch date: 4 hours ago
:::::: commit date: 11 days ago
config: x86_64-randconfig-161-20230831 (https://download.01.org/0day-ci/archive/20230901/[email protected]/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230901/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/
smatch warnings:drivers/of/dynamic.c:935 of_changeset_action() warn: possible memory leak of 'ce'
vim +/ce +935 drivers/of/dynamic.c
183223770ae862 Gavin Shan 2015-11-05 907
201c910bd6898d Pantelis Antoniou 2014-07-04 908 /**
0290c4ca2536a3 Frank Rowand 2017-10-17 909 * of_changeset_action - Add an action to the tail of the changeset list
201c910bd6898d Pantelis Antoniou 2014-07-04 910 *
201c910bd6898d Pantelis Antoniou 2014-07-04 911 * @ocs: changeset pointer
201c910bd6898d Pantelis Antoniou 2014-07-04 912 * @action: action to perform
201c910bd6898d Pantelis Antoniou 2014-07-04 913 * @np: Pointer to device node
201c910bd6898d Pantelis Antoniou 2014-07-04 914 * @prop: Pointer to property
201c910bd6898d Pantelis Antoniou 2014-07-04 915 *
201c910bd6898d Pantelis Antoniou 2014-07-04 916 * On action being one of:
201c910bd6898d Pantelis Antoniou 2014-07-04 917 * + OF_RECONFIG_ATTACH_NODE
201c910bd6898d Pantelis Antoniou 2014-07-04 918 * + OF_RECONFIG_DETACH_NODE,
201c910bd6898d Pantelis Antoniou 2014-07-04 919 * + OF_RECONFIG_ADD_PROPERTY
201c910bd6898d Pantelis Antoniou 2014-07-04 920 * + OF_RECONFIG_REMOVE_PROPERTY,
201c910bd6898d Pantelis Antoniou 2014-07-04 921 * + OF_RECONFIG_UPDATE_PROPERTY
8c8239c2c1fb82 Rob Herring 2021-03-25 922 *
8c8239c2c1fb82 Rob Herring 2021-03-25 923 * Return: 0 on success, a negative error value in case of an error.
201c910bd6898d Pantelis Antoniou 2014-07-04 924 */
201c910bd6898d Pantelis Antoniou 2014-07-04 925 int of_changeset_action(struct of_changeset *ocs, unsigned long action,
201c910bd6898d Pantelis Antoniou 2014-07-04 926 struct device_node *np, struct property *prop)
201c910bd6898d Pantelis Antoniou 2014-07-04 927 {
201c910bd6898d Pantelis Antoniou 2014-07-04 928 struct of_changeset_entry *ce;
201c910bd6898d Pantelis Antoniou 2014-07-04 929
201c910bd6898d Pantelis Antoniou 2014-07-04 930 ce = kzalloc(sizeof(*ce), GFP_KERNEL);
606ad42aa3b1fe Rob Herring 2016-06-15 931 if (!ce)
201c910bd6898d Pantelis Antoniou 2014-07-04 932 return -ENOMEM;
606ad42aa3b1fe Rob Herring 2016-06-15 933
914d9d831e6126 Rob Herring 2023-08-18 934 if (WARN_ON(action >= ARRAY_SIZE(action_names)))914d9d831e6126 Rob Herring 2023-08-18 @935 return -EINVAL;
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki