Skip to contentSkip to conversation

package/linux-firmware: Add new option for Marvell prestera firmware

PATCH In review Köry Maincent via buildroot 1 participant 2 messages Aug 31, 2023 – Sep 2, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/linux-firmware: Add new option for Marvell prestera firmware

From: Kory Maincent <[email protected]>

Add the Marvell prestera ethernet cards firmwares.

---
 package/linux-firmware/Config.in         | 5 +++++
 package/linux-firmware/linux-firmware.mk | 5 +++++
 2 files changed, 10 insertions(+)
package/linux-firmware/Config.in +5 -0
index 3ae72564cc..402e75c890 100644
@@ -513,6 +513,11 @@ config BR2_PACKAGE_LINUX_FIRMWARE_RTL_8169
 	help
 	  Firmware files for Realtek 8169 gigabit ethernet cards
 
+config BR2_PACKAGE_LINUX_FIRMWARE_MARVELL_PRESTERA
+	bool "Marvell Prestera"
+	help
+	  Firmware files for Marvell Prestera ethernet cards
+
 endmenu
 
 menu "DVB firmware"
package/linux-firmware/linux-firmware.mk +5 -0
index 01718fa1e0..d4850307ca 100644
@@ -616,6 +616,11 @@ LINUX_FIRMWARE_FILES += \
 	rtl_nic/rtl8411-2.fw
 endif
 
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_MARVELL_PRESTERA),y)
+LINUX_FIRMWARE_FILES += \
+	mrvl/prestera/mvsw_prestera_fw*.img
+endif
+
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_XCx000),y)
 LINUX_FIRMWARE_FILES += \
 	dvb-fe-xc4000-1.4.1.fw \
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello Köry,

Quoted 15 lines · On Thu, 31 Aug 2023 10:15:16 +0200 Köry Maincent via buildroot…

From: Kory Maincent <[email protected]>

Add the Marvell prestera ethernet cards firmwares.

---
 package/linux-firmware/Config.in         | 5 +++++
 package/linux-firmware/linux-firmware.mk | 5 +++++
 2 files changed, 10 insertions(+)
package/linux-firmware/Config.in +0 -0
index 3ae72564cc..402e75c890 100644

package/linux-firmware/Config.in config BR2_PACKAGE_LINUX_FIRMWARE_RTL_8169 · line 520

Quoted 8 lines
package/linux-firmware/Config.in +5 -0
@@ -513,6 +513,11 @@ config BR2_PACKAGE_LINUX_FIRMWARE_RTL_8169
 	help
 	  Firmware files for Realtek 8169 gigabit ethernet cards
 
+config BR2_PACKAGE_LINUX_FIRMWARE_MARVELL_PRESTERA
+	bool "Marvell Prestera"
+	help
+	  Firmware files for Marvell Prestera ethernet cards
+

Alphabetic ordering here was not correct so I fixed that up.

package/linux-firmware/Config.in config BR2_PACKAGE_LINUX_FIRMWARE_RTL_8169 · line 523

Quoted 3 lines
package/linux-firmware/Config.in +3 -0
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_MARVELL_PRESTERA),y)
+LINUX_FIRMWARE_FILES += \
+	mrvl/prestera/mvsw_prestera_fw*.img

You forgot the license file here, and adding its hash. I fixed that up as well.

One thing I wondered is:

-rw-r--r--. 1 thomas thomas 17M  4 août  12:33 mvsw_prestera_fw_arm64-v4.1.img
-rwxr-xr-x. 1 thomas thomas 14M  4 août  12:33 mvsw_prestera_fw-v2.0.img
-rwxr-xr-x. 1 thomas thomas 14M  4 août  12:33 mvsw_prestera_fw-v3.0.img
-rw-r--r--. 1 thomas thomas 15M  4 août  12:33 mvsw_prestera_fw-v4.0.img
-rw-r--r--. 1 thomas thomas 15M  4 août  12:33 mvsw_prestera_fw-v4.1.img

i.e, each FW file is ~15 MB, but only one will actually be loaded by the driver. Not sure if this warrants a Config.in for each FW version, or if we just let people remove the firmware files they don't use in a post-build script.

Anyway, I applied your patch to next, with the fixes described above.

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot