Skip to contentSkip to conversation

Revert "fuse: Apply flags2 only when userspace set the FUSE_INIT_EXT"

PATCH Superseded André Draszik 2 participants 2 messages Sep 4, 2023

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "fuse: Apply flags2 only when userspace set the FUSE_INIT_EXT"

From: André Draszik <[email protected]>

This reverts commit 3066ff93476c35679cb07a97cce37d9bb07632ff.

This patch breaks all existing userspace by requiring updates as mentioned in the commit message, which is not allowed.

Revert to restore compatibility with existing userspace implementations.

---
 fs/fuse/inode.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
fs/fuse/inode.c +1 -4
index 549358ffea8b..0b966b0e0962 100644
@@ -1132,10 +1132,7 @@ static void process_init_reply(struct fuse_mount *fm, struct fuse_args *args,
 		process_init_limits(fc, arg);
 
 		if (arg->minor >= 6) {
-			u64 flags = arg->flags;
-
-			if (flags & FUSE_INIT_EXT)
-				flags |= (u64) arg->flags2 << 32;
+			u64 flags = arg->flags | (u64) arg->flags2 << 32;
 
 			ra_pages = arg->max_readahead / PAGE_SIZE;
 			if (flags & FUSE_ASYNC_READ)
Signature · 1 line
2.40.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · André Draszik

From: André Draszik <[email protected]>

This reverts commit 3066ff93476c35679cb07a97cce37d9bb07632ff.

This patch breaks all existing userspace by requiring updates as mentioned in the commit message, which is not allowed.

Quoted 8 lines

Revert to restore compatibility with existing userspace implementations.

---
 fs/fuse/inode.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

You forgot to cc: the original author of this change :(

With that, feel free to add:

thanks,

greg k-h