Skip to contentSkip to conversation

dt-bindings: rtc: pcf8523: Convert to YAML

PATCH Superseded Fabio Estevam 2 participants 2 messages Sep 5, 2023

Subsystems (2)
Device tree bindings Real time clock (RTC)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 dt-bindings: rtc: pcf8523: Convert to YAML

From: Fabio Estevam <[email protected]>

Convert the PCF8523 bindings from text format to YAML.

The YAML format is preferred as it allows validation.

Signed-off-by Fabio Estevam <[email protected]>
---
 .../devicetree/bindings/rtc/nxp,pcf8523.txt   | 18 -------
 .../devicetree/bindings/rtc/nxp,pcf8523.yaml  | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 18 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8523.yaml
Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt deleted +0 -18
deleted file mode 100644
index 0b1080c60f63..000000000000
@@ -1,18 +0,0 @@
-* NXP PCF8523 Real Time Clock
-
-Required properties:
-- compatible: Should contain "nxp,pcf8523".
-- reg: I2C address for chip.
-
-Optional property:
-- quartz-load-femtofarads: The capacitive load of the quartz(x-tal),
-  expressed in femto Farad (fF). Valid values are 7000 and 12500.
-  Default value (if no value is specified) is 12500fF.
-
-Example:
-
-pcf8523: rtc@68 {
-	compatible = "nxp,pcf8523";
-	reg = <0x68>;
-	quartz-load-femtofarads = <7000>;
-};
Documentation/devicetree/bindings/rtc/nxp,pcf8523.yaml new file +48 -0

48 lines not on this page · raw message

Signature · 1 line
2.34.1
#1 lore raw
Quoted 6 lines · Fabio Estevam
Documentation/devicetree/bindings/rtc/nxp,pcf8523.yaml new file +6 -0
+allOf:
+  - $ref: rtc.yaml#
+
+properties:
+  compatible:
+    const: nxp,pcf8523

Documentation/devicetree/bindings/rtc/nxp,pcf8523.yaml line 27

Quoted 10 lines
Documentation/devicetree/bindings/rtc/nxp,pcf8523.yaml new file +10 -0
+
+  reg:
+    maxItems: 1
+
+  quartz-load-femtofarads:
+    description:
+      The capacitive load of the crystal, expressed in femto Farad (fF).
+      Valid values are 7000 and 12500. The default value when this property
+      is absent is 12500fF.
+    enum: [ 7000, 12500 ]

default:
(original binding had it, wasn't it true?)

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+  wakeup-source: true

If there is going to be new version:

You can drop it and switch to unevaluatedProperties: false later.

Best regards,
Krzysztof