perf completion: Restrict completion of events to events
Ian Rogers
reviewerPATCH 1/3 perf completion: Restrict completion of events to events
perf list will list libpfm4 events and metrics which aren't valid options to the '-e' option. Restrict the events gathered so that invalid ones aren't shown.
Before:
$ perf stat -e <tab><tab> Display all 633 possibilities? (y or n)
After:
$ perf stat -e <tab><tab> Display all 375 possibilities? (y or n)
--- tools/perf/perf-completion.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/perf-completion.sh +1 -1
@@ -164,7 +164,7 @@ __perf_main () $prev_skip_opts == @(record|stat|top) ]]; then local cur1=${COMP_WORDS[COMP_CWORD]} - local raw_evts=$($cmd list --raw-dump) + local raw_evts=$($cmd list --raw-dump hw sw cache tracepoint pmu sdt) local arr s tmp result cpu_evts # aarch64 doesn't have /sys/bus/event_source/devices/cpu/events
Signature · 1 line
2.42.0.283.g2d96d420d3-goog
Ian Rogers
reviewerPATCH 2/3 perf completion: Support completion of libpfm4 events
Use perf list --raw-dump pfm to support completion of libpfm4 events.
--- tools/perf/perf-completion.sh | 4 ++++ 1 file changed, 4 insertions(+)
tools/perf/perf-completion.sh +4 -0
@@ -198,6 +198,10 @@ __perf_main () else __perfcomp_colon "$evts" "$cur1" fi + elif [[ $prev == @("--pfm-events") && + $prev_skip_opts == @(record|stat|top) ]]; then + local evts=$($cmd list --raw-dump pfm) + __perfcomp "$evts" "$cur" else # List subcommands for perf commands if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched|
Signature · 1 line
2.42.0.283.g2d96d420d3-goog
Re: [PATCH v1 2/3] perf completion: Support completion of libpfm4 events
Quoted 4 lines · Ian Rogers
Use
perf list --raw-dump pfmto support completion of libpfm4 events.Signed-off-by Ian Rogers <[email protected]>
Thanks,
Namhyung
Quoted 22 lines
--- tools/perf/perf-completion.sh | 4 ++++ 1 file changed, 4 insertions(+)tools/perf/perf-completion.sh +4
-1@@ -198,6 +198,10 @@ __perf_main () else __perfcomp_colon "$evts" "$cur1" fi + elif [[ $prev == @("--pfm-events") && + $prev_skip_opts == @(record|stat|top) ]]; then + local evts=$($cmd list --raw-dump pfm) + __perfcomp "$evts" "$cur" else # List subcommands for perf commands if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched| --2.42.0.283.g2d96d420d3-goog
Ian Rogers
reviewerPATCH 3/3 perf completion: Support completion of metrics/metricgroups
In reply to Ian RogersAllow metrics to expand for -M or --metrics options.
--- tools/perf/perf-completion.sh | 4 ++++ 1 file changed, 4 insertions(+)
tools/perf/perf-completion.sh +4 -0
@@ -202,6 +202,10 @@ __perf_main () $prev_skip_opts == @(record|stat|top) ]]; then local evts=$($cmd list --raw-dump pfm) __perfcomp "$evts" "$cur" + elif [[ $prev == @("-M"|"--metrics") && + $prev_skip_opts == @(stat) ]]; then + local metrics=$($cmd list --raw-dump metric metricgroup) + __perfcomp "$metrics" "$cur" else # List subcommands for perf commands if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched|
Signature · 1 line
2.42.0.283.g2d96d420d3-goog
Re: [PATCH v1 3/3] perf completion: Support completion of metrics/metricgroups
Quoted 4 lines · Ian Rogers
Allow metrics to expand for -M or --metrics options.
Signed-off-by Ian Rogers <[email protected]>
Thanks,
Namhyung
Quoted 22 lines
--- tools/perf/perf-completion.sh | 4 ++++ 1 file changed, 4 insertions(+)tools/perf/perf-completion.sh +4
-1@@ -202,6 +202,10 @@ __perf_main () $prev_skip_opts == @(record|stat|top) ]]; then local evts=$($cmd list --raw-dump pfm) __perfcomp "$evts" "$cur" + elif [[ $prev == @("-M"|"--metrics") && + $prev_skip_opts == @(stat) ]]; then + local metrics=$($cmd list --raw-dump metric metricgroup) + __perfcomp "$metrics" "$cur" else # List subcommands for perf commands if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched| --2.42.0.283.g2d96d420d3-goog
Quoted 6 lines · Ian Rogers
perf list will list libpfm4 events and metrics which aren't valid options to the '-e' option. Restrict the events gathered so that invalid ones aren't shown.
Before:
Quoted 8 lines
$ perf stat -e <tab><tab> Display all 633 possibilities? (y or n)After:
$ perf stat -e <tab><tab> Display all 375 possibilities? (y or n)Signed-off-by Ian Rogers <[email protected]>
Thanks,
Namhyung
Quoted 20 lines
--- tools/perf/perf-completion.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/perf-completion.sh +1
-2@@ -164,7 +164,7 @@ __perf_main () $prev_skip_opts == @(record|stat|top) ]]; then local cur1=${COMP_WORDS[COMP_CWORD]} - local raw_evts=$($cmd list --raw-dump) + local raw_evts=$($cmd list --raw-dump hw sw cache tracepoint pmu sdt) local arr s tmp result cpu_evts # aarch64 doesn't have /sys/bus/event_source/devices/cpu/events --2.42.0.283.g2d96d420d3-goog
Arnaldo Carvalho de Melo
maintainerEm Tue, Sep 05, 2023 at 11:15:52AM -0700, Ian Rogers escreveu:
Quoted 11 lines
perf list will list libpfm4 events and metrics which aren't valid options to the '-e' option. Restrict the events gathered so that invalid ones aren't shown.
Before:
$ perf stat -e <tab><tab> Display all 633 possibilities? (y or n)After:
$ perf stat -e <tab><tab> Display all 375 possibilities? (y or n)
Thanks, tested and applied.
- Arnaldo
Quoted 21 lines
Signed-off-by Ian Rogers <[email protected]>--- tools/perf/perf-completion.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/perf-completion.sh +1
-1@@ -164,7 +164,7 @@ __perf_main () $prev_skip_opts == @(record|stat|top) ]]; then local cur1=${COMP_WORDS[COMP_CWORD]} - local raw_evts=$($cmd list --raw-dump) + local raw_evts=$($cmd list --raw-dump hw sw cache tracepoint pmu sdt) local arr s tmp result cpu_evts # aarch64 doesn't have /sys/bus/event_source/devices/cpu/eventsSignature · 1 line
2.42.0.283.g2d96d420d3-goog
Signature · 1 line
- Arnaldo