Skip to contentSkip to conversation

qemu-system-native: enable PNG support

PATCH New [email protected] 2 participants 3 messages Sep 6, 2023 – Sep 7, 2023 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 qemu-system-native: enable PNG support

From: Ross Burton <[email protected]>

It might be useful to grab screenshots from qemu-system-native (for example, for QA purposes).

---
 meta/recipes-devtools/qemu/qemu-system-native_8.0.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/qemu/qemu-system-native_8.0.4.bb +1 -1
index 04c7c2a6acf..558a416f7b4 100644
@@ -11,7 +11,7 @@ DEPENDS = "glib-2.0-native zlib-native pixman-native qemu-native bison-native me
 
 EXTRA_OECONF:append = " --target-list=${@get_qemu_system_target_list(d)}"
 
-PACKAGECONFIG ??= "fdt alsa kvm pie slirp \
+PACKAGECONFIG ??= "fdt alsa kvm pie slirp png \
     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'virglrenderer epoxy', '', d)} \
 "
 
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/2 scripts/oe-find-native-sysroot: use bitbake-getvar

From: Ross Burton <[email protected]>

Instead of bitbake and grep, just use bitbake-getvar.

---
 scripts/oe-find-native-sysroot | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)
scripts/oe-find-native-sysroot +2 -13
index 5146bbf9999..6228efcbeec 100755
@@ -36,20 +36,9 @@ if [ "$1" = '--help' -o "$1" = '-h' -o $# -ne 1 ] ; then
 fi
 
 # Global vars
-BITBAKE_E=""
 set_oe_native_sysroot(){
-    echo "Running bitbake -e $1"
-    BITBAKE_E="`bitbake -e $1`"
-    OECORE_NATIVE_SYSROOT=`echo "$BITBAKE_E" | grep ^STAGING_DIR_NATIVE= | cut -d '"' -f2`
-
-    if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then
-        # This indicates that there was an error running bitbake -e that
-        # the user needs to be informed of
-        echo "There was an error running bitbake to determine STAGING_DIR_NATIVE"
-        echo "Here is the output from bitbake -e $1"
-        echo $BITBAKE_E
-        exit 1
-    fi
+    echo "Getting sysroot..."
+    OECORE_NATIVE_SYSROOT=$(bitbake-getvar -r $1 --value STAGING_DIR_NATIVE)
 }
 
 if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then
Signature · 1 line
2.34.1

A message that is not in the archive (sent off-list or not yet received): CANPvuRkC-BQPD2TOZXtj_Xq96FHLeX60bqd3VwpxuC=KjyUYBA@mail.gmail.com

#3 lore raw

PATCH 2/2 scripts/oe-find-native-sysroot: use bitbake-getvar

Sorry, I have replayed directly to Ross so forward to the list.

I also have tested it locally and if there are some warnings generated they will be captured as well
breaking the OECORE_NATIVE_SYSROOT content, so the -q is required.

Jose

---------- Forwarded message ---------
De: Jose Quaresma <[email protected]>
Date: quarta, 6/09/2023 à(s) 17:37
Subject: Re: [OE-core] [PATCH 2/2] scripts/oe-find-native-sysroot: use bitbake-getvar
To: Ross Burton <[email protected]>

Ross Burton <[email protected]> escreveu no dia quarta, 6/09/2023 à(s) 16:16:

Quoted 36 lines

From: Ross Burton <[email protected]>

Instead of bitbake and grep, just use bitbake-getvar.

---
 scripts/oe-find-native-sysroot | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)
scripts/oe-find-native-sysroot +0 -4
index 5146bbf9999..6228efcbeec 100755
@@ -36,20 +36,9 @@ if [ "$1" = '--help' -o "$1" = '-h' -o $# -ne 1 ] ; then
 fi
 
 # Global vars
-BITBAKE_E=""
 set_oe_native_sysroot(){
-    echo "Running bitbake -e $1"
-    BITBAKE_E="`bitbake -e $1`"
-    OECORE_NATIVE_SYSROOT=`echo "$BITBAKE_E" | grep ^STAGING_DIR_NATIVE=

| cut -d '"' -f2`

scripts/oe-find-native-sysroot +0 -5
-
-    if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then
-        # This indicates that there was an error running bitbake -e that
-        # the user needs to be informed of
-        echo "There was an error running bitbake to determine

STAGING_DIR_NATIVE"

scripts/oe-find-native-sysroot +2 -4
-        echo "Here is the output from bitbake -e $1"
-        echo $BITBAKE_E
-        exit 1
-    fi
+    echo "Getting sysroot..."
+    OECORE_NATIVE_SYSROOT=$(bitbake-getvar -r $1 --value
Quoted 2 lines

STAGING_DIR_NATIVE)

Maybe you should use --quite to silent the logs.

Jose

Quoted 18 lines

}

if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then
--
2.34.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#187321):
https://lists.openembedded.org/g/openembedded-core/message/187321
Mute This Topic: https://lists.openembedded.org/mt/101194938/5052612
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 9 lines
Best regards,

José Quaresma


-- 
Best regards,

José Quaresma