Skip to contentSkip to conversation

main.conf: Fix printing errors for valid options

PATCH Applied Luiz Augusto von Dentz 3 participants 4 messages Sep 7, 2023 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/2 main.conf: Fix printing errors for valid options

From: Luiz Augusto von Dentz <[email protected]>

This fixes the following errors:

Unknown key RefreshDiscovery for group General
Unknown key Encryption for group CSIS

---
 src/main.c | 2 ++
 1 file changed, 2 insertions(+)
src/main.c +2 -0
index 2134fcf752cf..b5a6f8e5562f 100644
@@ -85,6 +85,7 @@ static const char *supported_options[] = {
 	"Privacy",
 	"JustWorksRepairing",
 	"TemporaryTimeout",
+	"RefreshDiscovery",
 	"Experimental",
 	"KernelExperimental",
 	"RemoteNameRequestRetryDelay",
@@ -149,6 +150,7 @@ static const char *gatt_options[] = {
 
 static const char *csip_options[] = {
 	"SIRK",
+	"Encryption",
 	"Size",
 	"Rank",
 	NULL
Signature · 1 line
2.41.0
author maintainer
#1 lore raw

PATCH 2/2 main.conf: Fix documention of CSIS.Encrypt

From: Luiz Augusto von Dentz <[email protected]>

CSIS.Encrypt is a boolean so it shall only be set with true/false not yes/no.

---
 src/main.conf | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
src/main.conf +4 -4
index d108934a8ae9..085c81a462dd 100644
@@ -270,10 +270,10 @@
 
 # SIRK Encryption
 # Possible values:
-# yes: Encrypt SIRK when read
-# no: Do not encrypt SIRK when read. (plaintext)
-# Defaults to yes
-#Encryption = yes
+# true: Encrypt SIRK when read
+# false: Do not encrypt SIRK when read. (plaintext)
+# Defaults to true
+#Encryption = true
 
 # Total no of sets belongs to this Profile
 # Defaults to 0
Signature · 1 line
2.41.0
#2 lore raw
In reply to Luiz Augusto von Dentz

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=782332

---Test result---

Test Summary:

CheckPatch                    PASS      0.97 seconds
GitLint                       PASS      0.71 seconds
BuildEll                      PASS      26.76 seconds
BluezMake                     PASS      775.48 seconds
MakeCheck                     PASS      11.57 seconds
MakeDistcheck                 PASS      155.78 seconds
CheckValgrind                 PASS      251.36 seconds
CheckSmatch                   PASS      340.71 seconds
bluezmakeextell               PASS      103.04 seconds
IncrementalBuild              PASS      1309.56 seconds
ScanBuild                     PASS      1018.30 seconds

---
Regards,
Linux Bluetooth

#3 lore raw
In reply to Luiz Augusto von Dentz
This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 8 lines · On Thu, 7 Sep 2023 12:41:33 -0700 you wrote:

From: Luiz Augusto von Dentz <[email protected]>

This fixes the following errors:

Unknown key RefreshDiscovery for group General
Unknown key Encryption for group CSIS

[...]

Here is the summary with links:
- [BlueZ,1/2] main.conf: Fix printing errors for valid options

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=32daf644a497
  - [BlueZ,2/2] main.conf: Fix documention of CSIS.Encrypt
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3294c42c9677

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html