Skip to contentSkip to conversation

fixup! python3-numpy: remove NPY_INLINE, use inline instead

PATCH In review [email protected] 2 participants 4 messages Sep 8, 2023

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 fixup! python3-numpy: remove NPY_INLINE, use inline instead

From: Mingli Yu <[email protected]>

Fixes:
/usr/lib/gcc/x86_64-redhat-linux/13/include/avx512fintrin.h:314:1: error: inlining failed in call to 'always_inline' '_mm512_setzero_ps': target specific option mismatch 314 | _mm512_setzero_ps (void)

       | ^~~~~~~~~~~~~~~~~
   numpy/core/src/umath/simd.inc.src:977:20: note: called from here
   977 |     @vtype@ zeros = _mm512_setzero_@vsuffix@();
       |                    ^~~~~~~~~~~~~~~~~~~
   numpy/core/src/umath/simd.inc.src:596:1: error: inlining failed in call to ‘always_inline’ ‘avx512_get_full_load_mask_ps’: target specific option mismatch
   596 | avx512_get_full_load_mask_ps(void)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  numpy/core/src/umath/simd.inc.src:976:27: note: called from here
   976 |     @mask@ load_mask = avx512_get_full_load_mask_@vsuffix@();
       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---
 .../0001-simd.inc.src-Change-NPY_INLINE-to-inline.patch       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/python/python3-numpy/0001-simd.inc.src-Change-NPY_INLINE-to-inline.patch +2 -2
index d733dda333..73c9c79bdd 100644
@@ -117,7 +117,7 @@ index d6c9a7e..39aec9a 100644
  
  #if defined HAVE_ATTRIBUTE_TARGET_AVX512F_WITH_INTRINSICS && defined NPY_HAVE_SSE2_INTRINSICS
 -static NPY_GCC_OPT_3 NPY_INLINE NPY_GCC_TARGET_AVX512F void
-+static NPY_GCC_OPT_3 inline NPY_GCC_TARGET_AVX512F void
++static inline NPY_GCC_TARGET_AVX512F void
  AVX512F_@func@_@TYPE@(@type@ * op,
                        @type@ * ip,
                        const npy_intp array_size,
@@ -126,7 +126,7 @@ index d6c9a7e..39aec9a 100644
  
  #if defined HAVE_ATTRIBUTE_TARGET_AVX512F_WITH_INTRINSICS && defined NPY_HAVE_SSE2_INTRINSICS
 -static NPY_GCC_OPT_3 NPY_INLINE NPY_GCC_TARGET_AVX512F void
-+static NPY_GCC_OPT_3 inline NPY_GCC_TARGET_AVX512F void
++static inline NPY_GCC_TARGET_AVX512F void
  AVX512F_absolute_@TYPE@(@type@ * op,
                          @type@ * ip,
                          const npy_intp array_size,
Signature · 1 line
2.25.1
#1 lore raw

when do we see these errors ? how does this impact performance?

Quoted 56 lines · Mingli

From: Mingli Yu <[email protected]>

Fixes:

   /usr/lib/gcc/x86_64-redhat-linux/13/include/avx512fintrin.h:314:1: error: inlining failed in call to 'always_inline' '_mm512_setzero_ps': target specific option mismatch
   314 | _mm512_setzero_ps (void)
       | ^~~~~~~~~~~~~~~~~
   numpy/core/src/umath/simd.inc.src:977:20: note: called from here
   977 |     @vtype@ zeros = _mm512_setzero_@vsuffix@();
       |                    ^~~~~~~~~~~~~~~~~~~
   numpy/core/src/umath/simd.inc.src:596:1: error: inlining failed in call to ‘always_inline’ ‘avx512_get_full_load_mask_ps’: target specific option mismatch
   596 | avx512_get_full_load_mask_ps(void)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  numpy/core/src/umath/simd.inc.src:976:27: note: called from here
   976 |     @mask@ load_mask = avx512_get_full_load_mask_@vsuffix@();
       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---
 .../0001-simd.inc.src-Change-NPY_INLINE-to-inline.patch       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/python/python3-numpy/0001-simd.inc.src-Change-NPY_INLINE-to-inline.patch +2 -3
index d733dda333..73c9c79bdd 100644
@@ -117,7 +117,7 @@ index d6c9a7e..39aec9a 100644
 
  #if defined HAVE_ATTRIBUTE_TARGET_AVX512F_WITH_INTRINSICS && defined NPY_HAVE_SSE2_INTRINSICS
 -static NPY_GCC_OPT_3 NPY_INLINE NPY_GCC_TARGET_AVX512F void
-+static NPY_GCC_OPT_3 inline NPY_GCC_TARGET_AVX512F void
++static inline NPY_GCC_TARGET_AVX512F void
  AVX512F_@func@_@TYPE@(@type@ * op,
                        @type@ * ip,
                        const npy_intp array_size,
@@ -126,7 +126,7 @@ index d6c9a7e..39aec9a 100644
 
  #if defined HAVE_ATTRIBUTE_TARGET_AVX512F_WITH_INTRINSICS && defined NPY_HAVE_SSE2_INTRINSICS
 -static NPY_GCC_OPT_3 NPY_INLINE NPY_GCC_TARGET_AVX512F void
-+static NPY_GCC_OPT_3 inline NPY_GCC_TARGET_AVX512F void
++static inline NPY_GCC_TARGET_AVX512F void
  AVX512F_absolute_@TYPE@(@type@ * op,
                          @type@ * ip,
                          const npy_intp array_size,
--

2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#187402): https://lists.openembedded.org/g/openembedded-core/message/187402
Mute This Topic: https://lists.openembedded.org/mt/101231101/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

author
#2 lore raw

We will encounter the build failure when debug enabled(add DEBUG_BUILD = "1" in local.conf) [1].

[1] https://git.openembedded.org/openembedded-core/commit/?h=mickledore&id=77a64a8686b6c9ef3bc6adbce6cdc442096decfd

Thanks,
________________________________
From: Khem Raj <[email protected]>
Sent: Friday, September 8, 2023 12:46
To: Yu, Mingli <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [OE-core] [mickledore][PATCH v2] fixup! python3-numpy: remove NPY_INLINE, use inline instead

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

when do we see these errors ? how does this impact performance?

Quoted 56 lines · Mingli

From: Mingli Yu <[email protected]>

Fixes:

   /usr/lib/gcc/x86_64-redhat-linux/13/include/avx512fintrin.h:314:1: error: inlining failed in call to 'always_inline' '_mm512_setzero_ps': target specific option mismatch
   314 | _mm512_setzero_ps (void)
       | ^~~~~~~~~~~~~~~~~
   numpy/core/src/umath/simd.inc.src:977:20: note: called from here
   977 |     @vtype@ zeros = _mm512_setzero_@vsuffix@();
       |                    ^~~~~~~~~~~~~~~~~~~
   numpy/core/src/umath/simd.inc.src:596:1: error: inlining failed in call to ‘always_inline’ ‘avx512_get_full_load_mask_ps’: target specific option mismatch
   596 | avx512_get_full_load_mask_ps(void)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  numpy/core/src/umath/simd.inc.src:976:27: note: called from here
   976 |     @mask@ load_mask = avx512_get_full_load_mask_@vsuffix@();
       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---
 .../0001-simd.inc.src-Change-NPY_INLINE-to-inline.patch       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/python/python3-numpy/0001-simd.inc.src-Change-NPY_INLINE-to-inline.patch +2 -3
index d733dda333..73c9c79bdd 100644
@@ -117,7 +117,7 @@ index d6c9a7e..39aec9a 100644
 
  #if defined HAVE_ATTRIBUTE_TARGET_AVX512F_WITH_INTRINSICS && defined NPY_HAVE_SSE2_INTRINSICS
 -static NPY_GCC_OPT_3 NPY_INLINE NPY_GCC_TARGET_AVX512F void
-+static NPY_GCC_OPT_3 inline NPY_GCC_TARGET_AVX512F void
++static inline NPY_GCC_TARGET_AVX512F void
  AVX512F_@func@_@TYPE@(@type@ * op,
                        @type@ * ip,
                        const npy_intp array_size,
@@ -126,7 +126,7 @@ index d6c9a7e..39aec9a 100644
 
  #if defined HAVE_ATTRIBUTE_TARGET_AVX512F_WITH_INTRINSICS && defined NPY_HAVE_SSE2_INTRINSICS
 -static NPY_GCC_OPT_3 NPY_INLINE NPY_GCC_TARGET_AVX512F void
-+static NPY_GCC_OPT_3 inline NPY_GCC_TARGET_AVX512F void
++static inline NPY_GCC_TARGET_AVX512F void
  AVX512F_absolute_@TYPE@(@type@ * op,
                          @type@ * ip,
                          const npy_intp array_size,
--

2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#187402): https://lists.openembedded.org/g/openembedded-core/message/187402
Mute This Topic: https://lists.openembedded.org/mt/101231101/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw
Quoted 3 lines · Mingli

We will encounter the build failure when debug enabled(add DEBUG_BUILD = "1" in local.conf) [1].

I would suggest to keep it limited to this option then

Quoted 72 lines

[1] https://git.openembedded.org/openembedded-core/commit/?h=mickledore&id=77a64a8686b6c9ef3bc6adbce6cdc442096decfd

Thanks,
________________________________
From: Khem Raj <[email protected]>
Sent: Friday, September 8, 2023 12:46
To: Yu, Mingli <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [OE-core] [mickledore][PATCH v2] fixup! python3-numpy: remove NPY_INLINE, use inline instead

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

when do we see these errors ? how does this impact performance?

Quoted 56 lines · Mingli

From: Mingli Yu <[email protected]>

Fixes:

   /usr/lib/gcc/x86_64-redhat-linux/13/include/avx512fintrin.h:314:1: error: inlining failed in call to 'always_inline' '_mm512_setzero_ps': target specific option mismatch
   314 | _mm512_setzero_ps (void)
       | ^~~~~~~~~~~~~~~~~
   numpy/core/src/umath/simd.inc.src:977:20: note: called from here
   977 |     @vtype@ zeros = _mm512_setzero_@vsuffix@();
       |                    ^~~~~~~~~~~~~~~~~~~
   numpy/core/src/umath/simd.inc.src:596:1: error: inlining failed in call to ‘always_inline’ ‘avx512_get_full_load_mask_ps’: target specific option mismatch
   596 | avx512_get_full_load_mask_ps(void)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  numpy/core/src/umath/simd.inc.src:976:27: note: called from here
   976 |     @mask@ load_mask = avx512_get_full_load_mask_@vsuffix@();
       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---
 .../0001-simd.inc.src-Change-NPY_INLINE-to-inline.patch       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/python/python3-numpy/0001-simd.inc.src-Change-NPY_INLINE-to-inline.patch +2 -3
index d733dda333..73c9c79bdd 100644
@@ -117,7 +117,7 @@ index d6c9a7e..39aec9a 100644
 
  #if defined HAVE_ATTRIBUTE_TARGET_AVX512F_WITH_INTRINSICS && defined NPY_HAVE_SSE2_INTRINSICS
 -static NPY_GCC_OPT_3 NPY_INLINE NPY_GCC_TARGET_AVX512F void
-+static NPY_GCC_OPT_3 inline NPY_GCC_TARGET_AVX512F void
++static inline NPY_GCC_TARGET_AVX512F void
  AVX512F_@func@_@TYPE@(@type@ * op,
                        @type@ * ip,
                        const npy_intp array_size,
@@ -126,7 +126,7 @@ index d6c9a7e..39aec9a 100644
 
  #if defined HAVE_ATTRIBUTE_TARGET_AVX512F_WITH_INTRINSICS && defined NPY_HAVE_SSE2_INTRINSICS
 -static NPY_GCC_OPT_3 NPY_INLINE NPY_GCC_TARGET_AVX512F void
-+static NPY_GCC_OPT_3 inline NPY_GCC_TARGET_AVX512F void
++static inline NPY_GCC_TARGET_AVX512F void
  AVX512F_absolute_@TYPE@(@type@ * op,
                          @type@ * ip,
                          const npy_intp array_size,
--

2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#187402): https://lists.openembedded.org/g/openembedded-core/message/187402
Mute This Topic: https://lists.openembedded.org/mt/101231101/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-