ARM: dts: am335x-pocketbeagle: choose tick-timer
PATCH 1/1 ARM: dts: am335x-pocketbeagle: choose tick-timer
Commit 4b2be78ab66c ("time: Fix get_ticks being non-monotonic") requires '/chosen/tick-timer' in device-tree. Otherwise we get:
U-Boot 2023.07.02 (Jul 11 2023 - 15:20:44 +0000) CPU : AM335X-GP rev 2.1 Model: TI AM335x PocketBeagle DRAM: 512 MiB Core: 154 devices, 16 uclasses, devicetree: separate Could not initialize timer (err -19) resetting ...
--- arch/arm/dts/am335x-pocketbeagle.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm/dts/am335x-pocketbeagle.dts +1 -0
@@ -15,6 +15,7 @@ chosen { stdout-path = &uart0; + tick-timer = &timer2; }; leds {
Signature · 1 line
2.41.0.327.gaa9166bcc0ba
Quoted 12 lines · Trevor Woerner
Commit
4b2be78ab66c("time: Fixget_ticksbeing non-monotonic") requires '/chosen/tick-timer' in device-tree. Otherwise we get:U-Boot 2023.07.02 (Jul 11 2023 - 15:20:44 +0000)
CPU : AM335X-GP rev 2.1
Model: TI AM335x PocketBeagle
DRAM: 512 MiB
Core: 154 devices, 16 uclasses, devicetree: separate Could not initialize timer (err -19)
Quoted 4 lines
resetting ...
Suggested-by Pierre Lebleu <[email protected]>Signed-off-by Trevor Woerner <[email protected]>
Quoted 17 lines
--- arch/arm/dts/am335x-pocketbeagle.dts | 1 + 1 file changed, 1 insertion(+)arch/arm/dts/am335x-pocketbeagle.dts +1
-1@@ -15,6 +15,7 @@ chosen { stdout-path = &uart0; + tick-timer = &timer2; }; leds { --
Quoted 1 line
2.41.0.327.gaa9166bcc0ba
Thanks for posting this Trevor, I'm also running with this change..
Regards,
Signature · 2 lines
Robert Nelson https://rcn-ee.com/
Quoted 34 lines · Trevor Woerner
Commit
4b2be78ab66c("time: Fixget_ticksbeing non-monotonic") requires '/chosen/tick-timer' in device-tree. Otherwise we get:U-Boot 2023.07.02 (Jul 11 2023 - 15:20:44 +0000) CPU : AM335X-GP rev 2.1 Model: TI AM335x PocketBeagle DRAM: 512 MiB Core: 154 devices, 16 uclasses, devicetree: separate Could not initialize timer (err -19) resetting ...Suggested-by Pierre Lebleu <[email protected]>Signed-off-by Trevor Woerner <[email protected]>--- arch/arm/dts/am335x-pocketbeagle.dts | 1 + 1 file changed, 1 insertion(+)arch/arm/dts/am335x-pocketbeagle.dts +1
-0@@ -15,6 +15,7 @@ chosen { stdout-path = &uart0; + tick-timer = &timer2; }; leds {Signature · 1 line
2.41.0.327.gaa9166bcc0ba
Does enabling CONFIG_SYS_ARCH_TIMER solve this?
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Quoted 31 lines · Nishanth Menon
Quoted 30 lines · Trevor Woerner
Commit
4b2be78ab66c("time: Fixget_ticksbeing non-monotonic") requires '/chosen/tick-timer' in device-tree. Otherwise we get:U-Boot 2023.07.02 (Jul 11 2023 - 15:20:44 +0000) CPU : AM335X-GP rev 2.1 Model: TI AM335x PocketBeagle DRAM: 512 MiB Core: 154 devices, 16 uclasses, devicetree: separate Could not initialize timer (err -19) resetting ...Suggested-by Pierre Lebleu <[email protected]>Signed-off-by Trevor Woerner <[email protected]>--- arch/arm/dts/am335x-pocketbeagle.dts | 1 + 1 file changed, 1 insertion(+)arch/arm/dts/am335x-pocketbeagle.dts +1
-0@@ -15,6 +15,7 @@ chosen { stdout-path = &uart0; + tick-timer = &timer2; };
Quoted 6 lines
Quoted 4 lines
arch/arm/dts/am335x-pocketbeagle.dts +0
-0leds {Signature · 1 line
2.41.0.327.gaa9166bcc0baDoes enabling
CONFIG_SYS_ARCH_TIMERsolve this?
Enabling CONFIG_SYS_ARCH_TIMER causes the following compile error:
| arm-oe-linux-gnueabi-ld.bfd: arch/arm/cpu/armv7/arch_timer.o: in function `timer_init': | /z/build-master/pocketbeagle/build/tmp-glibc/work/pocketbeagle-oe-linux-gnueabi/u-boot/2023.07.02/git/arch/arm/cpu/armv7/arch_timer.c:29: multiple definition of `timer_init'; arch/arm/mach-omap2/timer.o:/z/build-master/pocketbeagle/build/tmp-glibc/work/pocketbeagle-oe-linux-gnueabi/u-boot/2023.07.02/git/arch/arm/mach-omap2/timer.c:44: first defined here | arm-oe-linux-gnueabi-ld.bfd: arch/arm/cpu/armv7/arch_timer.o: in function `get_ticks': | /z/build-master/pocketbeagle/build/tmp-glibc/work/pocketbeagle-oe-linux-gnueabi/u-boot/2023.07.02/git/arch/arm/cpu/armv7/arch_timer.c:44: multiple definition of `get_ticks'; arch/arm/mach-omap2/timer.o:/z/build-master/pocketbeagle/build/tmp-glibc/work/pocketbeagle-oe-linux-gnueabi/u-boot/2023.07.02/git/arch/arm/mach-omap2/timer.c:97: first defined here | arm-oe-linux-gnueabi-ld.bfd: arch/arm/cpu/armv7/arch_timer.o: in function `get_tbclk': | /z/build-master/pocketbeagle/build/tmp-glibc/work/pocketbeagle-oe-linux-gnueabi/u-boot/2023.07.02/git/arch/arm/cpu/armv7/arch_timer.c:63: multiple definition of `get_tbclk'; arch/arm/mach-omap2/timer.o:/z/build-master/pocketbeagle/build/tmp-glibc/work/pocketbeagle-oe-linux-gnueabi/u-boot/2023.07.02/git/arch/arm/mach-omap2/timer.c:108: first defined here
Without CONFIG_SYS_ARCH_TIMER, the functions timer_init(), get_ticks(), and get_tbclk() are defined in arch/arm/mach-omap2/timer.c. When CONFIG_SYS_ARCH_TIMER is defined, it also pulls in the file arch/arm/cpu/armv7/arch_timer.c.
There is a config option, CONFIG_TIMER, that controls the inclusion of arch/arm/mach-omap2/timer.c, but it is unconditional during SPL:
arch/arm/mach-omap2/Makefile ... 12 ifeq ($(CONFIG_TIMER),) 13 obj-y += timer.o 14 else 15 ifdef CONFIG_SPL_BUILD 16 obj-y += timer.o 17 endif 18 endif ...
So whether CONFIG_TIMER is defined or not, a compile error will result if CONFIG_SYS_ARCH_TIMER is also defined.
Getting the code to compile with CONFIG_SYS_ARCH_TIMER would require a deeper reworking of the configuration/Make logic in order to swap out the functions in arch/arm/mach-omap2/timer.c for the ones in arch/arm/cpu/armv7/arch_timer.c. The definitions of those functions in both those locations are quite different, so even after getting the build to work there's no guarantee the arch functions would work.
Best regards,
Trevor
Quoted 38 lines · Trevor Woerner
Quoted 37 lines · Nishanth Menon
Quoted 34 lines · Trevor Woerner
Commit
4b2be78ab66c("time: Fixget_ticksbeing non-monotonic") requires '/chosen/tick-timer' in device-tree. Otherwise we get:U-Boot 2023.07.02 (Jul 11 2023 - 15:20:44 +0000) CPU : AM335X-GP rev 2.1 Model: TI AM335x PocketBeagle DRAM: 512 MiB Core: 154 devices, 16 uclasses, devicetree: separate Could not initialize timer (err -19) resetting ...Suggested-by Pierre Lebleu <[email protected]>Signed-off-by Trevor Woerner <[email protected]>--- arch/arm/dts/am335x-pocketbeagle.dts | 1 + 1 file changed, 1 insertion(+)arch/arm/dts/am335x-pocketbeagle.dts +1
-0@@ -15,6 +15,7 @@ chosen { stdout-path = &uart0; + tick-timer = &timer2; }; leds {Signature · 1 line
2.41.0.327.gaa9166bcc0baDoes enabling
CONFIG_SYS_ARCH_TIMERsolve this?
[...]
Quoted 6 lines
Getting the code to compile with
CONFIG_SYS_ARCH_TIMERwould require a deeper reworking of the configuration/Make logic in order to swap out the functions inarch/arm/mach-omap2/timer.cfor the ones inarch/arm/cpu/armv7/arch_timer.c. The definitions of those functions in both those locations are quite different, so even after getting the build to work there's no guarantee the arch functions would work.
The difference is using SoC level dmtimer vs cpu level arch timer. Either way, it will be good to send this upstream kernel.org.
Looking at the trm[1], it looks like arch timer isn't there for cortex-a8?
[1] https://developer.arm.com/documentation/ddi0344/latest/
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D