arm64: dts: imx93: Add the TMU interrupt
Subsystems (3)
Fabio Estevam
reviewerPATCH v2 1/2 arm64: dts: imx93: Add the TMU interrupt
From: Fabio Estevam <[email protected]>
The Thermal Monitoring Unit (TMU) interrupt is number 83.
Describe it in the devicetree to fix the following schema warning:
imx93-11x11-evk.dtb: tmu@44482000: 'oneOf' conditional failed, one must be fixed:
'interrupts' is a required property
'interrupts-extended' is a required property
from schema $id: http://devicetree.org/schemas/thermal/qoriq-thermal.yaml#
---
Changes since v1:
- None
arch/arm64/boot/dts/freescale/imx93.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx93.dtsi +1 -0
@@ -385,6 +385,7 @@ anatop: anatop@44480000 { tmu: tmu@44482000 { compatible = "fsl,qoriq-tmu"; reg = <0x44482000 0x1000>; + interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clk IMX93_CLK_TMC_GATE>; little-endian; fsl,tmu-range = <0x800000da 0x800000e9
Signature · 1 line
2.34.1
Fabio Estevam
reviewerPATCH v2 2/2 dt-bindings: thermal: qoriq-thermal: Adjust fsl,tmu-range maxItems
From: Fabio Estevam <[email protected]>
imx93 has a maximum of seven entries for fsl,tmu-range.
Change it accordingly.
This fixes the following schema warning:
imx93-11x11-evk.dtb: tmu@44482000: fsl,tmu-range: 'oneOf' conditional failed, one must be fixed:
[2147483866, 2147483881, 2147483906, 2147483946, 2147484006, 2147484071, 2147484086] is too long
---
Changes since v1:
- Reduce the context of the schema warning in the commit log.
Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml +2 -1
@@ -33,7 +33,8 @@ properties: description: | The values to be programmed into TTRnCR, as specified by the SoC reference manual. The first cell is TTR0CR, the second is TTR1CR, etc. - maxItems: 4 + minItems: 4 + maxItems: 7 fsl,tmu-calibration: $ref: /schemas/types.yaml#/definitions/uint32-matrix
Signature · 1 line
2.34.1
Re: [PATCH v2 2/2] dt-bindings: thermal: qoriq-thermal: Adjust fsl,tmu-range maxItems
Quoted 4 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
imx93 has a maximum of seven entries for fsl,tmu-range.
Then qoriq should have it constrained to 4 entries.
Best regards,
Krzysztof
Fabio Estevam
reviewerRe: [PATCH v2 2/2] dt-bindings: thermal: qoriq-thermal: Adjust fsl,tmu-range maxItems
Hi Krzysztof,
Quoted 8 lines · Krzysztof Kozlowski
Quoted 4 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
imx93 has a maximum of seven entries for fsl,tmu-range.
Then qoriq should have it constrained to 4 entries.
I just noticed that fsl-lx2160a.dtsi is also has a tmu compatible with two entries.
Would it be OK to represent it like this?
Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml +2 -1
@@ -33,7 +33,8 @@ properties: description: | The values to be programmed into TTRnCR, as specified by the SoC reference manual. The first cell is TTR0CR, the second is TTR1CR, etc. - maxItems: 4 + minItems: 2 + maxItems: 7
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Shawn Guo
AppliedQuoted 4 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The Thermal Monitoring Unit (TMU) interrupt is number 83.
Quoted 8 lines
Describe it in the devicetree to fix the following schema warning:
imx93-11x11-evk.dtb: tmu@44482000: 'oneOf' conditional failed, one must be fixed:
'interrupts' is a required property
'interrupts-extended' is a required property
from schema $id: http://devicetree.org/schemas/thermal/qoriq-thermal.yaml#Signed-off-by Fabio Estevam <[email protected]>
Applied, thanks!