scripts: Introduce a default git.orderFile
RFC PATCH v2 1/1 scripts: Introduce a default git.orderFile
When reviewing patches, it looks much nicer to have some changes shown before others, which allow better understanding of the patch before the the .c files reviewing.
Introduce a default git.orderFile, in order to help developers getting the best ordering easier.
---
Please provide feedback on what else to add / remove / reorder here!
Changes since RFCv1:
- Added Kconfig* (thanks Randy Dunlap!)
- Changed Kbuild to Kbuild* (improve matching)
scripts/git.orderFile | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 scripts/git.orderFile
scripts/git.orderFile new file +32 -0
@@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +# order file for git, to produce patches which are easier to review +# by diffing the important stuff like header changes first. +# +# one-off usage: +# git diff -O scripts/git.orderfile ... +# +# add to git config: +# git config diff.orderFile scripts/git.orderfile +# + +MAINTAINERS + +# Documentation +Documentation/* +*.rst + +# build system +Kbuild* +Kconfig* +Makefile* +*.mak + +# semantic patches +*.cocci + +# headers +*.h + +# code +*.c
Signature · 1 line
2.42.0
Quoted 8 lines · Leonardo Bras
When reviewing patches, it looks much nicer to have some changes shown before others, which allow better understanding of the patch before the the .c files reviewing.
Introduce a default git.orderFile, in order to help developers getting the best ordering easier.
Signed-off-by Leonardo Bras <[email protected]>
LGTM. Thanks.
Quoted 50 lines
---
Please provide feedback on what else to add / remove / reorder here!
Changes since RFCv1:
- Added Kconfig* (thanks Randy Dunlap!)
- ChangedKbuildto Kbuild* (improve matching)scripts/git.orderFile | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 scripts/git.orderFilescripts/git.orderFile new file +32
-0@@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +# order file for git, to produce patches which are easier to review +# by diffing the important stuff like header changes first. +# +# one-off usage: +# git diff -O scripts/git.orderfile ... +# +# add to git config: +# git config diff.orderFile scripts/git.orderfile +# + +MAINTAINERS + +# Documentation +Documentation/* +*.rst + +# build system +Kbuild* +Kconfig* +Makefile* +*.mak + +# semantic patches +*.cocci + +# headers +*.h + +# code +*.c
Signature · 1 line
~Randy
Quoted 7 lines · Randy Dunlap
Quoted 4 lines · Leonardo Bras
When reviewing patches, it looks much nicer to have some changes shown before others, which allow better understanding of the patch before the the .c files reviewing.
Quoted 8 lines
Quoted 4 lines
Introduce a default git.orderFile, in order to help developers getting the best ordering easier.
Signed-off-by Leonardo Bras <[email protected]>LGTM. Thanks.
Acked-by Randy Dunlap <[email protected]>
Thanks Randy!
Quoted 55 lines
Quoted 51 lines
---
Please provide feedback on what else to add / remove / reorder here!
Changes since RFCv1:
- Added Kconfig* (thanks Randy Dunlap!)
- ChangedKbuildto Kbuild* (improve matching)scripts/git.orderFile | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 scripts/git.orderFilescripts/git.orderFile new file +32
-0@@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +# order file for git, to produce patches which are easier to review +# by diffing the important stuff like header changes first. +# +# one-off usage: +# git diff -O scripts/git.orderfile ... +# +# add to git config: +# git config diff.orderFile scripts/git.orderfile +# + +MAINTAINERS + +# Documentation +Documentation/* +*.rst + +# build system +Kbuild* +Kconfig* +Makefile* +*.mak + +# semantic patches +*.cocci + +# headers +*.h + +# code +*.cSignature · 1 line
~Randy
Quoted 27 lines · Leonardo Bras
When reviewing patches, it looks much nicer to have some changes shown before others, which allow better understanding of the patch before the the .c files reviewing.
Introduce a default git.orderFile, in order to help developers getting the best ordering easier.
Signed-off-by Leonardo Bras <[email protected]>---
Please provide feedback on what else to add / remove / reorder here!
Changes since RFCv1:
- Added Kconfig* (thanks Randy Dunlap!)
- ChangedKbuildto Kbuild* (improve matching)scripts/git.orderFile | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 scripts/git.orderFilescripts/git.orderFile new file +0
-0
scripts/git.orderFile line 2
Quoted 2 lines
scripts/git.orderFile new file +2
-0@@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +
Please use "# SPDX-License-Identifier: GPL-2.0".
/* ... */ is not a valid comment style for the orderfile.
scripts/git.orderFile line 10
Quoted 8 lines
scripts/git.orderFile new file +8
-0+# order file for git, to produce patches which are easier to review +# by diffing the important stuff like header changes first. +# +# one-off usage: +# git diff -O scripts/git.orderfile ... +# +# add to git config: +# git config diff.orderFile scripts/git.orderfile
These comments are bogus.
I guess this comment header was copied from QEMU, but you changed the file path
from scripts/git.orderfile to scripts/git.orderFile.
You need to adjust the comment lines to
git diff -O scripts/git.orderFile ...
git config diff.orderFile scripts/git.orderFile
Or, you need to get the file path back to scripts/git.orderfile
scripts/git.orderFile line 22
Quoted 12 lines
scripts/git.orderFile new file +12
-0+# + +MAINTAINERS + +# Documentation +Documentation/* +*.rst + +# build system +Kbuild* +Kconfig* +Makefile*
Kbuild* and Makefile* are interchangeable.
(both are for GNU Make)
Kconfig* are different types.
Better to arrange the order to
Kconfig*
Kbuild*
Makefile*
scripts/git.orderFile line 23
Quoted 1 line
scripts/git.orderFile new file +1
-0+*.mak
QEMU consistently uses only *.mak.
I just realized the kernel tree uses both *.mak and *.mk
masahiro@zoe:~/ref/linux(master)$ find . -name '*.mak' ./tools/scripts/utilities.mak masahiro@zoe:~/ref/linux(master)$ find . -name '*.mk' ./tools/testing/selftests/lib.mk ./tools/testing/selftests/ptp/testptp.mk
BTW, I quickly tested this, but
it did not work as I expected.
masahiro@zoe:~/ref/linux(aaa)$ git diff --name-only d34599b^..d34599b MAINTAINERS drivers/Kconfig drivers/Makefile drivers/cache/Kconfig drivers/cache/Makefile drivers/cache/ax45mp_cache.c
masahiro@zoe:~/ref/linux(aaa)$ git diff --name-only -O scripts/git.orderFile d34599b^..d34599b MAINTAINERS drivers/cache/ax45mp_cache.c drivers/Kconfig drivers/Makefile drivers/cache/Kconfig drivers/cache/Makefile
masahiro@zoe:~/ref/linux(aaa)$ git diff --name-only -O scripts/git.orderFile d34599b..d34599b^ MAINTAINERS drivers/cache/ax45mp_cache.c drivers/Kconfig drivers/Makefile drivers/cache/Kconfig drivers/cache/Makefile
My expectation was the following:
MAINTAINERSdrivers/Kconfigdrivers/cache/Kconfigdrivers/Makefiledrivers/cache/Makefiledrivers/cache/ax45mp_cache.c
It did not work like that.
Am I missing something?
Quoted 12 lines
scripts/git.orderFile new file +9
-1+ +# semantic patches +*.cocci + +# headers +*.h + +# code +*.c --2.42.0
Signature · 2 lines
Best Regards Masahiro Yamada
Quoted 34 lines · Masahiro Yamada
Quoted 27 lines · Leonardo Bras
When reviewing patches, it looks much nicer to have some changes shown before others, which allow better understanding of the patch before the the .c files reviewing.
Introduce a default git.orderFile, in order to help developers getting the best ordering easier.
Signed-off-by Leonardo Bras <[email protected]>---
Please provide feedback on what else to add / remove / reorder here!
Changes since RFCv1:
- Added Kconfig* (thanks Randy Dunlap!)
- ChangedKbuildto Kbuild* (improve matching)scripts/git.orderFile | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 scripts/git.orderFilescripts/git.orderFile new file +0
-0scripts/git.orderFile line 2
Quoted 2 lines
scripts/git.orderFile new file +2
-0@@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +Please use "# SPDX-License-Identifier: GPL-2.0".
Quoted 1 line
/* ... */ is not a valid comment style for the orderfile.
Oh, you are right.
My bad, it was a last minute change.
Quoted 17 lines
scripts/git.orderFile line 10
Quoted 12 lines
scripts/git.orderFile new file +8
-0+# order file for git, to produce patches which are easier to review +# by diffing the important stuff like header changes first. +# +# one-off usage: +# git diff -O scripts/git.orderfile ... +# +# add to git config: +# git config diff.orderFile scripts/git.orderfileThese comments are bogus.
Quoted 1 line
I guess this comment header was copied from QEMU,
Yes, I tried to adapt it from QEMU to kernel needs.
Quoted 4 lines
but you changed the file path
fromscripts/git.orderfiletoscripts/git.orderFile.
Quoted 8 lines
You need to adjust the comment lines to
git diff -O
scripts/git.orderFile...git config diff.orderFile
scripts/git.orderFile
Adjusted, thanks!
Quoted 27 lines
Or, you need to get the file path back to
scripts/git.orderfilescripts/git.orderFile line 22
Quoted 12 lines
scripts/git.orderFile new file +12
-0+# + +MAINTAINERS + +# Documentation +Documentation/* +*.rst + +# build system +Kbuild* +Kconfig* +Makefile*Kbuild* and Makefile* are interchangeable.
(both are for GNU Make)
Quoted 10 lines
Kconfig* are different types.
Better to arrange the order to
Kconfig*
Kbuild*
Makefile*
Oh, that makes sense.
Done!
Quoted 7 lines
scripts/git.orderFile line 23
Quoted 4 lines
scripts/git.orderFile new file +1
-0+*.makQEMU consistently uses only *.mak.
Quoted 7 lines
I just realized the kernel tree uses both *.mak and *.mk
masahiro@zoe:~/ref/linux(master)$ find . -name '*.mak' ./tools/scripts/utilities.mak masahiro@zoe:~/ref/linux(master)$ find . -name '*.mk' ./tools/testing/selftests/lib.mk ./tools/testing/selftests/ptp/testptp.mk
Sure, I will add '*.mk' after '*.mak', getting:
# build system Kconfig* Kbuild* Makefile* *.mak *.mk
Quoted 52 lines
BTW, I quickly tested this, but
it did not work as I expected.masahiro@zoe:~/ref/linux(aaa)$ git diff --name-only d34599b^..d34599b MAINTAINERS drivers/Kconfig drivers/Makefile drivers/cache/Kconfig drivers/cache/Makefile drivers/cache/ax45mp_cache.cmasahiro@zoe:~/ref/linux(aaa)$ git diff --name-only -O scripts/git.orderFile d34599b^..d34599b MAINTAINERS drivers/cache/ax45mp_cache.c drivers/Kconfig drivers/Makefile drivers/cache/Kconfig drivers/cache/Makefilemasahiro@zoe:~/ref/linux(aaa)$ git diff --name-only -O scripts/git.orderFile d34599b..d34599b^ MAINTAINERS drivers/cache/ax45mp_cache.c drivers/Kconfig drivers/Makefile drivers/cache/Kconfig drivers/cache/MakefileMy expectation was the following:
MAINTAINERSdrivers/Kconfigdrivers/cache/Kconfigdrivers/Makefiledrivers/cache/Makefiledrivers/cache/ax45mp_cache.c
Quoted 2 lines
It did not work like that.
Am I missing something?
I can reproduce this same behavior for this commit list, and this is odd.
When I added a line-end at the .c extension, it works as expected:
*.c$
I think this makes sense.
Just to make sure, I will add an line-end at every pattern with extension:
*.h$
*.c$
*.mk$
and so on.
Does that work for you?
I will send a v3 soon.
Thanks!
Leo
Quoted 26 lines
Quoted 17 lines
scripts/git.orderFile new file +9
-1+ +# semantic patches +*.cocci + +# headers +*.h + +# code +*.c --2.42.0
Signature · 2 lines
Best Regards Masahiro Yamada
Quoted 202 lines · Leonardo Bras
Quoted 34 lines · Masahiro Yamada
Quoted 27 lines · Leonardo Bras
When reviewing patches, it looks much nicer to have some changes shown before others, which allow better understanding of the patch before the the .c files reviewing.
Introduce a default git.orderFile, in order to help developers getting the best ordering easier.
Signed-off-by Leonardo Bras <[email protected]>---
Please provide feedback on what else to add / remove / reorder here!
Changes since RFCv1:
- Added Kconfig* (thanks Randy Dunlap!)
- ChangedKbuildto Kbuild* (improve matching)scripts/git.orderFile | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 scripts/git.orderFilescripts/git.orderFile new file +0
-0scripts/git.orderFile line 2
Quoted 2 lines
scripts/git.orderFile new file +2
-0@@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +Please use "# SPDX-License-Identifier: GPL-2.0".
Quoted 1 line
/* ... */ is not a valid comment style for the orderfile.
Oh, you are right.
My bad, it was a last minute change.Quoted 17 lines
scripts/git.orderFile line 10
Quoted 12 lines
scripts/git.orderFile new file +8
-0+# order file for git, to produce patches which are easier to review +# by diffing the important stuff like header changes first. +# +# one-off usage: +# git diff -O scripts/git.orderfile ... +# +# add to git config: +# git config diff.orderFile scripts/git.orderfileThese comments are bogus.
Quoted 1 line
I guess this comment header was copied from QEMU,
Yes, I tried to adapt it from QEMU to kernel needs.
Quoted 4 lines
but you changed the file path
fromscripts/git.orderfiletoscripts/git.orderFile.Quoted 8 lines
You need to adjust the comment lines to
git diff -O
scripts/git.orderFile...git config diff.orderFile
scripts/git.orderFileAdjusted, thanks!
Quoted 27 lines
Or, you need to get the file path back to
scripts/git.orderfilescripts/git.orderFile line 22
Quoted 12 lines
scripts/git.orderFile new file +12
-0+# + +MAINTAINERS + +# Documentation +Documentation/* +*.rst + +# build system +Kbuild* +Kconfig* +Makefile*Kbuild* and Makefile* are interchangeable.
(both are for GNU Make)Quoted 10 lines
Kconfig* are different types.
Better to arrange the order to
Kconfig*
Kbuild*
Makefile*Oh, that makes sense.
Done!Quoted 7 lines
scripts/git.orderFile line 23
Quoted 4 lines
scripts/git.orderFile new file +1
-0+*.makQEMU consistently uses only *.mak.
Quoted 7 lines
I just realized the kernel tree uses both *.mak and *.mk
masahiro@zoe:~/ref/linux(master)$ find . -name '*.mak' ./tools/scripts/utilities.mak masahiro@zoe:~/ref/linux(master)$ find . -name '*.mk' ./tools/testing/selftests/lib.mk ./tools/testing/selftests/ptp/testptp.mkSure, I will add '*.mk' after '*.mak', getting:
# build system Kconfig* Kbuild* Makefile* *.mak *.mkQuoted 52 lines
BTW, I quickly tested this, but
it did not work as I expected.masahiro@zoe:~/ref/linux(aaa)$ git diff --name-only d34599b^..d34599b MAINTAINERS drivers/Kconfig drivers/Makefile drivers/cache/Kconfig drivers/cache/Makefile drivers/cache/ax45mp_cache.cmasahiro@zoe:~/ref/linux(aaa)$ git diff --name-only -O scripts/git.orderFile d34599b^..d34599b MAINTAINERS drivers/cache/ax45mp_cache.c drivers/Kconfig drivers/Makefile drivers/cache/Kconfig drivers/cache/Makefilemasahiro@zoe:~/ref/linux(aaa)$ git diff --name-only -O scripts/git.orderFile d34599b..d34599b^ MAINTAINERS drivers/cache/ax45mp_cache.c drivers/Kconfig drivers/Makefile drivers/cache/Kconfig drivers/cache/MakefileMy expectation was the following:
MAINTAINERSdrivers/Kconfigdrivers/cache/Kconfigdrivers/Makefiledrivers/cache/Makefiledrivers/cache/ax45mp_cache.cQuoted 2 lines
It did not work like that.
Am I missing something?I can reproduce this same behavior for this commit list, and this is odd.
When I added a line-end at the .c extension, it works as expected:
Quoted 8 lines
*.c$
I think this makes sense.
Just to make sure, I will add an line-end at every pattern with extension:*.h$
*.c$
*.mk$
Oh, nevermind. This breaks the matching, and results are crazy. I will revert it on a v4.
The real solver is:
*/Kconfig*
*/Kbuild*
*/Makefile*
The thing is that if I add just "Kconfig*" it only matches a Kconfig* in the root dir.
Quoted 14 lines
and so on.
Does that work for you?I will send a v3 soon.
Thanks!
LeoQuoted 5 lines
Quoted 6 lines
Quoted 6 lines
scripts/git.orderFile line 29
Quoted 6 lines
scripts/git.orderFile new file +6
-0+ +# semantic patches +*.cocci + +# headers +*.h
I was talking on a previous thread, and it would probably be interesting to add "*types.h" before *.h.
I need to think about a way to filter them out when matching "*.h", or it won't work because of:
Git doc:
"The output order is determined by the order of glob patterns in <orderfile>. All files with pathnames that match the first pattern are output first, all files with pathnames that match the second pattern (but not the first) are output next, and so on."
i.e. the file will be put in the category of the last pattern it matches, and it makes harder to get "*types.h" before "*.h".
Trying to think on some solution.
Quoted 15 lines
Quoted 15 lines
Quoted 6 lines
scripts/git.orderFile new file +3
-1+ +# code +*.c --2.42.0
Signature · 2 lines
Best Regards Masahiro Yamada
Quoted 212 lines · Leonardo Bras
Quoted 202 lines · Leonardo Bras
Quoted 34 lines · Masahiro Yamada
Quoted 27 lines · Leonardo Bras
When reviewing patches, it looks much nicer to have some changes shown before others, which allow better understanding of the patch before the the .c files reviewing.
Introduce a default git.orderFile, in order to help developers getting the best ordering easier.
Signed-off-by Leonardo Bras <[email protected]>---
Please provide feedback on what else to add / remove / reorder here!
Changes since RFCv1:
- Added Kconfig* (thanks Randy Dunlap!)
- ChangedKbuildto Kbuild* (improve matching)scripts/git.orderFile | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 scripts/git.orderFilescripts/git.orderFile new file +0
-0scripts/git.orderFile line 2
Quoted 2 lines
scripts/git.orderFile new file +2
-0@@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +Please use "# SPDX-License-Identifier: GPL-2.0".
Quoted 1 line
/* ... */ is not a valid comment style for the orderfile.
Oh, you are right.
My bad, it was a last minute change.Quoted 17 lines
scripts/git.orderFile line 10
Quoted 12 lines
scripts/git.orderFile new file +8
-0+# order file for git, to produce patches which are easier to review +# by diffing the important stuff like header changes first. +# +# one-off usage: +# git diff -O scripts/git.orderfile ... +# +# add to git config: +# git config diff.orderFile scripts/git.orderfileThese comments are bogus.
Quoted 1 line
I guess this comment header was copied from QEMU,
Yes, I tried to adapt it from QEMU to kernel needs.
Quoted 4 lines
but you changed the file path
fromscripts/git.orderfiletoscripts/git.orderFile.Quoted 8 lines
You need to adjust the comment lines to
git diff -O
scripts/git.orderFile...git config diff.orderFile
scripts/git.orderFileAdjusted, thanks!
Quoted 27 lines
Or, you need to get the file path back to
scripts/git.orderfilescripts/git.orderFile line 22
Quoted 12 lines
scripts/git.orderFile new file +12
-0+# + +MAINTAINERS + +# Documentation +Documentation/* +*.rst + +# build system +Kbuild* +Kconfig* +Makefile*Kbuild* and Makefile* are interchangeable.
(both are for GNU Make)Quoted 10 lines
Kconfig* are different types.
Better to arrange the order to
Kconfig*
Kbuild*
Makefile*Oh, that makes sense.
Done!Quoted 7 lines
scripts/git.orderFile line 23
Quoted 4 lines
scripts/git.orderFile new file +1
-0+*.makQEMU consistently uses only *.mak.
Quoted 7 lines
I just realized the kernel tree uses both *.mak and *.mk
masahiro@zoe:~/ref/linux(master)$ find . -name '*.mak' ./tools/scripts/utilities.mak masahiro@zoe:~/ref/linux(master)$ find . -name '*.mk' ./tools/testing/selftests/lib.mk ./tools/testing/selftests/ptp/testptp.mkSure, I will add '*.mk' after '*.mak', getting:
# build system Kconfig* Kbuild* Makefile* *.mak *.mkQuoted 52 lines
BTW, I quickly tested this, but
it did not work as I expected.masahiro@zoe:~/ref/linux(aaa)$ git diff --name-only d34599b^..d34599b MAINTAINERS drivers/Kconfig drivers/Makefile drivers/cache/Kconfig drivers/cache/Makefile drivers/cache/ax45mp_cache.cmasahiro@zoe:~/ref/linux(aaa)$ git diff --name-only -O scripts/git.orderFile d34599b^..d34599b MAINTAINERS drivers/cache/ax45mp_cache.c drivers/Kconfig drivers/Makefile drivers/cache/Kconfig drivers/cache/Makefilemasahiro@zoe:~/ref/linux(aaa)$ git diff --name-only -O scripts/git.orderFile d34599b..d34599b^ MAINTAINERS drivers/cache/ax45mp_cache.c drivers/Kconfig drivers/Makefile drivers/cache/Kconfig drivers/cache/MakefileMy expectation was the following:
MAINTAINERSdrivers/Kconfigdrivers/cache/Kconfigdrivers/Makefiledrivers/cache/Makefiledrivers/cache/ax45mp_cache.cQuoted 2 lines
It did not work like that.
Am I missing something?I can reproduce this same behavior for this commit list, and this is odd.
When I added a line-end at the .c extension, it works as expected:
Quoted 8 lines
*.c$
I think this makes sense.
Just to make sure, I will add an line-end at every pattern with extension:*.h$
*.c$
*.mk$
Quoted 7 lines
Oh, nevermind. This breaks the matching, and results are crazy. I will revert it on a v4.
The real solver is:
*/Kconfig*
*/Kbuild*
*/Makefile*
actually, to match root dir:
*Kconfig*
*Kbuild*
*Makefile*
Quoted 38 lines
The thing is that if I add just "Kconfig*" it only matches a Kconfig* in the root dir.
Quoted 14 lines
and so on.
Does that work for you?I will send a v3 soon.
Thanks!
LeoQuoted 5 lines
Quoted 6 lines
Quoted 6 lines
scripts/git.orderFile line 29
Quoted 6 lines
scripts/git.orderFile new file +6
-0+ +# semantic patches +*.cocci + +# headers +*.hI was talking on a previous thread, and it would probably be interesting to add "*types.h" before *.h.
I need to think about a way to filter them out when matching "*.h", or it won't work because of:
Git doc:
"The output order is determined by the order of glob patterns in <orderfile>. All files with pathnames that match the first pattern are output first, all files with pathnames that match the second pattern (but not the first) are output next, and so on."
Quoted 4 lines
i.e. the file will be put in the category of the last pattern it matches, and it makes harder to get "*types.h" before "*.h".
Trying to think on some solution.
Arg, nevermind. The matching failure caused a lot of confusion in my mind.
It works fine if we do:
*types.h
*.h
*.c
Will send a v4 soon.
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 7 lines
scripts/git.orderFile new file +3
-1+ +# code +*.c --2.42.0
Signature · 2 lines
Best Regards Masahiro Yamada