riscv: dts: thead: set dma-noncoherent to soc bus

PATCH Applied Jisheng Zhang 7 participants 12 messages Sep 12, 2023 – Nov 12, 2023

Subsystems (3)

Device tree bindings RISC-V RISC-V T-Head SoC support

lore

Share & tools

lore

Jisheng Zhang

author

2023-09-12 07:34 UTC #0 lore raw

PATCH v2 1/1 riscv: dts: thead: set dma-noncoherent to soc bus

riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't dma coherent, so set dma-noncoherent to reflect this fact.

Signed-off-by Jisheng Zhang <[email protected]>

Tested-by Drew Fustini <[email protected]>

---

Since v1:
- rebase on v6.6-rc1
- collect Tested-by tag

 arch/riscv/boot/dts/thead/th1520.dtsi | 1 +
 1 file changed, 1 insertion(+)

arch/riscv/boot/dts/thead/th1520.dtsi +1 -0

index ce708183b6f6..ff364709a6df 100644
@@ -139,6 +139,7 @@ soc {
 		interrupt-parent = <&plic>;
 		#address-cells = <2>;
 		#size-cells = <2>;
+		dma-noncoherent;
 		ranges;
 
 		plic: interrupt-controller@ffd8000000 {

Signature · 1 line

2.40.1

Guo Ren

maintainer Reviewed-by on v2 1/1

2023-09-12 14:48 UTC #1 lore raw

Quoted 20 lines · Jisheng Zhang

riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't dma coherent, so set dma-noncoherent to reflect this fact.
Signed-off-by Jisheng Zhang <[email protected]>
Tested-by Drew Fustini <[email protected]>
---
Since v1:
- rebase on v6.6-rc1
- collect Tested-by tag
 arch/riscv/boot/dts/thead/th1520.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/riscv/boot/dts/thead/th1520.dtsi +0 -0
index ce708183b6f6..ff364709a6df 100644

arch/riscv/boot/dts/thead/th1520.dtsi soc { · line 142

Quoted 4 lines

arch/riscv/boot/dts/thead/th1520.dtsi +1 -0

@@ -139,6 +139,7 @@ soc {
                interrupt-parent = <&plic>;
                #address-cells = <2>;
                #size-cells = <2>;
+               dma-noncoherent;

Reviewed-by Guo Ren <[email protected]>

Quoted 6 lines

arch/riscv/boot/dts/thead/th1520.dtsi +0 -1

                ranges;
 
                plic: interrupt-controller@ffd8000000 {
--

2.40.1

Signature · 2 lines

Best Regards
 Guo Ren

Conor Dooley

2023-09-12 16:27 UTC #2 lore raw

In reply to Jisheng Zhang

Quoted 10 lines · Jisheng Zhang

riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't dma coherent, so set dma-noncoherent to reflect this fact.
Signed-off-by Jisheng Zhang <[email protected]>
Tested-by Drew Fustini <[email protected]>
---
Since v1:
- rebase on v6.6-rc1
- collect Tested-by tag

Does this mean you're expecting me to take this?

Quoted 19 lines

 arch/riscv/boot/dts/thead/th1520.dtsi | 1 +
 1 file changed, 1 insertion(+)

arch/riscv/boot/dts/thead/th1520.dtsi +1 -0

index ce708183b6f6..ff364709a6df 100644
@@ -139,6 +139,7 @@ soc {
 		interrupt-parent = <&plic>;
 		#address-cells = <2>;
 		#size-cells = <2>;
+		dma-noncoherent;
 		ranges;
 
 		plic: interrupt-controller@ffd8000000 {

Signature · 1 line

2.40.1

Jisheng Zhang

author

2023-09-13 15:27 UTC #3 lore raw

Quoted 8 lines · Conor Dooley

Quoted 7 lines · Jisheng Zhang
riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't dma coherent, so set dma-noncoherent to reflect this fact.
Signed-off-by Jisheng Zhang <[email protected]>
Tested-by Drew Fustini <[email protected]>
---

Quoted 5 lines

Quoted 3 lines
Since v1:
- rebase on v6.6-rc1
- collect Tested-by tag
Does this mean you're expecting me to take this?

Hi Conor,

I think I will take this and send PR to soc people. The reason I send v2 is the rebasing on new rc1 and v1 wasn't in linux-riscv mailist due to typo;

Thank you so much

Quoted 20 lines


 arch/riscv/boot/dts/thead/th1520.dtsi | 1 +
 1 file changed, 1 insertion(+)

arch/riscv/boot/dts/thead/th1520.dtsi +1 -0

index ce708183b6f6..ff364709a6df 100644
@@ -139,6 +139,7 @@ soc {
 		interrupt-parent = <&plic>;
 		#address-cells = <2>;
 		#size-cells = <2>;
+		dma-noncoherent;
 		ranges;
 
 		plic: interrupt-controller@ffd8000000 {

Signature · 1 line

2.40.1

Conor Dooley

2023-09-13 15:44 UTC #4 lore raw

Quoted 13 lines · Jisheng Zhang

Quoted 12 lines · Conor Dooley
Quoted 10 lines · Jisheng Zhang
riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't dma coherent, so set dma-noncoherent to reflect this fact.
Signed-off-by Jisheng Zhang <[email protected]>
Tested-by Drew Fustini <[email protected]>
---
Since v1:
- rebase on v6.6-rc1
- collect Tested-by tag

Quoted 7 lines

Quoted 1 line
Does this mean you're expecting me to take this?
Hi Conor,
I think I will take this and send PR to soc people. The reason I send v2 is the rebasing on new rc1 and v1 wasn't in linux-riscv mailist due to typo;

Great, thanks. Please ask SFR to add your tree to linux-next.

Cheers,
Conor.

Conor Dooley

2023-09-20 08:36 UTC #5 lore raw

Hey Jisheng,

Quoted 16 lines · Conor Dooley

Quoted 15 lines · Jisheng Zhang
Quoted 13 lines · Conor Dooley
Quoted 10 lines · Jisheng Zhang
riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't dma coherent, so set dma-noncoherent to reflect this fact.
Signed-off-by Jisheng Zhang <[email protected]>
Tested-by Drew Fustini <[email protected]>
---
Since v1:
- rebase on v6.6-rc1
- collect Tested-by tag
Does this mean you're expecting me to take this?

Quoted 7 lines

Quoted 5 lines
Hi Conor,
I think I will take this and send PR to soc people. The reason I send v2 is the rebasing on new rc1 and v1 wasn't in linux-riscv mailist due to typo;
Great, thanks. Please ask SFR to add your tree to linux-next.

I lost my main x86 box over the weekend (looks like probably a dead motherboard), so I may have missed a response to this.

Did you see this email? Additionally, can you add that git tree to the maintainers entry for the thead devicetrees?

Thanks,
Conor.

Jisheng Zhang

author

2023-09-21 09:36 UTC #6 lore raw

Quoted 26 lines · Conor Dooley

Hey Jisheng,
Quoted 23 lines · Conor Dooley
Quoted 13 lines · Jisheng Zhang
Quoted 12 lines · Conor Dooley
Quoted 10 lines · Jisheng Zhang
riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't dma coherent, so set dma-noncoherent to reflect this fact.
Signed-off-by Jisheng Zhang <[email protected]>
Tested-by Drew Fustini <[email protected]>
---
Since v1:
- rebase on v6.6-rc1
- collect Tested-by tag
Quoted 7 lines
Quoted 1 line
Does this mean you're expecting me to take this?
Hi Conor,
I think I will take this and send PR to soc people. The reason I send v2 is the rebasing on new rc1 and v1 wasn't in linux-riscv mailist due to typo;
Great, thanks. Please ask SFR to add your tree to linux-next.

Hi Conor,

I'm not sure how to do this. When MAINTAINERS patch is merged, send an email to Stephen Rothwell, are these steps correct?

Quoted 6 lines

I lost my main x86 box over the weekend (looks like probably a dead motherboard), so I may have missed a response to this.
Did you see this email? Additionally, can you add that git tree to the maintainers entry for the thead devicetrees?

I just created a tree in
git://git.kernel.org/pub/scm/linux/kernel/git/jszhang/linux.git

But it needs time for cgit to take place. I will send a patch once it appears.

Thanks

Conor Dooley

2023-09-21 10:08 UTC #7 lore raw

Quoted 26 lines · Jisheng Zhang

Quoted 25 lines · Conor Dooley
Hey Jisheng,
Quoted 22 lines · Conor Dooley
Quoted 20 lines · Jisheng Zhang
Quoted 8 lines · Conor Dooley
Quoted 7 lines · Jisheng Zhang
riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't dma coherent, so set dma-noncoherent to reflect this fact.
Signed-off-by Jisheng Zhang <[email protected]>
Tested-by Drew Fustini <[email protected]>
---
Quoted 5 lines
Quoted 3 lines
Since v1:
- rebase on v6.6-rc1
- collect Tested-by tag
Does this mean you're expecting me to take this?
Hi Conor,
I think I will take this and send PR to soc people. The reason I send v2 is the rebasing on new rc1 and v1 wasn't in linux-riscv mailist due to typo;

Quoted 6 lines

Quoted 1 line
Quoted 1 line
Great, thanks. Please ask SFR to add your tree to linux-next.
Hi Conor,
I'm not sure how to do this. When MAINTAINERS patch is merged, send an email to Stephen Rothwell, are these steps correct?

Sorta, yeah. You don't need to have the MAINTAINERS patch merged first though, just send him a link to your tree and the branch name(s) & he will include it in linux-next.

Quoted 11 lines

Quoted 5 lines
I lost my main x86 box over the weekend (looks like probably a dead motherboard), so I may have missed a response to this.
Did you see this email? Additionally, can you add that git tree to the maintainers entry for the thead devicetrees?
I just created a tree in
git://git.kernel.org/pub/scm/linux/kernel/git/jszhang/linux.git
But it needs time for cgit to take place. I will send a patch once it appears.

Looks to be there for me now. Thanks for doing this!

Drew Fustini

2023-10-16 17:10 UTC #8 lore raw

Quoted 44 lines · Conor Dooley

Quoted 26 lines · Jisheng Zhang
Quoted 25 lines · Conor Dooley
Hey Jisheng,
Quoted 22 lines · Conor Dooley
Quoted 20 lines · Jisheng Zhang
Quoted 8 lines · Conor Dooley
Quoted 7 lines · Jisheng Zhang
riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't dma coherent, so set dma-noncoherent to reflect this fact.
Signed-off-by Jisheng Zhang <[email protected]>
Tested-by Drew Fustini <[email protected]>
---
Quoted 5 lines
Quoted 3 lines
Since v1:
- rebase on v6.6-rc1
- collect Tested-by tag
Does this mean you're expecting me to take this?
Hi Conor,
I think I will take this and send PR to soc people. The reason I send v2 is the rebasing on new rc1 and v1 wasn't in linux-riscv mailist due to typo;
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Great, thanks. Please ask SFR to add your tree to linux-next.
Hi Conor,
I'm not sure how to do this. When MAINTAINERS patch is merged, send an email to Stephen Rothwell, are these steps correct?
Sorta, yeah. You don't need to have the MAINTAINERS patch merged first though, just send him a link to your tree and the branch name(s) & he will include it in linux-next.
Quoted 6 lines
Quoted 5 lines
I lost my main x86 box over the weekend (looks like probably a dead motherboard), so I may have missed a response to this.
Did you see this email? Additionally, can you add that git tree to the maintainers entry for the thead devicetrees?

Quoted 7 lines

Quoted 5 lines
I just created a tree in
git://git.kernel.org/pub/scm/linux/kernel/git/jszhang/linux.git
But it needs time for cgit to take place. I will send a patch once it appears.
Looks to be there for me now. Thanks for doing this!

Hi Jisheng, I'm writing the cover letter for v2 of my th1520 mmc series and I am wondering if this dma-noncoherent patch is in any tree yet?

Thanks,
Drew

Jisheng Zhang

author

2023-10-17 16:22 UTC #9 lore raw

Quoted 48 lines · Drew Fustini

Quoted 47 lines · Conor Dooley
Quoted 26 lines · Jisheng Zhang
Quoted 25 lines · Conor Dooley
Hey Jisheng,
Quoted 22 lines · Conor Dooley
Quoted 20 lines · Jisheng Zhang
Quoted 8 lines · Conor Dooley
Quoted 7 lines · Jisheng Zhang
riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't dma coherent, so set dma-noncoherent to reflect this fact.
Signed-off-by Jisheng Zhang <[email protected]>
Tested-by Drew Fustini <[email protected]>
---
Quoted 5 lines
Quoted 3 lines
Since v1:
- rebase on v6.6-rc1
- collect Tested-by tag
Does this mean you're expecting me to take this?
Hi Conor,
I think I will take this and send PR to soc people. The reason I send v2 is the rebasing on new rc1 and v1 wasn't in linux-riscv mailist due to typo;
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Great, thanks. Please ask SFR to add your tree to linux-next.
Hi Conor,
I'm not sure how to do this. When MAINTAINERS patch is merged, send an email to Stephen Rothwell, are these steps correct?
Sorta, yeah. You don't need to have the MAINTAINERS patch merged first though, just send him a link to your tree and the branch name(s) & he will include it in linux-next.
Quoted 9 lines
Quoted 5 lines
I lost my main x86 box over the weekend (looks like probably a dead motherboard), so I may have missed a response to this.
Did you see this email? Additionally, can you add that git tree to the maintainers entry for the thead devicetrees?
I just created a tree in
git://git.kernel.org/pub/scm/linux/kernel/git/jszhang/linux.git

Quoted 7 lines

Quoted 4 lines
Quoted 2 lines
But it needs time for cgit to take place. I will send a patch once it appears.
Looks to be there for me now. Thanks for doing this!
Hi Jisheng, I'm writing the cover letter for v2 of my th1520 mmc series and I am wondering if this dma-noncoherent patch is in any tree yet?

Hi Drew,

I forget this patch. Thanks for reminding.

Hi Arnd

This is the only one dt fix for thead SoC, can you please pick it up for the upcoming -rcN? I knew soc people can directly ask for pick up for only one fix in the past. Let me know if I need to generate a formal PR.

Thanks in advace

Arnd Bergmann

Applied

2023-10-17 20:33 UTC #10 lore raw

Quoted 8 lines · Jisheng Zhang

Quoted 4 lines · Drew Fustini
On Thu, Sep 21, 2023 at 11:08:28AM +0100, Conor Dooley wrote:
Hi Jisheng, I'm writing the cover letter for v2 of my th1520 mmc series and I am wondering if this dma-noncoherent patch is in any tree yet?
Hi Drew,

Quoted 8 lines

I forget this patch. Thanks for reminding.
Hi Arnd
This is the only one dt fix for thead SoC, can you please pick it up for the upcoming -rcN? I knew soc people can directly ask for pick up for only one fix in the past. Let me know if I need to generate a formal PR.

Applied to the fixes branch now, thanks.

There is no need for a pull request if you have just a single patch.

Just a few things to consider:

- For both patches and pull requests, make sure you have [email protected] as the primary recipient so I know that I'm the one to apply them and see them in https://patchwork.kernel.org/project/linux-soc/list/
I get Cc'd on a lot of patches and would otherwise not know if you are looking for them to be applied or reviewed.

- Since there is no tag description, add a comment under the '---' line asking for the patch to be applied directly, and say if this is a bugfix for the current release or if it should be queued for the next release.

Arnd

[email protected]

CI Applied

2023-11-12 00:55 UTC #11 lore raw

In reply to Jisheng Zhang

This patch was applied to riscv/linux.git (fixes) by Arnd Bergmann <[email protected]>:

Hello:

This patch was applied to riscv/linux.git (fixes)
by Arnd Bergmann <[email protected]>:

Quoted 8 lines · On Tue, 12 Sep 2023 15:22:32 +0800 you wrote:

riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't dma coherent, so set dma-noncoherent to reflect this fact.
Signed-off-by Jisheng Zhang <[email protected]>
Tested-by Drew Fustini <[email protected]>
---
[...]

Here is the summary with links:
- [v2] riscv: dts: thead: set dma-noncoherent to soc bus

    https://git.kernel.org/riscv/c/759426c758c7

You are awesome, thank you!

Signature · 2 lines

Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html