scripts/test_list.py: check key before expanding fields
PATCH 1/1 scripts/test_list.py: check key before expanding fields
From: Mauro Carvalho Chehab <[email protected]>
The logic used by doc_to_xls.py expands a field that may or may not exist, depending on the test set.
Check it to avoig errors like:
File "/home/mchehab/devel/upstream/igt-gpu-tools/scripts/test_list.py", line 819, in get_spreadsheet
for field in sorted(list(expand_field_name[item]), key=str.lower):
~~~~~~~~~~~~~~~~~^^^^^^
KeyError: 'GPU excluded platform'
--- scripts/test_list.py | 3 +++ 1 file changed, 3 insertions(+)
scripts/test_list.py +3 -0
@@ -816,6 +816,9 @@ class TestList: for item in sorted(expand_fields.keys(), key=str.lower): prefix = expand_fields[item] + if item not in expand_field_name: + continue + for field in sorted(list(expand_field_name[item]), key=str.lower): row = 0 sheet[row].append(prefix + field)
Signature · 1 line
2.41.0
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for scripts/test_list.py: check key before expanding fields
== Series Details ==
== Series Details ==
Series: scripts/test_list.py: check key before expanding fields
URL : https://patchwork.freedesktop.org/series/123587/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13623 -> IGTPW_9772
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_9772 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_9772, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9772/index.html
Participating hosts (39 -> 36)
------------------------------
Missing (3): fi-kbl-soraka fi-hsw-4770 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_9772:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_suspend@basic-s0@smem:
- bat-jsl-1: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13623/bat-jsl-1/igt@gem_exec_suspend@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9772/bat-jsl-1/igt@gem_exec_suspend@[email protected]
Known issues
------------
Here are the changes found in IGTPW_9772 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0@smem:
- bat-dg2-9: [PASS][3] -> [INCOMPLETE][4] ([i915#8797] / [i915#9275])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13623/bat-dg2-9/igt@gem_exec_suspend@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9772/bat-dg2-9/igt@gem_exec_suspend@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- bat-jsl-1: [PASS][5] -> [FAIL][6] ([fdo#103375])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13623/bat-jsl-1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9772/bat-jsl-1/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][7] ([i915#5334]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13623/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9772/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hugepages:
- bat-mtlp-8: [DMESG-WARN][9] ([i915#9121]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13623/bat-mtlp-8/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9772/bat-mtlp-8/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#485]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/485
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#8797]: https://gitlab.freedesktop.org/drm/intel/issues/8797
[i915#9121]: https://gitlab.freedesktop.org/drm/intel/issues/9121
[i915#9275]: https://gitlab.freedesktop.org/drm/intel/issues/9275
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7480 -> IGTPW_9772
CI-20190529: 20190529
CI_DRM_13623: eb35627e1c4a3781c161cd04944e403ce6df3e1c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9772: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9772/index.html
IGT_7480: a8d38db9ac258d7fd71b2cf7607e259a864f95be @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
-igt@xe_pm_residency@idle-residency-on-exec
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9772/index.html
Hi Mauro,
Quoted 5 lines · Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <[email protected]>
The logic used by
doc_to_xls.pyexpands a field that may or may not exist, depending on the test set.
Quoted 8 lines
Check it to avoig errors like:
File "
/home/mchehab/devel/upstream/igt-gpu-tools/scripts/test_list.py", line 819, inget_spreadsheet
for field insorted(list(expand_field_name[item]), key=str.lower):
~~~~~~~~~~~~~~~~~^^^^^^
KeyError: 'GPU excluded platform'Signed-off-by Mauro Carvalho Chehab <[email protected]>
Quoted 21 lines
--- scripts/test_list.py | 3 +++ 1 file changed, 3 insertions(+)scripts/test_list.py +3
-0@@ -816,6 +816,9 @@ class TestList: for item in sorted(expand_fields.keys(), key=str.lower): prefix = expand_fields[item] + if item not in expand_field_name: + continue + for field in sorted(list(expand_field_name[item]), key=str.lower): row = 0 sheet[row].append(prefix + field)Signature · 1 line
2.41.0
Patchwork
CI[igt-dev] ✓ CI.xeBAT: success for scripts/test_list.py: check key before expanding fields
In reply to Mauro Carvalho Chehab== Series Details ==
== Series Details ==
Series: scripts/test_list.py: check key before expanding fields
URL : https://patchwork.freedesktop.org/series/123587/
State : success
== Summary ==
CI Bug Log - changes from XEIGT_7480_BAT -> XEIGTPW_9772_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in XEIGTPW_9772_BAT that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1:
- bat-adlp-7: [FAIL][1] ([Intel XE#480]) -> [PASS][2] +1 other test pass
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7480/bat-adlp-7/igt@kms_flip@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_9772/bat-adlp-7/igt@kms_flip@[email protected]
[Intel XE#480]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/480
Build changes
-------------
* IGT: IGT_7480 -> IGTPW_9772
* Linux: xe-365-0533b5d42b2f8ec916646c10715ac45215e87689 -> xe-367-b4ddac861881e66a4af06531a7a72345c086bac1
IGTPW_9772: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9772/index.html
IGT_7480: a8d38db9ac258d7fd71b2cf7607e259a864f95be @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-365-0533b5d42b2f8ec916646c10715ac45215e87689: 0533b5d42b2f8ec916646c10715ac45215e87689 xe-367-b4ddac861881e66a4af06531a7a72345c086bac1: b4ddac861881e66a4af06531a7a72345c086bac1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_9772/index.html