bcachefs: Remove unneeded semicolon
PATCH 1/1 bcachefs: Remove unneeded semicolon
./fs/bcachefs/btree_gc.c:1249:2-3: Unneeded semicolon ./fs/bcachefs/btree_gc.c:1521:2-3: Unneeded semicolon ./fs/bcachefs/btree_gc.c:1575:2-3: Unneeded semicolon ./fs/bcachefs/counters.c:46:2-3: Unneeded semicolon
Signed-off-by Yang Li <[email protected]>
--- fs/bcachefs/btree_gc.c | 6 +++--- fs/bcachefs/counters.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
fs/bcachefs/btree_gc.c +3 -3
@@ -1246,7 +1246,7 @@ static int bch2_gc_done(struct bch_fs *c,copy_dev_field (d[i].sectors,"%s sectors" , bch2_data_types[i]);copy_dev_field (d[i].fragmented,"%s fragmented" , bch2_data_types[i]); } - }; + } {unsigned nr =fs_usage_u64s (c);
@@ -1518,7 +1518,7 @@ static int bch2_gc_alloc_start(struct bch_fs *c, bool metadata_only) buckets->first_bucket = ca->mi.first_bucket; buckets->nbuckets = ca->mi.nbuckets;rcu_assign_pointer (ca->buckets_gc, buckets); - }; + }bch2_trans_init (&trans, c,0 ,0 );
@@ -1572,7 +1572,7 @@ static void bch2_gc_alloc_reset(struct bch_fs *c, bool metadata_only) g->dirty_sectors =0 ; g->cached_sectors =0 ; } - }; + } } static int bch2_gc_write_reflink_key(struct btree_trans *trans,
fs/bcachefs/counters.c +1 -1
@@ -43,7 +43,7 @@ static void bch2_sb_counters_to_text(struct printbuf *out, struct bch_sb *sb,prt_tab (out);prt_printf (out,"%llu" ,le64_to_cpu (ctrs->d[i]));prt_newline (out); - }; + } };int bch2_sb_counters_to_cpu (struct bch_fs *c)
Signature · 1 line
2.20.1.7.g153144c
Quoted 7 lines · Yang Li
./fs/bcachefs/btree_gc.c:1249:2-3: Unneeded semicolon ./fs/bcachefs/btree_gc.c:1521:2-3: Unneeded semicolon ./fs/bcachefs/btree_gc.c:1575:2-3: Unneeded semicolon ./fs/bcachefs/counters.c:46:2-3: Unneeded semicolon
Signed-off-by Yang Li <[email protected]>---
What produces these warnings? It would be help to add a sentence or two of such context in the commit log.. even just a "XYZ reports the
following: ..."
Nit aside, patch seems fine to me:
Reviewed-by Brian Foster <[email protected]>
Quoted 51 lines
fs/bcachefs/btree_gc.c | 6 +++--- fs/bcachefs/counters.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)fs/bcachefs/btree_gc.c +3
-3@@ -1246,7 +1246,7 @@ static int bch2_gc_done(struct bch_fs *c,copy_dev_field (d[i].sectors,"%s sectors" , bch2_data_types[i]);copy_dev_field (d[i].fragmented,"%s fragmented" , bch2_data_types[i]); } - }; + } {unsigned nr =fs_usage_u64s (c);@@ -1518,7 +1518,7 @@ static int bch2_gc_alloc_start(struct bch_fs *c, bool metadata_only) buckets->first_bucket = ca->mi.first_bucket; buckets->nbuckets = ca->mi.nbuckets;rcu_assign_pointer (ca->buckets_gc, buckets); - }; + }bch2_trans_init (&trans, c,0 ,0 );@@ -1572,7 +1572,7 @@ static void bch2_gc_alloc_reset(struct bch_fs *c, bool metadata_only) g->dirty_sectors =0 ; g->cached_sectors =0 ; } - }; + } } static int bch2_gc_write_reflink_key(struct btree_trans *trans,fs/bcachefs/counters.c +1
-1@@ -43,7 +43,7 @@ static void bch2_sb_counters_to_text(struct printbuf *out, struct bch_sb *sb,prt_tab (out);prt_printf (out,"%llu" ,le64_to_cpu (ctrs->d[i]));prt_newline (out); - }; + } };int bch2_sb_counters_to_cpu (struct bch_fs *c)Signature · 1 line
2.20.1.7.g153144c