Skip to contentSkip to conversation

event/sw: remove obsolete comment

PATCH Applied Bruce Richardson 4 participants 5 messages Sep 14, 2023 – Sep 19, 2023

lore
Share & tools
lore

Bruce Richardson

author
#0 lore raw

PATCH 1/1 event/sw: remove obsolete comment

Code that the comment refers to was previously removed, but the comment remained.

Fixes dca926ca9faa ("event/sw: use dynamically-sized IQs")
Cc [email protected]
Signed-off-by Bruce Richardson <[email protected]>
---
 drivers/event/sw/sw_evdev_scheduler.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/event/sw/sw_evdev_scheduler.c +0 -6
index de6ed21643..17953fde0e 100644
@@ -368,12 +368,6 @@ __pull_port_lb(struct sw_evdev *sw, uint32_t port_id, int allow_reorder)
 		if (!allow_reorder && !eop)
 			flags = QE_FLAG_VALID;
 
-		/*
-		 * if we don't have space for this packet in an IQ,
-		 * then move on to next queue. Technically, for a
-		 * packet that needs reordering, we don't need to check
-		 * here, but it simplifies things not to special-case
-		 */
 		uint32_t iq_num = PRIO_TO_IQ(qe->priority);
 		struct sw_qid *qid = &sw->qids[qe->queue_id];
Signature · 1 line
2.39.2
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines

-----Original Message-----
From: Richardson, Bruce <[email protected]>
Sent: Thursday, September 14, 2023 10:38 AM
To: [email protected]
Cc: Van Haaren, Harry <[email protected]>; Richardson, Bruce <[email protected]>; [email protected]
Subject: [PATCH] event/sw: remove obsolete comment

Quoted 5 lines

Code that the comment refers to was previously removed, but the comment remained.

Fixes dca926ca9faa ("event/sw: use dynamically-sized IQs")
Cc [email protected]

Do we want to backport this? It's a code-level change, that doesn't really "fix" any issue. I'm fine with it being backported to stables, or skipped.

Acked-by Harry van Haaren <[email protected]>

<snip>

author
#2 lore raw
Quoted 11 lines · Harry
Quoted 11 lines

-----Original Message-----
From: Richardson, Bruce <[email protected]>
Sent: Thursday, September 14, 2023 10:38 AM
To: [email protected]
Cc: Van Haaren, Harry <[email protected]>; Richardson, Bruce <[email protected]>; [email protected]
Subject: [PATCH] event/sw: remove obsolete comment

Code that the comment refers to was previously removed, but the comment remained.

Quoted 8 lines
Quoted 2 lines
Fixes dca926ca9faa ("event/sw: use dynamically-sized IQs")
Cc [email protected]

Do we want to backport this? It's a code-level change, that doesn't really "fix" any issue. I'm fine with it being backported to stables, or skipped.

Acked-by Harry van Haaren <[email protected]>

I'd take the view that since backporting is going to be entirely harmless, and it does fix the code for anyone trying to read it, we might as well do so.