Skip to contentSkip to conversation

testpmd: unregister event callback

PATCH Applied [email protected] 3 participants 3 messages Sep 15, 2023 – Sep 27, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 testpmd: unregister event callback

From: Sinan Kaya <[email protected]>

Cleanup event registry during shutdown to prevent memory leaks.

---
 app/test-pmd/testpmd.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
app/test-pmd/testpmd.c +27 -0
index c6ad9b18bf..1de7b7cd51 100644
@@ -4009,6 +4009,28 @@ register_eth_event_callback(void)
 	return 0;
 }
 
+static int
+unregister_eth_event_callback(void)
+{
+	int ret;
+	enum rte_eth_event_type event;
+
+	for (event = RTE_ETH_EVENT_UNKNOWN;
+			event < RTE_ETH_EVENT_MAX; event++) {
+		ret = rte_eth_dev_callback_unregister(RTE_ETH_ALL,
+				event,
+				eth_event_callback,
+				NULL);
+		if (ret != 0) {
+			TESTPMD_LOG(ERR, "Failed to unregister callback for "
+					"%s event\n", eth_event_desc[event]);
+			return -1;
+		}
+	}
+
+	return 0;
+}
+
 /* This function is used by the interrupt thread */
 static void
 dev_event_callback(const char *device_name, enum rte_dev_event_type type,
@@ -4737,6 +4759,11 @@ main(int argc, char** argv)
 		rte_latencystats_uninit();
 #endif
 
+	ret = unregister_eth_event_callback();
+	if (ret != 0)
+		rte_exit(EXIT_FAILURE, "Cannot unregister for ethdev events");
+
+
 	ret = rte_eal_cleanup();
 	if (ret != 0)
 		rte_exit(EXIT_FAILURE,
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · On 9/15/2023 9:56 AM, [email protected] wrote:

From: Sinan Kaya <[email protected]>

Header format doesn't requires to add "From: "
as author "Signed-off" is already present.

Quoted 5 lines

Cleanup event registry during shutdown to prevent memory leaks.

Quoted 49 lines
---
  app/test-pmd/testpmd.c | 27 +++++++++++++++++++++++++++
  1 file changed, 27 insertions(+)
app/test-pmd/testpmd.c +27 -0
index c6ad9b18bf..1de7b7cd51 100644
@@ -4009,6 +4009,28 @@ register_eth_event_callback(void)
  	return 0;
  }
 
+static int
+unregister_eth_event_callback(void)
+{
+	int ret;
+	enum rte_eth_event_type event;
+
+	for (event = RTE_ETH_EVENT_UNKNOWN;
+			event < RTE_ETH_EVENT_MAX; event++) {
+		ret = rte_eth_dev_callback_unregister(RTE_ETH_ALL,
+				event,
+				eth_event_callback,
+				NULL);
+		if (ret != 0) {
+			TESTPMD_LOG(ERR, "Failed to unregister callback for "
+					"%s event\n", eth_event_desc[event]);
+			return -1;
+		}
+	}
+
+	return 0;
+}
+
  /* This function is used by the interrupt thread */
  static void
  dev_event_callback(const char *device_name, enum rte_dev_event_type type,
@@ -4737,6 +4759,11 @@ main(int argc, char** argv)
  		rte_latencystats_uninit();
  #endif
 
+	ret = unregister_eth_event_callback();
+	if (ret != 0)
+		rte_exit(EXIT_FAILURE, "Cannot unregister for ethdev events");
+
+
  	ret = rte_eal_cleanup();
  	if (ret != 0)
  		rte_exit(EXIT_FAILURE,
Applied
#2 lore raw
Quoted 8 lines · Aman Deep
Quoted 1 line · On 9/15/2023 9:56 AM, [email protected] wrote:

From: Sinan Kaya <[email protected]>

Header format doesn't requires to add "From: "
as author "Signed-off" is already present.

Quoted 1 line
Quoted 7 lines
Quoted 4 lines

Cleanup event registry during shutdown to prevent memory leaks.

Applied to dpdk-next-net/main, thanks.

(patch title and .mailmap updated while merging)