i2c: i801: unregister tco_pdev in i801_probe() error path
PATCH 1/1 i2c: i801: unregister tco_pdev in i801_probe() error path
We have to unregister tco_pdev also if i2c_add_adapter() fails.
Fixes 9424693035a5 ("i2c: i801: Create iTCO device on newer Intel PCHs")
Signed-off-by Heiner Kallweit <[email protected]>
--- drivers/i2c/busses/i2c-i801.c | 1 + 1 file changed, 1 insertion(+)
drivers/i2c/busses/i2c-i801.c +1 -0
@@ -1753,6 +1753,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id) "SMBus I801 adapter at %04lx", priv->smba); err =i2c_add_adapter (&priv->adapter);if (err) { +platform_device_unregister (priv->tco_pdev);i801_acpi_remove (priv);return err; }
Signature · 1 line
2.42.0
Quoted 5 lines · Heiner Kallweit
We have to unregister
tco_pdevalso ifi2c_add_adapter()fails.Fixes 9424693035a5 ("i2c: i801: Create iTCO device on newer Intel PCHs")Signed-off-by Heiner Kallweit <[email protected]>
Reviewed-by Mika Westerberg <[email protected]>
Quoted 14 lines · Heiner Kallweit
We have to unregister
tco_pdevalso ifi2c_add_adapter()fails.Fixes 9424693035a5 ("i2c: i801: Create iTCO device on newer Intel PCHs")Signed-off-by Heiner Kallweit <[email protected]>--- drivers/i2c/busses/i2c-i801.c | 1 + 1 file changed, 1 insertion(+)drivers/i2c/busses/i2c-i801.c +0
-0
drivers/i2c/busses/i2c-i801.c static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id) · line 1759
Quoted 7 lines
drivers/i2c/busses/i2c-i801.c +1
-0@@ -1753,6 +1753,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id) "SMBus I801 adapter at %04lx", priv->smba); err =i2c_add_adapter (&priv->adapter);if (err) { +platform_device_unregister (priv->tco_pdev);i801_acpi_remove (priv);return err; }
Reviewed-by Jean Delvare <[email protected]>
Signature · 2 lines
Jean Delvare SUSE L3 Support
Wolfram Sang
AppliedQuoted 5 lines · Heiner Kallweit
We have to unregister
tco_pdevalso ifi2c_add_adapter()fails.Fixes 9424693035a5 ("i2c: i801: Create iTCO device on newer Intel PCHs")Signed-off-by Heiner Kallweit <[email protected]>
Applied to for-current, thanks!