Skip to contentSkip to conversation

xfs: introduce protection for drop nlink

PATCH Superseded [email protected] 2 participants 2 messages Sep 18, 2023 – Sep 19, 2023 XFS filesystem

v4 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 xfs: introduce protection for drop nlink

From: Cheng Lin <[email protected]>

When abnormal drop_nlink are detected on the inode, return error, to avoid corruption propagation.

---
 fs/xfs/xfs_inode.c | 8 ++++++++
 1 file changed, 8 insertions(+)
fs/xfs/xfs_inode.c +8 -0
index 9e62cc500..d16cb62ce 100644
@@ -919,6 +919,14 @@ xfs_droplink(
 	xfs_trans_t *tp,
 	xfs_inode_t *ip)
 {
+
+	if (VFS_I(ip)->i_nlink == 0) {
+		xfs_alert(ip->i_mount,
+			  "%s: Deleting inode %llu with no links.",
+			  __func__, ip->i_ino);
+		return -EFSCORRUPTED;
+	}
+
 	xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG);
 
 	drop_nlink(VFS_I(ip));
Signature · 1 line
2.18.1
#1 lore raw
Quoted 15 lines · On Mon, Sep 18, 2023 at 02:50:50PM +0800, [email protected] wrote:

From: Cheng Lin <[email protected]>

When abnormal drop_nlink are detected on the inode, return error, to avoid corruption propagation.

---
 fs/xfs/xfs_inode.c | 8 ++++++++
 1 file changed, 8 insertions(+)
fs/xfs/xfs_inode.c +0 -0
index 9e62cc500..d16cb62ce 100644

fs/xfs/xfs_inode.c xfs_droplink( · line 926

Quoted 8 lines
fs/xfs/xfs_inode.c +5 -0
@@ -919,6 +919,14 @@ xfs_droplink(
 	xfs_trans_t *tp,
 	xfs_inode_t *ip)
 {
+
+	if (VFS_I(ip)->i_nlink == 0) {
+		xfs_alert(ip->i_mount,
+			  "%s: Deleting inode %llu with no links.",
+			  __func__, ip->i_ino);

We're not deleting the zero-nlink file, since we return without changing the link count.

Also wondering why this doesn't use XFS_IS_CORRUPT? That macro already logs a message about there being problems:

	struct xfs_mount	*mp = ip->i_mount;

	if (XFS_IS_CORRUPT(mp, VFS_I(ip)->i_nlink == 0))
		return -EFSCORRUPTED;

--D

Quoted 8 lines
fs/xfs/xfs_inode.c +3 -0
+		return -EFSCORRUPTED;
+	}
+
 	xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG);
 
 	drop_nlink(VFS_I(ip));
Signature · 1 line
2.18.1