eeprom: at24: Annotate struct at24_data with __counted_by
Subsystems (2)
PATCH 1/1 eeprom: at24: Annotate struct at24_data with __counted_by
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).
As found with Coccinelle[1], add __counted_by for struct at24_data.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
--- drivers/misc/eeprom/at24.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/eeprom/at24.c +1 -1
@@ -92,7 +92,7 @@ struct at24_data {* them for us. */ u8 bank_addr_shift; -struct regmap *client_regmaps[]; + struct regmap *client_regmaps[] __counted_by(num_addresses); };/*
Signature · 1 line
2.34.1
Quoted 8 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).As found with Coccinelle[1], add
__counted_byfor structat24_data.
Quoted 7 lines
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc Bartosz Golaszewski <[email protected]>Cc Arnd Bergmann <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Signed-off-by Kees Cook <[email protected]>
Thanks
Signature · 1 line
Gustavo
Quoted 17 lines
--- drivers/misc/eeprom/at24.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/eeprom/at24.c +1
-1@@ -92,7 +92,7 @@ struct at24_data {* them for us. */ u8 bank_addr_shift; -struct regmap *client_regmaps[]; + struct regmap *client_regmaps[] __counted_by(num_addresses); };/*
Bartosz Golaszewski
AppliedQuoted 34 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).As found with Coccinelle[1], add
__counted_byfor structat24_data.[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc Bartosz Golaszewski <[email protected]>Cc Arnd Bergmann <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Signed-off-by Kees Cook <[email protected]>--- drivers/misc/eeprom/at24.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/eeprom/at24.c +1
-2@@ -92,7 +92,7 @@ struct at24_data {* them for us. */ u8 bank_addr_shift; -struct regmap *client_regmaps[]; + struct regmap *client_regmaps[] __counted_by(num_addresses); };/* --
Quoted 2 lines
2.34.1
Applied, thanks!
Bart