i3c: svc: Annotate struct svc_i3c_xfer with __counted_by
Subsystems (2)
PATCH 1/1 i3c: svc: Annotate struct svc_i3c_xfer with __counted_by
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).
As found with Coccinelle[1], add __counted_by for struct svc_i3c_xfer.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
--- drivers/i3c/master/svc-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i3c/master/svc-i3c-master.c +1 -1
@@ -143,7 +143,7 @@ struct svc_i3c_xfer {int ret;unsigned int type;unsigned int ncmds; -struct svc_i3c_cmd cmds[]; + struct svc_i3c_cmd cmds[] __counted_by(ncmds); };struct svc_i3c_regs_save {
Signature · 1 line
2.34.1
Hi,
[email protected] wrote on Fri, 22 Sep 2023 10:50:23 -0700:
Quoted 8 lines
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).As found with Coccinelle[1], add
__counted_byfor structsvc_i3c_xfer.
Quoted 7 lines
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc Miquel Raynal <[email protected]>Cc Conor Culhane <[email protected]>Cc Alexandre Belloni <[email protected]>Signed-off-by Kees Cook <[email protected]>
Thanks,
Miquèl
Quoted 8 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).As found with Coccinelle[1], add
__counted_byfor structsvc_i3c_xfer.
Quoted 7 lines
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc Miquel Raynal <[email protected]>Cc Conor Culhane <[email protected]>Cc Alexandre Belloni <[email protected]>Signed-off-by Kees Cook <[email protected]>
Thanks
--
Gustavo
Quoted 21 lines
--- drivers/i3c/master/svc-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/i3c/master/svc-i3c-master.c +1
-1@@ -143,7 +143,7 @@ struct svc_i3c_xfer {int ret;unsigned int type;unsigned int ncmds; -struct svc_i3c_cmd cmds[]; + struct svc_i3c_cmd cmds[] __counted_by(ncmds); };struct svc_i3c_regs_save {Signature · 1 line
2.34.1
Quoted 9 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).As found with Coccinelle[1], add
__counted_byfor structsvc_i3c_xfer.[...]
Applied, thanks!
[1/1] i3c: svc: Annotate struct svc_i3c_xfer with __counted_by
commit: a8b163e184dede158c94f6392a406ac40a08fb1b
Best regards,
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com