Skip to contentSkip to conversation

ARM: dts: imx6q-b650v3: Fix fsl,tx-cal-45-dn-ohms

PATCH Applied Fabio Estevam 2 participants 3 messages Sep 23, 2023 – Sep 25, 2023

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 ARM: dts: imx6q-b650v3: Fix fsl,tx-cal-45-dn-ohms

From: Fabio Estevam <[email protected]>

Passing 55 to fsl,tx-cal-45-dn-ohms is not valid as per fsl,mxs-usbphy.yaml:

imx6q-b650v3.dtb: usbphy@20c9000: fsl,tx-cal-45-dn-ohms:0:0: 55 is greater than the maximum of 54
from schema $id: http://devicetree.org/schemas/phy/fsl,mxs-usbphy.yaml#

Pass the maximum value of 54 instead.

---
 arch/arm/boot/dts/nxp/imx/imx6q-b650v3.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/nxp/imx/imx6q-b650v3.dts +2 -2
index fa1a1df37cde..b0d345f5d071 100644
@@ -98,8 +98,8 @@ P07-hog {
 };
 
 &usbphy1 {
-	fsl,tx-cal-45-dn-ohms = <55>;
-	fsl,tx-cal-45-dp-ohms = <55>;
+	fsl,tx-cal-45-dn-ohms = <54>;
+	fsl,tx-cal-45-dp-ohms = <54>;
 	fsl,tx-d-cal = <100>;
 };
 
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author reviewer
#1 lore raw

PATCH 2/2 ARM: dts: imx6q-pistachio: Use a valid value for fsl,tx-d-cal

From: Fabio Estevam <[email protected]>

Passing 5 to fsl,tx-d-cal is not valid as per fsl,mxs-usbphy.yaml:

imx6q-pistachio.dtb: usbphy@20c9000: fsl,tx-d-cal:0:0: 5 is less than the minimum of 79
from schema $id: http://devicetree.org/schemas/phy/fsl,mxs-usbphy.yaml#

Pass the minimum value of 79 instead.

---
 arch/arm/boot/dts/nxp/imx/imx6q-pistachio.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/nxp/imx/imx6q-pistachio.dts +2 -2
index fb9f320103c6..46c6b96d8073 100644
@@ -637,11 +637,11 @@ &usbh1 {
 };
 
 &usbphy1 {
-	fsl,tx-d-cal = <0x5>;
+	fsl,tx-d-cal = <79>;
 };
 
 &usbphy2 {
-	fsl,tx-d-cal = <0x5>;
+	fsl,tx-d-cal = <79>;
 };
 
 &usdhc1 {
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Applied
#2 lore raw
In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Passing 55 to fsl,tx-cal-45-dn-ohms is not valid as per fsl,mxs-usbphy.yaml:

imx6q-b650v3.dtb: usbphy@20c9000: fsl,tx-cal-45-dn-ohms:0:0: 55 is greater than the maximum of 54
from schema $id: http://devicetree.org/schemas/phy/fsl,mxs-usbphy.yaml#

Pass the maximum value of 54 instead.

Applied both, thanks!

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel