glib-2.0: Enable possible locales with musl for ptests
PATCH 1/2 glib-2.0: Enable possible locales with musl for ptests
--- meta/recipes-core/glib-2.0/glib.inc | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
meta/recipes-core/glib-2.0/glib.inc +7 -7
@@ -171,6 +171,12 @@ RDEPENDS:${PN}-ptest += "\ python3-modules \ ${@bb.utils.contains('GI_DATA_ENABLED', 'True', 'python3-dbusmock', '', d)} \ ${PN}-codegen \ + locale-base-de-de \ + locale-base-es-es \ + locale-base-en-gb \ + locale-base-en-us \ + locale-base-fr-fr \ + locale-base-ru-ru \ " RDEPENDS:${PN}-ptest:append:libc-glibc = "\
@@ -185,18 +191,12 @@ RDEPENDS:${PN}-ptest:append:libc-glibc = "\ glibc-gconv-iso8859-15 \ glibc-charmap-invariant \ glibc-localedata-translit-cjk-variants \ - locale-base-tr-tr \ locale-base-lt-lt \ locale-base-ja-jp.euc-jp \ locale-base-fa-ir \ - locale-base-ru-ru \ - locale-base-de-de \ locale-base-hr-hr \ locale-base-el-gr \ - locale-base-fr-fr \ - locale-base-es-es \ - locale-base-en-gb \ - locale-base-en-us \ locale-base-pl-pl \ locale-base-pl-pl.iso-8859-2 \ + locale-base-tr-tr \ "
Signature · 1 line
2.42.0
PATCH 2/2 glib-2.0: Remove failing ptests on musl
FAIL: glib/convert.test (Child process killed by signal 6)
FAIL: glib/collate.test (Child process killed by signal 6)
FAIL: glib/gdatetime.test (Child process killed by signal 6)
FAIL: glib/date.test (Child process killed by signal 6)
FAIL: glib/converter-stream.test (Child process killed by signal 6)
FAIL: glib/option-context.test (Child process killed by signal 6)
--- meta/recipes-core/glib-2.0/glib.inc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
meta/recipes-core/glib-2.0/glib.inc +6 -1
@@ -134,7 +134,12 @@ do_install:append:class-target () { # https://gitlab.gnome.org/GNOME/glib/-/issues/2810 rm -f ${D}${datadir}/installed-tests/glib/thread-pool-slow.test } - +do_install:append:class-target:libc-musl () { + # Remove failing tests on musl libc systems + for t in convert.test collate.test gdatetime.test date.test converter-stream.test option-context.test; do + rm -rf ${D}${datadir}/installed-tests/glib/$t + done +} # As we do not build python3 for windows, makes no sense to ship the script that's using it do_install:append:mingw32() { rm -f ${D}${bindir}/gtester-report
Signature · 1 line
2.42.0
Re: [OE-core] [PATCH 2/2] glib-2.0: Remove failing ptests on musl
Wait, shouldn't the reason for the failures be at least mentioned, if not addressed? "Remove test because it fails" is never a valid change.
Alex
Quoted 43 lines · Khem Raj
FAIL: glib/convert.test (Child process killed by signal 6)
FAIL: glib/collate.test (Child process killed by signal 6)
FAIL: glib/gdatetime.test (Child process killed by signal 6)
FAIL: glib/date.test (Child process killed by signal 6)
FAIL: glib/converter-stream.test (Child process killed by signal 6)
FAIL: glib/option-context.test (Child process killed by signal 6)Signed-off-by Khem Raj <[email protected]>--- meta/recipes-core/glib-2.0/glib.inc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)meta/recipes-core/glib-2.0/glib.inc +6
-2@@ -134,7 +134,12 @@ do_install:append:class-target () { # https://gitlab.gnome.org/GNOME/glib/-/issues/2810 rm -f ${D}${datadir}/installed-tests/glib/thread-pool-slow.test } - +do_install:append:class-target:libc-musl () { + # Remove failing tests on musl libc systems + for t in convert.test collate.test gdatetime.test date.test converter-stream.test option-context.test; do + rm -rf ${D}${datadir}/installed-tests/glib/$t + done +} # As we do not build python3 for windows, makes no sense to ship the script that's using it do_install:append:mingw32() { rm -f ${D}${bindir}/gtester-report --2.42.0
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188154): https://lists.openembedded.org/g/openembedded-core/message/188154
Mute This Topic: https://lists.openembedded.org/mt/101546413/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 2/2] glib-2.0: Remove failing ptests on musl
Quoted 4 lines · Alexander Kanavin
Wait, shouldn't the reason for the failures be at least mentioned, if not addressed? "Remove test because it fails" is never a valid change.
They are not triaged so no root cause reason is mentioned. The failures are listed in commit with some details that ptest shows.
Quoted 47 lines
Alex
Quoted 43 lines · Khem Raj
FAIL: glib/convert.test (Child process killed by signal 6)
FAIL: glib/collate.test (Child process killed by signal 6)
FAIL: glib/gdatetime.test (Child process killed by signal 6)
FAIL: glib/date.test (Child process killed by signal 6)
FAIL: glib/converter-stream.test (Child process killed by signal 6)
FAIL: glib/option-context.test (Child process killed by signal 6)Signed-off-by Khem Raj <[email protected]>--- meta/recipes-core/glib-2.0/glib.inc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)meta/recipes-core/glib-2.0/glib.inc +6
-2@@ -134,7 +134,12 @@ do_install:append:class-target () { # https://gitlab.gnome.org/GNOME/glib/-/issues/2810 rm -f ${D}${datadir}/installed-tests/glib/thread-pool-slow.test } - +do_install:append:class-target:libc-musl () { + # Remove failing tests on musl libc systems + for t in convert.test collate.test gdatetime.test date.test converter-stream.test option-context.test; do + rm -rf ${D}${datadir}/installed-tests/glib/$t + done +} # As we do not build python3 for windows, makes no sense to ship the script that's using it do_install:append:mingw32() { rm -f ${D}${bindir}/gtester-report --2.42.0
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188154): https://lists.openembedded.org/g/openembedded-core/message/188154
Mute This Topic: https://lists.openembedded.org/mt/101546413/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 2/2] glib-2.0: Remove failing ptests on musl
Quoted 2 lines · Khem Raj
They are not triaged so no root cause reason is mentioned. The failures are listed in commit with some details that ptest shows.
I still don't understand why the failing tests should be removed. Just let them fail, or exclude glib ptest from musl CI altogether. No one wants a fake green status.
Alex
Re: [OE-core] [PATCH 2/2] glib-2.0: Remove failing ptests on musl
Quoted 8 lines · Alexander Kanavin
Quoted 2 lines · Khem Raj
They are not triaged so no root cause reason is mentioned. The failures are listed in commit with some details that ptest shows.
I still don't understand why the failing tests should be removed. Just let them fail, or exclude glib ptest from musl CI altogether. No one wants a fake green status.
This helps in creating a baseline so it does not regress further, while the information
is still maintained in the recipe if it needs to be triaged further.
Quoted 2 lines
Alex
Re: [OE-core] [PATCH 2/2] glib-2.0: Remove failing ptests on musl
Quoted 11 lines · Khem Raj
Quoted 7 lines · Khem Raj
Quoted 2 lines
They are not triaged so no root cause reason is mentioned. The failures are listed in commit with some details that ptest shows.
I still don't understand why the failing tests should be removed. Just let them fail, or exclude glib ptest from musl CI altogether. No one wants a fake green status.
This helps in creating a baseline so it does not regress further, while the information
is still maintained in the recipe if it needs to be triaged further.
This I can agree with. But can you write a better comment in the recipe itself?
Alex