Skip to contentSkip to conversation

arm64: dts: imx8mp: Describe VDD_ARM run and standby voltage for Data Modul i.MX8M Plus eDM SBC

PATCH Applied Marek Vasut 2 participants 11 messages Aug 31, 2023 – Oct 12, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: imx8mp: Describe VDD_ARM run and standby voltage for Data Modul i.MX8M Plus eDM SBC

Describe VDD_ARM (BUCK2) run and standby voltage in DT.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +2 -0
index 13674dc64be9d..d98a040860a48 100644
@@ -362,6 +362,8 @@ buck1: BUCK1 {	/* VDD_SOC (dual-phase with BUCK3) */
 			};
 
 			buck2: BUCK2 {	/* VDD_ARM */
+				nxp,dvs-run-voltage = <950000>;
+				nxp,dvs-standby-voltage = <850000>;
 				regulator-min-microvolt = <850000>;
 				regulator-max-microvolt = <1000000>;
 				regulator-ramp-delay = <3125>;
Signature · 1 line
2.40.1
#1 lore raw
Quoted 28 lines · Marek Vasut

Describe VDD_ARM (BUCK2) run and standby voltage in DT.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +0 -0
index 13674dc64be9d..d98a040860a48 100644

arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ · line 366

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +2 -0
@@ -362,6 +362,8 @@ buck1: BUCK1 {	/* VDD_SOC (dual-phase with BUCK3) */
 			};
 
 			buck2: BUCK2 {	/* VDD_ARM */
+				nxp,dvs-run-voltage = <950000>;
+				nxp,dvs-standby-voltage = <850000>;

Buck2 is not turned off in DSM on i.MX8MP?

Shawn

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +0 -0
 				regulator-min-microvolt = <850000>;
 				regulator-max-microvolt = <1000000>;
 				regulator-ramp-delay = <3125>;
Signature · 1 line
2.40.1
#2 lore raw
Quoted 31 lines · Shawn Guo
Quoted 30 lines · Marek Vasut

Describe VDD_ARM (BUCK2) run and standby voltage in DT.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
  arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts | 2 ++
  1 file changed, 2 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +0 -0
index 13674dc64be9d..d98a040860a48 100644
@@ -362,6 +362,8 @@ buck1: BUCK1 {	/* VDD_SOC (dual-phase with BUCK3) */
  			};
 
Quoted 5 lines

arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ · line 366

Quoted 3 lines
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +2 -0
  			buck2: BUCK2 {	/* VDD_ARM */
+				nxp,dvs-run-voltage = <950000>;
+				nxp,dvs-standby-voltage = <850000>;

Buck2 is not turned off in DSM on i.MX8MP?

It is turned off in SUSPEND/SNVS/OFF , not in IDLE/RUN .

#3 lore raw
Quoted 37 lines · Marek Vasut
Quoted 24 lines · Shawn Guo
Quoted 23 lines · Marek Vasut

Describe VDD_ARM (BUCK2) run and standby voltage in DT.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
  arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts | 2 ++
  1 file changed, 2 insertions(+)
Quoted 11 lines

arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ · line 365

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +2 -0
index 13674dc64be9d..d98a040860a48 100644
@@ -362,6 +362,8 @@ buck1: BUCK1 {	/* VDD_SOC (dual-phase with BUCK3) */
  			};
  			buck2: BUCK2 {	/* VDD_ARM */
+				nxp,dvs-run-voltage = <950000>;
+				nxp,dvs-standby-voltage = <850000>;

Buck2 is not turned off in DSM on i.MX8MP?

Quoted 1 line

It is turned off in SUSPEND/SNVS/OFF , not in IDLE/RUN .

Right. But nxp,dvs-standby-voltage specifies the voltage when PMIC is in STANDBY mode. My understanding is that the SoC will be in SUSPEND state while PMIC is in STANDBY mode. Is it possible that the SoC in IDLE/RUN while PMIC is in STANDBY mode at all?

Shawn

#4 lore raw
Quoted 38 lines · Shawn Guo
Quoted 37 lines · Marek Vasut
Quoted 35 lines · Shawn Guo
Quoted 28 lines · Marek Vasut

Describe VDD_ARM (BUCK2) run and standby voltage in DT.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
   arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts | 2 ++
   1 file changed, 2 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +0 -0
index 13674dc64be9d..d98a040860a48 100644

arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ · line 365

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +2 -0
@@ -362,6 +362,8 @@ buck1: BUCK1 {	/* VDD_SOC (dual-phase with BUCK3) */
   			};
   			buck2: BUCK2 {	/* VDD_ARM */
+				nxp,dvs-run-voltage = <950000>;
+				nxp,dvs-standby-voltage = <850000>;

Buck2 is not turned off in DSM on i.MX8MP?

Quoted 5 lines
Quoted 1 line

It is turned off in SUSPEND/SNVS/OFF , not in IDLE/RUN .

Right. But nxp,dvs-standby-voltage specifies the voltage when PMIC is in STANDBY mode. My understanding is that the SoC will be in SUSPEND state while PMIC is in STANDBY mode.

I agree

Quoted 2 lines

Is it possible that the SoC in
IDLE/RUN while PMIC is in STANDBY mode at all?

No, I don't think so, but there's still the PMIC part:

https://www.nxp.com/docs/en/data-sheet/PCA9450.pdf

7.3.7 STANDBY mode
"
PCA9450 transitions to STANDBY mode from RUN mode when both PMIC_ON_REQ and PMIC_STBY_REQ are driven high. BUCK1 and BUCK3 output voltage is set to BUCK1OUT_DVS1 and BUCK3OUT_DVS1 and BUCK2 are turned off when DVS_CTRL bit in each BUCKx_CTRL register is configured to 1. "

Specifically
"
BUCK2 are turned off when DVS_CTRL bit in each
BUCKx_CTRL register is configured to 1.
"

8.2.19 0x13 BUCK2CTRL
"
4
DVS_CTRL
DVS Control configuration
0b = BUCK voltage is determined by BUCK2VOUT_DVS0 register regardless of PMIC_STBY_REQ 1b = DVS control through PMIC_STBY_REQ
"

Notice that the reset-default is '0b' , so unless the PMIC is reconfigured, the BUCK2 will stay powered on even in STANDBY/SUSPEND.

#5 lore raw
Quoted 79 lines · Marek Vasut
Quoted 38 lines · Shawn Guo
Quoted 37 lines · Marek Vasut
Quoted 35 lines · Shawn Guo
Quoted 28 lines · Marek Vasut

Describe VDD_ARM (BUCK2) run and standby voltage in DT.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
   arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts | 2 ++
   1 file changed, 2 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +0 -0
index 13674dc64be9d..d98a040860a48 100644

arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ · line 365

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +2 -0
@@ -362,6 +362,8 @@ buck1: BUCK1 {	/* VDD_SOC (dual-phase with BUCK3) */
   			};
   			buck2: BUCK2 {	/* VDD_ARM */
+				nxp,dvs-run-voltage = <950000>;
+				nxp,dvs-standby-voltage = <850000>;

Buck2 is not turned off in DSM on i.MX8MP?

Quoted 5 lines
Quoted 1 line

It is turned off in SUSPEND/SNVS/OFF , not in IDLE/RUN .

Right. But nxp,dvs-standby-voltage specifies the voltage when PMIC is in STANDBY mode. My understanding is that the SoC will be in SUSPEND state while PMIC is in STANDBY mode.

I agree

Quoted 2 lines

Is it possible that the SoC in
IDLE/RUN while PMIC is in STANDBY mode at all?

No, I don't think so, but there's still the PMIC part:

https://www.nxp.com/docs/en/data-sheet/PCA9450.pdf

7.3.7 STANDBY mode
"
PCA9450 transitions to STANDBY mode from RUN mode when both PMIC_ON_REQ and PMIC_STBY_REQ are driven high. BUCK1 and BUCK3 output voltage is set to BUCK1OUT_DVS1 and BUCK3OUT_DVS1 and BUCK2 are turned off when DVS_CTRL bit in each BUCKx_CTRL register is configured to 1. "

Specifically
"
BUCK2 are turned off when DVS_CTRL bit in each
BUCKx_CTRL register is configured to 1.
"

8.2.19 0x13 BUCK2CTRL
"
4
DVS_CTRL
DVS Control configuration
0b = BUCK voltage is determined by BUCK2VOUT_DVS0 register regardless of PMIC_STBY_REQ
1b = DVS control through PMIC_STBY_REQ
"

Quoted 2 lines

Notice that the reset-default is '0b' , so unless the PMIC is reconfigured, the BUCK2 will stay powered on even in STANDBY/SUSPEND.

Hmm, isn't B2_ENMODE controlling on/off of BUCK2?

BUCK2 enable mode
00b = OFF
01b = ON by PMIC_ON_REQ = H
10b = ON by PMIC_ON_REQ = H && PMIC_STBY_REQ = L (default) 11b = Always ON

So unless you reconfigure the field, BUCK2 will be off when PMIC_STBY_REQ goes high, right?

Shawn

#6 lore raw
Quoted 85 lines · Shawn Guo
Quoted 79 lines · Marek Vasut
Quoted 38 lines · Shawn Guo
Quoted 37 lines · Marek Vasut
Quoted 35 lines · Shawn Guo
Quoted 28 lines · Marek Vasut

Describe VDD_ARM (BUCK2) run and standby voltage in DT.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
    arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts | 2 ++
    1 file changed, 2 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +0 -0
index 13674dc64be9d..d98a040860a48 100644

arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ · line 365

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +2 -0
@@ -362,6 +362,8 @@ buck1: BUCK1 {	/* VDD_SOC (dual-phase with BUCK3) */
    			};
    			buck2: BUCK2 {	/* VDD_ARM */
+				nxp,dvs-run-voltage = <950000>;
+				nxp,dvs-standby-voltage = <850000>;

Buck2 is not turned off in DSM on i.MX8MP?

Quoted 5 lines
Quoted 1 line

It is turned off in SUSPEND/SNVS/OFF , not in IDLE/RUN .

Right. But nxp,dvs-standby-voltage specifies the voltage when PMIC is in STANDBY mode. My understanding is that the SoC will be in SUSPEND state while PMIC is in STANDBY mode.

I agree

Quoted 2 lines

Is it possible that the SoC in
IDLE/RUN while PMIC is in STANDBY mode at all?

No, I don't think so, but there's still the PMIC part:

https://www.nxp.com/docs/en/data-sheet/PCA9450.pdf

7.3.7 STANDBY mode
"
PCA9450 transitions to STANDBY mode from RUN mode when both PMIC_ON_REQ and PMIC_STBY_REQ are driven high. BUCK1 and BUCK3 output voltage is set to BUCK1OUT_DVS1 and BUCK3OUT_DVS1 and BUCK2 are turned off when DVS_CTRL bit in each BUCKx_CTRL register is configured to 1. "

Specifically
"
BUCK2 are turned off when DVS_CTRL bit in each
BUCKx_CTRL register is configured to 1.
"

8.2.19 0x13 BUCK2CTRL
"
4
DVS_CTRL
DVS Control configuration
0b = BUCK voltage is determined by BUCK2VOUT_DVS0 register regardless of PMIC_STBY_REQ
1b = DVS control through PMIC_STBY_REQ
"

Quoted 2 lines

Notice that the reset-default is '0b' , so unless the PMIC is reconfigured, the BUCK2 will stay powered on even in STANDBY/SUSPEND.

Hmm, isn't B2_ENMODE controlling on/off of BUCK2?

Quoted 8 lines

BUCK2 enable mode
00b = OFF
01b = ON by PMIC_ON_REQ = H
10b = ON by PMIC_ON_REQ = H && PMIC_STBY_REQ = L (default) 11b = Always ON

So unless you reconfigure the field, BUCK2 will be off when PMIC_STBY_REQ goes high, right?

I think so.

But since the buck2 in DVS behavior is user-configurable, and this can be configured by the bootloader, I would say that it is a good idea to keep the buck2 DVS value defined in the DT, rather than keep it undefined.

Also note that this board is a development kit, so we just don't know what users might do with it.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#7 lore raw
Quoted 95 lines · Marek Vasut
Quoted 85 lines · Shawn Guo
Quoted 79 lines · Marek Vasut
Quoted 38 lines · Shawn Guo
Quoted 37 lines · Marek Vasut
Quoted 35 lines · Shawn Guo
Quoted 28 lines · Marek Vasut

Describe VDD_ARM (BUCK2) run and standby voltage in DT.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
    arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts | 2 ++
    1 file changed, 2 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +0 -0
index 13674dc64be9d..d98a040860a48 100644

arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ · line 365

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +2 -0
@@ -362,6 +362,8 @@ buck1: BUCK1 {	/* VDD_SOC (dual-phase with BUCK3) */
    			};
    			buck2: BUCK2 {	/* VDD_ARM */
+				nxp,dvs-run-voltage = <950000>;
+				nxp,dvs-standby-voltage = <850000>;

Buck2 is not turned off in DSM on i.MX8MP?

Quoted 5 lines
Quoted 1 line

It is turned off in SUSPEND/SNVS/OFF , not in IDLE/RUN .

Right. But nxp,dvs-standby-voltage specifies the voltage when PMIC is in STANDBY mode. My understanding is that the SoC will be in SUSPEND state while PMIC is in STANDBY mode.

I agree

Quoted 2 lines

Is it possible that the SoC in
IDLE/RUN while PMIC is in STANDBY mode at all?

No, I don't think so, but there's still the PMIC part:

https://www.nxp.com/docs/en/data-sheet/PCA9450.pdf

7.3.7 STANDBY mode
"
PCA9450 transitions to STANDBY mode from RUN mode when both PMIC_ON_REQ and PMIC_STBY_REQ are driven high. BUCK1 and BUCK3 output voltage is set to BUCK1OUT_DVS1 and BUCK3OUT_DVS1 and BUCK2 are turned off when DVS_CTRL bit in each BUCKx_CTRL register is configured to 1. "

Specifically
"
BUCK2 are turned off when DVS_CTRL bit in each
BUCKx_CTRL register is configured to 1.
"

8.2.19 0x13 BUCK2CTRL
"
4
DVS_CTRL
DVS Control configuration
0b = BUCK voltage is determined by BUCK2VOUT_DVS0 register regardless of PMIC_STBY_REQ
1b = DVS control through PMIC_STBY_REQ
"

Quoted 2 lines

Notice that the reset-default is '0b' , so unless the PMIC is reconfigured, the BUCK2 will stay powered on even in STANDBY/SUSPEND.

Hmm, isn't B2_ENMODE controlling on/off of BUCK2?

Quoted 8 lines

BUCK2 enable mode
00b = OFF
01b = ON by PMIC_ON_REQ = H
10b = ON by PMIC_ON_REQ = H && PMIC_STBY_REQ = L (default) 11b = Always ON

So unless you reconfigure the field, BUCK2 will be off when PMIC_STBY_REQ goes high, right?

Quoted 8 lines

I think so.

But since the buck2 in DVS behavior is user-configurable, and this can be configured by the bootloader, I would say that it is a good idea to keep the buck2 DVS value defined in the DT, rather than keep it undefined.

Also note that this board is a development kit, so we just don't know what users might do with it.

Honestly, I just do not see any reason why one would change the most power efficient default configuration to something consuming much more power.

Also, even if DVS control is enabled, 0.85 V is already the target voltage for STANDBY mode by default.

Bottom line is that we should have some comment on this change, because it makes eDM SBC so unique among all those PCA9450 based boards and makes people like me wonder why eDM SBC board needs this setting.

Shawn

#8 lore raw
Quoted 109 lines · Shawn Guo
Quoted 95 lines · Marek Vasut
Quoted 85 lines · Shawn Guo
Quoted 79 lines · Marek Vasut
Quoted 38 lines · Shawn Guo
Quoted 37 lines · Marek Vasut
Quoted 35 lines · Shawn Guo
Quoted 28 lines · Marek Vasut

Describe VDD_ARM (BUCK2) run and standby voltage in DT.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
     arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts | 2 ++
     1 file changed, 2 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +0 -0
index 13674dc64be9d..d98a040860a48 100644

arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ · line 365

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +2 -0
@@ -362,6 +362,8 @@ buck1: BUCK1 {	/* VDD_SOC (dual-phase with BUCK3) */
     			};
     			buck2: BUCK2 {	/* VDD_ARM */
+				nxp,dvs-run-voltage = <950000>;
+				nxp,dvs-standby-voltage = <850000>;

Buck2 is not turned off in DSM on i.MX8MP?

Quoted 5 lines
Quoted 1 line

It is turned off in SUSPEND/SNVS/OFF , not in IDLE/RUN .

Right. But nxp,dvs-standby-voltage specifies the voltage when PMIC is in STANDBY mode. My understanding is that the SoC will be in SUSPEND state while PMIC is in STANDBY mode.

I agree

Quoted 2 lines

Is it possible that the SoC in
IDLE/RUN while PMIC is in STANDBY mode at all?

No, I don't think so, but there's still the PMIC part:

https://www.nxp.com/docs/en/data-sheet/PCA9450.pdf

7.3.7 STANDBY mode
"
PCA9450 transitions to STANDBY mode from RUN mode when both PMIC_ON_REQ and PMIC_STBY_REQ are driven high. BUCK1 and BUCK3 output voltage is set to BUCK1OUT_DVS1 and BUCK3OUT_DVS1 and BUCK2 are turned off when DVS_CTRL bit in each BUCKx_CTRL register is configured to 1. "

Specifically
"
BUCK2 are turned off when DVS_CTRL bit in each
BUCKx_CTRL register is configured to 1.
"

8.2.19 0x13 BUCK2CTRL
"
4
DVS_CTRL
DVS Control configuration
0b = BUCK voltage is determined by BUCK2VOUT_DVS0 register regardless of PMIC_STBY_REQ
1b = DVS control through PMIC_STBY_REQ
"

Quoted 2 lines

Notice that the reset-default is '0b' , so unless the PMIC is reconfigured, the BUCK2 will stay powered on even in STANDBY/SUSPEND.

Hmm, isn't B2_ENMODE controlling on/off of BUCK2?

Quoted 8 lines

BUCK2 enable mode
00b = OFF
01b = ON by PMIC_ON_REQ = H
10b = ON by PMIC_ON_REQ = H && PMIC_STBY_REQ = L (default) 11b = Always ON

So unless you reconfigure the field, BUCK2 will be off when PMIC_STBY_REQ goes high, right?

Quoted 8 lines

I think so.

But since the buck2 in DVS behavior is user-configurable, and this can be configured by the bootloader, I would say that it is a good idea to keep the buck2 DVS value defined in the DT, rather than keep it undefined.

Also note that this board is a development kit, so we just don't know what users might do with it.

Honestly, I just do not see any reason why one would change the most power efficient default configuration to something consuming much more power.

Quoted 6 lines

Also, even if DVS control is enabled, 0.85 V is already the target voltage for STANDBY mode by default.

Bottom line is that we should have some comment on this change, because it makes eDM SBC so unique among all those PCA9450 based boards and makes people like me wonder why eDM SBC board needs this setting.

This is definitely not unique, a lot of i.MX8MP boards configure both run and standby voltage for buck2 as well, even the NXP EVK does:

next-20231011$ git grep -l dvs-standby-voltage arch/arm64/boot/dts/freescale/imx8mp* arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts arch/arm64/boot/dts/freescale/imx8mp-debix-som-a.dtsi arch/arm64/boot/dts/freescale/imx8mp-evk.dts arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp.dtsi arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql.dtsi arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi

So, can this patch go in as-is or do you want additional comment in V2?

#9 lore raw
Quoted 120 lines · Marek Vasut
Quoted 109 lines · Shawn Guo
Quoted 95 lines · Marek Vasut
Quoted 85 lines · Shawn Guo
Quoted 79 lines · Marek Vasut
Quoted 38 lines · Shawn Guo
Quoted 37 lines · Marek Vasut
Quoted 35 lines · Shawn Guo
Quoted 28 lines · Marek Vasut

Describe VDD_ARM (BUCK2) run and standby voltage in DT.

---
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frieder Schrempf <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
     arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts | 2 ++
     1 file changed, 2 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +0 -0
index 13674dc64be9d..d98a040860a48 100644

arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts buck1: BUCK1 { /* VDD_SOC (dual-phase with BUCK3) */ · line 365

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts +2 -0
@@ -362,6 +362,8 @@ buck1: BUCK1 {	/* VDD_SOC (dual-phase with BUCK3) */
     			};
     			buck2: BUCK2 {	/* VDD_ARM */
+				nxp,dvs-run-voltage = <950000>;
+				nxp,dvs-standby-voltage = <850000>;

Buck2 is not turned off in DSM on i.MX8MP?

Quoted 5 lines
Quoted 1 line

It is turned off in SUSPEND/SNVS/OFF , not in IDLE/RUN .

Right. But nxp,dvs-standby-voltage specifies the voltage when PMIC is in STANDBY mode. My understanding is that the SoC will be in SUSPEND state while PMIC is in STANDBY mode.

I agree

Quoted 2 lines

Is it possible that the SoC in
IDLE/RUN while PMIC is in STANDBY mode at all?

No, I don't think so, but there's still the PMIC part:

https://www.nxp.com/docs/en/data-sheet/PCA9450.pdf

7.3.7 STANDBY mode
"
PCA9450 transitions to STANDBY mode from RUN mode when both PMIC_ON_REQ and PMIC_STBY_REQ are driven high. BUCK1 and BUCK3 output voltage is set to BUCK1OUT_DVS1 and BUCK3OUT_DVS1 and BUCK2 are turned off when DVS_CTRL bit in each BUCKx_CTRL register is configured to 1. "

Specifically
"
BUCK2 are turned off when DVS_CTRL bit in each
BUCKx_CTRL register is configured to 1.
"

8.2.19 0x13 BUCK2CTRL
"
4
DVS_CTRL
DVS Control configuration
0b = BUCK voltage is determined by BUCK2VOUT_DVS0 register regardless of PMIC_STBY_REQ
1b = DVS control through PMIC_STBY_REQ
"

Quoted 2 lines

Notice that the reset-default is '0b' , so unless the PMIC is reconfigured, the BUCK2 will stay powered on even in STANDBY/SUSPEND.

Hmm, isn't B2_ENMODE controlling on/off of BUCK2?

Quoted 8 lines

BUCK2 enable mode
00b = OFF
01b = ON by PMIC_ON_REQ = H
10b = ON by PMIC_ON_REQ = H && PMIC_STBY_REQ = L (default) 11b = Always ON

So unless you reconfigure the field, BUCK2 will be off when PMIC_STBY_REQ goes high, right?

Quoted 8 lines

I think so.

But since the buck2 in DVS behavior is user-configurable, and this can be configured by the bootloader, I would say that it is a good idea to keep the buck2 DVS value defined in the DT, rather than keep it undefined.

Also note that this board is a development kit, so we just don't know what users might do with it.

Honestly, I just do not see any reason why one would change the most power efficient default configuration to something consuming much more power.

Quoted 6 lines

Also, even if DVS control is enabled, 0.85 V is already the target voltage for STANDBY mode by default.

Bottom line is that we should have some comment on this change, because it makes eDM SBC so unique among all those PCA9450 based boards and makes people like me wonder why eDM SBC board needs this setting.

This is definitely not unique, a lot of i.MX8MP boards configure both run and standby voltage for buck2 as well, even the NXP EVK does:

Quoted 11 lines

next-20231011$ git grep -l dvs-standby-voltage arch/arm64/boot/dts/freescale/imx8mp* arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts arch/arm64/boot/dts/freescale/imx8mp-debix-som-a.dtsi arch/arm64/boot/dts/freescale/imx8mp-evk.dts arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp.dtsi arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql.dtsi arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi

Ah, I should have done the grep myself.

Quoted 1 line

So, can this patch go in as-is or do you want additional comment in V2?

Ok, if board maintainers do not care about the cpu cycles wasted in pca9450 driver buck_set_dvs() function. I think I can live with this unnecessary DT setting.

Shawn